Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024995
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2013-10-23 11:182013-10-28 09:57
ReporterplujanView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0MP29
StatusclosedFix in branchFixed in SCM revision5f9a1bf7005c
ProjectionnoneETAnoneTarget Version3.0MP29
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0MP26.4SCM revision 
Review Assigned Toshankarb
Web browserGoogle Chrome
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2013-09-16
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/61b572f92df4 [^]
Triggers an Emergency PackNo
Summary

0024995: Navigating with Tab key while editing does not move to the next record

DescriptionWhile editing a record in the grid, Tab key moves to the next field. However, once reached the last field, pressing Tab should move to the first field of next record (or a new record if there is no more records to edit).
Instead, Tab key does nothing once at the last field.

Note that going backwards the behaviour is the expected one.
Steps To ReproduceA. Going forward (wrong behaviour)
  1. Enter as System Administrator
  2. Go to Unit of Measure window
  3. Select the first record and edit in grid mode
  4. Using Tab key, navigate through all the field, reaching the last one.
  5. Press Tab once again, nothing happens (expected behaviour, focus should move to first field of next record)
  6. Select the last record and edit in grid mode
  7. Repeat step 4
  8. Press Tab once again, nothing happens (expected behaviour, focus should move to first field of a new record)

B. Going backwards (correct behaviour)
  1. Enter as System Administrator
  2. Go to Unit of Measure window
  3. Select the second record and edit in grid mode
  4. Press Shift+Tab key and you will (as expected) moved to edit the last field of previous record)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0061866)
AugustoMauch (manager)
2013-10-23 11:56

 Test plan:
Check that [1] and [2] are no longer reproducible

[1] https://issues.openbravo.com/view.php?id=24995 [^]
[2] https://issues.openbravo.com/view.php?id=24741 [^]
(0061867)
hgbot (developer)
2013-10-23 11:57

 Repository: erp/devel/pi
Changeset: 5f9a1bf7005cebe1081d87f3c2ba21bfcafb11a3
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Oct 23 11:55:11 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5f9a1bf7005cebe1081d87f3c2ba21bfcafb11a3 [^]

Fixes bug 24995: Moving to the next record in the grid with 'Tab' does not work

In this changeset [1] it was wrongly assumed that the newRow property represented whether the record being edit was new, but it represents if the grid is about to move to a new line. To check if the row is being created, this.getEditForm().isNew should be used.

[1] https://code.openbravo.com/erp/devel/pi/rev/9138cdfbcb9badfceaf1a0eb54b4be87fec6eb35 [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0061881)
hgbot (developer)
2013-10-24 10:43

 Repository: erp/devel/pi
Changeset: 824d700983d1e6b5e4854db6333e0c9f1fe0b10d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Oct 24 10:33:39 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/824d700983d1e6b5e4854db6333e0c9f1fe0b10d [^]

Related to issue 24995: Enables tab key while creating a record in the grid

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0061889)
hudsonbot (developer)
2013-10-24 20:04

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d0465c5073ba [^]

Maturity status: Test
(0061896)
hudsonbot (developer)
2013-10-24 20:04

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d0465c5073ba [^]

Maturity status: Test
(0061916)
shankarb (reporter)
2013-10-28 09:57

 Code reviewed and verified in pi changeset e6945815f1e7.

- Issue History
Date Modified Username Field Change
2013-10-23 11:18 plujan New Issue
2013-10-23 11:18 plujan Assigned To => AugustoMauch
2013-10-23 11:18 plujan Web browser => Google Chrome
2013-10-23 11:18 plujan Modules => Core
2013-10-23 11:18 plujan Triggers an Emergency Pack => No
2013-10-23 11:19 plujan Web browser Google Chrome => Google Chrome
2013-10-23 11:19 plujan Regression level => Production - Confirmed Stable
2013-10-23 11:19 plujan Regression date => 2013-09-16
2013-10-23 11:19 plujan Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/61b572f92df4 [^]
2013-10-23 11:23 AugustoMauch Web browser Google Chrome => Google Chrome
2013-10-23 11:23 AugustoMauch Priority normal => immediate
2013-10-23 11:55 AugustoMauch Issue Monitored: shankarb
2013-10-23 11:55 AugustoMauch Review Assigned To => shankarb
2013-10-23 11:55 AugustoMauch Web browser Google Chrome => Google Chrome
2013-10-23 11:56 AugustoMauch Note Added: 0061866
2013-10-23 11:57 hgbot Checkin
2013-10-23 11:57 hgbot Note Added: 0061867
2013-10-23 11:57 hgbot Status new => resolved
2013-10-23 11:57 hgbot Resolution open => fixed
2013-10-23 11:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5f9a1bf7005cebe1081d87f3c2ba21bfcafb11a3 [^]
2013-10-24 10:43 hgbot Checkin
2013-10-24 10:43 hgbot Note Added: 0061881
2013-10-24 20:04 hudsonbot Checkin
2013-10-24 20:04 hudsonbot Note Added: 0061889
2013-10-24 20:04 hudsonbot Checkin
2013-10-24 20:04 hudsonbot Note Added: 0061896
2013-10-28 09:57 shankarb Note Added: 0061916
2013-10-28 09:57 shankarb Status resolved => closed
2013-10-28 09:57 shankarb Fixed in Version => 3.0MP29

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker