Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024995Openbravo ERPA. Platformpublic2013-10-23 11:182013-10-28 09:57
Reporterplujan 
Assigned ToAugustoMauch 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP26.4 
Target Version3.0MP29Fixed in Version3.0MP29 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customerNo
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2013-09-16
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/61b572f92df4 [^]
Triggers an Emergency PackNo
Summary0024995: Navigating with Tab key while editing does not move to the next record
DescriptionWhile editing a record in the grid, Tab key moves to the next field. However, once reached the last field, pressing Tab should move to the first field of next record (or a new record if there is no more records to edit).
Instead, Tab key does nothing once at the last field.

Note that going backwards the behaviour is the expected one.
Steps To ReproduceA. Going forward (wrong behaviour)
  1. Enter as System Administrator
  2. Go to Unit of Measure window
  3. Select the first record and edit in grid mode
  4. Using Tab key, navigate through all the field, reaching the last one.
  5. Press Tab once again, nothing happens (expected behaviour, focus should move to first field of next record)
  6. Select the last record and edit in grid mode
  7. Repeat step 4
  8. Press Tab once again, nothing happens (expected behaviour, focus should move to first field of a new record)

B. Going backwards (correct behaviour)
  1. Enter as System Administrator
  2. Go to Unit of Measure window
  3. Select the second record and edit in grid mode
  4. Press Shift+Tab key and you will (as expected) moved to edit the last field of previous record)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-10-23 11:18plujanNew Issue
2013-10-23 11:18plujanAssigned To => AugustoMauch
2013-10-23 11:18plujanWeb browser => Google Chrome
2013-10-23 11:18plujanModules => Core
2013-10-23 11:18plujanOBNetwork customer => No
2013-10-23 11:18plujanTriggers an Emergency Pack => No
2013-10-23 11:19plujanWeb browserGoogle Chrome => Google Chrome
2013-10-23 11:19plujanRegression level => Production - Confirmed Stable
2013-10-23 11:19plujanRegression date => 2013-09-16
2013-10-23 11:19plujanRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/61b572f92df4 [^]
2013-10-23 11:23AugustoMauchWeb browserGoogle Chrome => Google Chrome
2013-10-23 11:23AugustoMauchPrioritynormal => immediate
2013-10-23 11:55AugustoMauchIssue Monitored: shankarb
2013-10-23 11:55AugustoMauchReview Assigned To => shankarb
2013-10-23 11:55AugustoMauchWeb browserGoogle Chrome => Google Chrome
2013-10-23 11:56AugustoMauchNote Added: 0061866
2013-10-23 11:57hgbotCheckin
2013-10-23 11:57hgbotNote Added: 0061867
2013-10-23 11:57hgbotStatusnew => resolved
2013-10-23 11:57hgbotResolutionopen => fixed
2013-10-23 11:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5f9a1bf7005cebe1081d87f3c2ba21bfcafb11a3 [^]
2013-10-24 10:43hgbotCheckin
2013-10-24 10:43hgbotNote Added: 0061881
2013-10-24 20:04hudsonbotCheckin
2013-10-24 20:04hudsonbotNote Added: 0061889
2013-10-24 20:04hudsonbotCheckin
2013-10-24 20:04hudsonbotNote Added: 0061896
2013-10-28 09:57shankarbNote Added: 0061916
2013-10-28 09:57shankarbStatusresolved => closed
2013-10-28 09:57shankarbFixed in Version => 3.0MP29

Notes
(0061866)
AugustoMauch   
2013-10-23 11:56   
Test plan:
Check that [1] and [2] are no longer reproducible

[1] https://issues.openbravo.com/view.php?id=24995 [^]
[2] https://issues.openbravo.com/view.php?id=24741 [^]
(0061867)
hgbot   
2013-10-23 11:57   
Repository: erp/devel/pi
Changeset: 5f9a1bf7005cebe1081d87f3c2ba21bfcafb11a3
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Oct 23 11:55:11 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5f9a1bf7005cebe1081d87f3c2ba21bfcafb11a3 [^]

Fixes bug 24995: Moving to the next record in the grid with 'Tab' does not work

In this changeset [1] it was wrongly assumed that the newRow property represented whether the record being edit was new, but it represents if the grid is about to move to a new line. To check if the row is being created, this.getEditForm().isNew should be used.

[1] https://code.openbravo.com/erp/devel/pi/rev/9138cdfbcb9badfceaf1a0eb54b4be87fec6eb35 [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0061881)
hgbot   
2013-10-24 10:43   
Repository: erp/devel/pi
Changeset: 824d700983d1e6b5e4854db6333e0c9f1fe0b10d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Oct 24 10:33:39 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/824d700983d1e6b5e4854db6333e0c9f1fe0b10d [^]

Related to issue 24995: Enables tab key while creating a record in the grid

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0061889)
hudsonbot   
2013-10-24 20:04   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d0465c5073ba [^]

Maturity status: Test
(0061896)
hudsonbot   
2013-10-24 20:04   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d0465c5073ba [^]

Maturity status: Test
(0061916)
shankarb   
2013-10-28 09:57   
Code reviewed and verified in pi changeset e6945815f1e7.