Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0023006 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | major | always | 2013-02-07 13:04 | 2013-03-22 10:57 | |||
Reporter | ngarcia | View Status | public | |||||
Assigned To | AugustoMauch | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | 3.0MP22 | |||
Status | closed | Fix in branch | Fixed in SCM revision | d8b08c8bbe88 | ||||
Projection | none | ETA | none | Target Version | 3.0MP22 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | pi | SCM revision | ||||||
Review Assigned To | mtaal | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0023006: Wrong records shown in grid when the filter is entered before loading the records | |||||||
Description | Wrong records shown in grid when the filter is entered before loading the records | |||||||
Steps To Reproduce | As group admin role: Go to the Goods Shipment window and delete the transactional filter Add a new filter in the Document No. column (for example: 33) Delete that filter and add a new one in the same column(for example: 44) before the records are loaded Check that the filter is not applied | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |||||||||||||||
|
Notes | |
(0057158) hgbot (developer) 2013-03-08 12:01 |
Repository: erp/devel/pi Changeset: d8b08c8bbe88337c7383c3ae975248077ec738e9 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Fri Mar 08 12:00:23 2013 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/d8b08c8bbe88337c7383c3ae975248077ec738e9 [^] Fixes issue 23006: Fixes simultaneous calls to the datasource when filtering Before this fix, if a call to the datasource was done before the response of the previous call was received, the response of the second call would not be applied. The second response was not applied because of this code [1]. This code handled a special case that happened when the user scrolled the grid to see more records. There is no need to execute this code when the origin of the call the the datasource is a filter request. This has been fixed by including a parameter called 'filtering' in the datasource request only when its origin in the filter. Then, the code [1] is only executed when this parameter is not set to true. [1] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js#l248 [^] --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js --- |
(0057159) AugustoMauch (administrator) 2013-03-08 12:10 |
The easiest way to reproduce this issue: - In the beginning of the service method of the DataSourceServlet class, add this: Thread.sleep(3000). This will stop the thread at that point for 3 seconds. - Open any window (i.e. Country and Region). - Enter some text in the filter (i.e. "and" in the name column) - The moment the grid shows the "Loading data" message, change the filter text (i.e. "andor"). - Before the fix, after receiving both responses the latest filter was not applied, only the first one is applied. - After the fix, first the former filter will be applied, and then the latter filter will be applied. |
(0057384) mtaal (manager) 2013-03-22 10:57 |
Reviewed |
Issue History | |||
Date Modified | Username | Field | Change |
2013-02-07 13:04 | ngarcia | New Issue | |
2013-02-07 13:04 | ngarcia | Assigned To | => AugustoMauch |
2013-02-07 13:04 | ngarcia | Modules | => Core |
2013-02-07 13:04 | ngarcia | Resolution time | => 1363129200 |
2013-02-07 13:04 | ngarcia | Triggers an Emergency Pack | => No |
2013-02-07 13:04 | ngarcia | Issue Monitored: networkb | |
2013-02-19 23:10 | ngarcia | Target Version | 3.0MP22 => 3.0MP21 |
2013-02-20 09:46 | ngarcia | Target Version | 3.0MP21 => 3.0MP22 |
2013-03-06 11:23 | AugustoMauch | Relationship added | related to 0018137 |
2013-03-08 11:10 | AugustoMauch | Issue Monitored: mtaal | |
2013-03-08 11:10 | AugustoMauch | Review Assigned To | => mtaal |
2013-03-08 12:01 | hgbot | Checkin | |
2013-03-08 12:01 | hgbot | Note Added: 0057158 | |
2013-03-08 12:01 | hgbot | Status | new => resolved |
2013-03-08 12:01 | hgbot | Resolution | open => fixed |
2013-03-08 12:01 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d8b08c8bbe88337c7383c3ae975248077ec738e9 [^] |
2013-03-08 12:10 | AugustoMauch | Note Added: 0057159 | |
2013-03-22 10:57 | mtaal | Note Added: 0057384 | |
2013-03-22 10:57 | mtaal | Status | resolved => closed |
2013-03-22 10:57 | mtaal | Fixed in Version | => 3.0MP22 |
2014-02-24 11:58 | alostale | Relationship added | related to 0025789 |
Copyright © 2000 - 2009 MantisBT Group |