Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023006Openbravo ERPA. Platformpublic2013-02-07 13:042013-03-22 10:57
Reporterngarcia 
Assigned ToAugustoMauch 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP22Fixed in Version3.0MP22 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023006: Wrong records shown in grid when the filter is entered before loading the records
DescriptionWrong records shown in grid when the filter is entered before loading the records
Steps To ReproduceAs group admin role:

Go to the Goods Shipment window and delete the transactional filter
Add a new filter in the Document No. column (for example: 33)
Delete that filter and add a new one in the same column(for example: 44) before the records are loaded
Check that the filter is not applied
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0018137 closed mtaal Incorrect filtering on slow tables 
related to defect 0025789 closed alostale Duplicated records appearing in the grid after refreshing having all the records selected 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-02-07 13:04ngarciaNew Issue
2013-02-07 13:04ngarciaAssigned To => AugustoMauch
2013-02-07 13:04ngarciaModules => Core
2013-02-07 13:04ngarciaResolution time => 1363129200
2013-02-07 13:04ngarciaTriggers an Emergency Pack => No
2013-02-07 13:04ngarciaIssue Monitored: networkb
2013-02-19 23:10ngarciaTarget Version3.0MP22 => 3.0MP21
2013-02-20 09:46ngarciaTarget Version3.0MP21 => 3.0MP22
2013-03-06 11:23AugustoMauchRelationship addedrelated to 0018137
2013-03-08 11:10AugustoMauchIssue Monitored: mtaal
2013-03-08 11:10AugustoMauchReview Assigned To => mtaal
2013-03-08 12:01hgbotCheckin
2013-03-08 12:01hgbotNote Added: 0057158
2013-03-08 12:01hgbotStatusnew => resolved
2013-03-08 12:01hgbotResolutionopen => fixed
2013-03-08 12:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d8b08c8bbe88337c7383c3ae975248077ec738e9 [^]
2013-03-08 12:10AugustoMauchNote Added: 0057159
2013-03-22 10:57mtaalNote Added: 0057384
2013-03-22 10:57mtaalStatusresolved => closed
2013-03-22 10:57mtaalFixed in Version => 3.0MP22
2014-02-24 11:58alostaleRelationship addedrelated to 0025789

Notes
(0057158)
hgbot   
2013-03-08 12:01   
Repository: erp/devel/pi
Changeset: d8b08c8bbe88337c7383c3ae975248077ec738e9
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Mar 08 12:00:23 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d8b08c8bbe88337c7383c3ae975248077ec738e9 [^]

Fixes issue 23006: Fixes simultaneous calls to the datasource when filtering

Before this fix, if a call to the datasource was done before the response of the previous call was received, the response of the second call would not be applied. The second response was not applied because of this code [1]. This code handled a special case that happened when the user scrolled the grid to see more records. There is no need to execute this code when the origin of the call the the datasource is a filter request.

This has been fixed by including a parameter called 'filtering' in the datasource request only when its origin in the filter. Then, the code [1] is only executed when this parameter is not set to true.

[1] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js#l248 [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0057159)
AugustoMauch   
2013-03-08 12:10   
The easiest way to reproduce this issue:
- In the beginning of the service method of the DataSourceServlet class, add this:
Thread.sleep(3000). This will stop the thread at that point for 3 seconds.
- Open any window (i.e. Country and Region).
- Enter some text in the filter (i.e. "and" in the name column)
- The moment the grid shows the "Loading data" message, change the filter text (i.e. "andor").
- Before the fix, after receiving both responses the latest filter was not applied, only the first one is applied.
- After the fix, first the former filter will be applied, and then the latter filter will be applied.
(0057384)
mtaal   
2013-03-22 10:57   
Reviewed