Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0022436
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajorhave not tried2012-11-30 11:212012-12-06 15:12
ReportershuehnerView Statuspublic 
Assigned Tocaristu 
PriorityimmediateResolutionfixedFixed in Version3.0MP18
StatusclosedFix in branchFixed in SCM revisionebca3ab5ca86
ProjectionnoneETAnoneTarget Version3.0MP18
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tojonalegriaesarte
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2012-11-27
Regression introduced in release
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/b43e48d603a93ef7bc008b7121376c15d98a3ced [^]
Triggers an Emergency PackNo
Summary

0022436: Newly added check contraints don't follow modularity rules

DescriptionThe newly added check constraint from issue 21590 (2nd cset) do not follow modularity naming rules as they should all three start with the tablename to avoid naming collisions.

BPNAME_CHK
REFERENCE_CHK
TRANSACTIONDATE_CHK

Note: Technically that will be an api-change as new check constraints are added for existing columns.
But functionally no problem as in reality only the name of the constraint changes and not change in their content.
Steps To ReproduceRun export.database and check export warnings.

+++++++++++++++++++++++++++++++++++++++++++++++++++
Warnings for Validation type: INCORRECT_CHECK_NAME
+++++++++++++++++++++++++++++++++++++++++++++++++++
Table FIN_MATCHING_ALGORITHM has check constraint key named BPNAME_CHK, which does not starts by module's DBPrefix.
Table FIN_MATCHING_ALGORITHM has check constraint key named REFERENCE_CHK, which does not starts by module's DBPrefix.
Table FIN_MATCHING_ALGORITHM has check constraint key named TRANSACTIONDATE_CHK, which does not starts by module's DBPrefix.
Proposed SolutionRename the check constraints.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00215903.0MP16 closedioritzCia Standard matching algorithm is not considering transaction date 

-  Notes
(0054706)
hgbot (developer)
2012-12-04 16:20

 Repository: erp/devel/pi
Changeset: ebca3ab5ca867ddf82aa21fc18e0c2ff34cc94e5
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Dec 04 16:18:21 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ebca3ab5ca867ddf82aa21fc18e0c2ff34cc94e5 [^]

fixes issue 22436: Newly added check contraints don't follow
modularity rules

---
M src-db/database/model/tables/FIN_MATCHING_ALGORITHM.xml
---
(0054716)
jonalegriaesarte (viewer)
2012-12-05 09:47

 Code review done. Verified.
(0054751)
hudsonbot (viewer)
2012-12-06 15:12

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d438f7014f16 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-11-30 11:21 shuehner New Issue
2012-11-30 11:21 shuehner Assigned To => dmiguelez
2012-11-30 11:21 shuehner Modules => Core
2012-11-30 11:21 shuehner OBNetwork customer => No
2012-11-30 11:21 shuehner Relationship added related to 0021590
2012-11-30 11:24 shuehner Regression level => Production - Confirmed Stable
2012-11-30 11:24 shuehner Regression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/b43e48d603a93ef7bc008b7121376c15d98a3ced [^]
2012-11-30 13:29 shuehner Regression date => 2012-11-27
2012-12-04 12:49 jonalegriaesarte Assigned To dmiguelez => caristu
2012-12-04 16:20 hgbot Checkin
2012-12-04 16:20 hgbot Note Added: 0054706
2012-12-04 16:20 hgbot Status new => resolved
2012-12-04 16:20 hgbot Resolution open => fixed
2012-12-04 16:20 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ebca3ab5ca867ddf82aa21fc18e0c2ff34cc94e5 [^]
2012-12-05 09:47 jonalegriaesarte Review Assigned To => jonalegriaesarte
2012-12-05 09:47 jonalegriaesarte Note Added: 0054716
2012-12-05 09:47 jonalegriaesarte Status resolved => closed
2012-12-05 09:47 jonalegriaesarte Fixed in Version => 3.0MP18
2012-12-06 15:12 hudsonbot Checkin
2012-12-06 15:12 hudsonbot Note Added: 0054751

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker