Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0021590
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminoralways2012-09-10 13:392012-11-28 11:19
ReportermaiteView Statuspublic 
Assigned ToioritzCia 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision4e6bdb057dbd
ProjectionnoneETAnoneTarget Version3.0MP16
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket16834
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0021590: Standard matching algorithm is not considering transaction date

DescriptionStandard matching algorithm is not considering transaction date
Steps To ReproduceVerify that method "getMatchingFinancialTransaction" (in "match" method of StandardMatchingAlgorithm.java) is not using "line.getTransactionDate()" parameter (although this parameter is supported by this method in MatchTransactionDao.java).
Add this parameter to be used in getMatchingFinancialTransaction method
Proposed Solution- Substitute code
"List<FIN_FinaccTransaction> transactions = MatchTransactionDao.getMatchingFinancialTransaction(
        line.getBankStatement().getAccount().getId(), line.getReferenceNo(),
        (line.getCramount().subtract(line.getDramount())), line.getBpartnername(), excluded);"
by
"List<FIN_FinaccTransaction> transactions = MatchTransactionDao.getMatchingFinancialTransaction(
        line.getBankStatement().getAccount().getId(), line.getTransactionDate(), line.getReferenceNo(),
        (line.getCramount().subtract(line.getDramount())), line.getBpartnername(), excluded);"

- Substitute code
"transactions = MatchTransactionDao.getMatchingFinancialTransaction(line.getBankStatement()
        .getAccount().getId(), line.getCramount().subtract(line.getDramount()), excluded);"
by
"transactions = MatchTransactionDao.getMatchingFinancialTransaction(line.getBankStatement()
        .getAccount().getId(), line.getTransactionDate(), line.getCramount().subtract(line.getDramount()), excluded);
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00224363.0MP18 closedcaristu Newly added check contraints don't follow modularity rules 

-  Notes
(0052183)
hgbot (developer)
2012-09-18 09:25

 Repository: erp/devel/pi
Changeset: 4e6bdb057dbdfbdbbb1eca615f8964386c4505fa
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Fri Sep 14 14:21:28 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4e6bdb057dbdfbdbbb1eca615f8964386c4505fa [^]

Fixes issue 21590: Standard matching algorithm not considering transaction date

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/algorithm/StandardMatchingAlgorithm.java
---
(0052302)
maite (viewer)
2012-09-24 09:32

 verified
(0052778)
hudsonbot (viewer)
2012-09-26 17:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test
(0054513)
hgbot (developer)
2012-11-27 10:37

 Repository: erp/devel/pi
Changeset: b43e48d603a93ef7bc008b7121376c15d98a3ced
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Tue Nov 27 10:36:17 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b43e48d603a93ef7bc008b7121376c15d98a3ced [^]

Related to issue 21590: Standard matching algorithm
is not considering transaction date. New mathing logic added to the Standard matching algorithm.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELDGROUP.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/algorithm/StandardMatchingAlgorithm.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/MatchTransactionDao.java
M src-db/database/model/tables/FIN_MATCHING_ALGORITHM.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0054613)
hudsonbot (viewer)
2012-11-27 19:41

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/eaf1a8bdbf4e [^]

Maturity status: Test
(0054625)
maite (viewer)
2012-11-28 11:19

 new changes reviewed

- Issue History
Date Modified Username Field Change
2012-09-10 13:39 maite New Issue
2012-09-10 13:39 maite Assigned To => dmiguelez
2012-09-10 13:39 maite Modules => Advanced Payables and Receivables Mngmt
2012-09-10 13:39 maite OBNetwork customer => Yes
2012-09-10 13:39 maite Support ticket => 16834
2012-09-10 13:39 maite Issue Monitored: networkb
2012-09-10 13:40 maite Assigned To dmiguelez => jonalegriaesarte
2012-09-10 13:43 maite Target Version 3.0MP17 => 3.0MP16
2012-09-14 14:18 ioritzCia Assigned To jonalegriaesarte => ioritzCia
2012-09-14 14:18 ioritzCia Status new => scheduled
2012-09-14 14:18 ioritzCia fix_in_branch => pi
2012-09-18 09:25 hgbot Checkin
2012-09-18 09:25 hgbot Note Added: 0052183
2012-09-18 09:25 hgbot Status scheduled => resolved
2012-09-18 09:25 hgbot Resolution open => fixed
2012-09-18 09:25 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4e6bdb057dbdfbdbbb1eca615f8964386c4505fa [^]
2012-09-24 09:32 maite Note Added: 0052302
2012-09-24 09:32 maite Status resolved => closed
2012-09-26 17:19 hudsonbot Checkin
2012-09-26 17:19 hudsonbot Note Added: 0052778
2012-11-27 10:37 hgbot Checkin
2012-11-27 10:37 hgbot Note Added: 0054513
2012-11-27 19:41 hudsonbot Checkin
2012-11-27 19:41 hudsonbot Note Added: 0054613
2012-11-28 11:19 maite Note Added: 0054625
2012-11-30 11:21 shuehner Relationship added related to 0022436

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker