Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022436Openbravo ERP09. Financial managementpublic2012-11-30 11:212012-12-06 15:12
Reportershuehner 
Assigned Tocaristu 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP18Fixed in Version3.0MP18 
Merge Request Status
Review Assigned Tojonalegriaesarte
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2012-11-27
Regression introduced in release
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/b43e48d603a93ef7bc008b7121376c15d98a3ced [^]
Triggers an Emergency PackNo
Summary0022436: Newly added check contraints don't follow modularity rules
DescriptionThe newly added check constraint from issue 21590 (2nd cset) do not follow modularity naming rules as they should all three start with the tablename to avoid naming collisions.

BPNAME_CHK
REFERENCE_CHK
TRANSACTIONDATE_CHK

Note: Technically that will be an api-change as new check constraints are added for existing columns.
But functionally no problem as in reality only the name of the constraint changes and not change in their content.
Steps To ReproduceRun export.database and check export warnings.

+++++++++++++++++++++++++++++++++++++++++++++++++++
Warnings for Validation type: INCORRECT_CHECK_NAME
+++++++++++++++++++++++++++++++++++++++++++++++++++
Table FIN_MATCHING_ALGORITHM has check constraint key named BPNAME_CHK, which does not starts by module's DBPrefix.
Table FIN_MATCHING_ALGORITHM has check constraint key named REFERENCE_CHK, which does not starts by module's DBPrefix.
Table FIN_MATCHING_ALGORITHM has check constraint key named TRANSACTIONDATE_CHK, which does not starts by module's DBPrefix.
Proposed SolutionRename the check constraints.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00215903.0MP16 closed ioritzCia Standard matching algorithm is not considering transaction date 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-11-30 11:21shuehnerNew Issue
2012-11-30 11:21shuehnerAssigned To => dmiguelez
2012-11-30 11:21shuehnerModules => Core
2012-11-30 11:21shuehnerRelationship addedrelated to 0021590
2012-11-30 11:24shuehnerRegression level => Production - Confirmed Stable
2012-11-30 11:24shuehnerRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/b43e48d603a93ef7bc008b7121376c15d98a3ced [^]
2012-11-30 13:29shuehnerRegression date => 2012-11-27
2012-12-04 12:49jonalegriaesarteAssigned Todmiguelez => caristu
2012-12-04 16:20hgbotCheckin
2012-12-04 16:20hgbotNote Added: 0054706
2012-12-04 16:20hgbotStatusnew => resolved
2012-12-04 16:20hgbotResolutionopen => fixed
2012-12-04 16:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ebca3ab5ca867ddf82aa21fc18e0c2ff34cc94e5 [^]
2012-12-05 09:47jonalegriaesarteReview Assigned To => jonalegriaesarte
2012-12-05 09:47jonalegriaesarteNote Added: 0054716
2012-12-05 09:47jonalegriaesarteStatusresolved => closed
2012-12-05 09:47jonalegriaesarteFixed in Version => 3.0MP18
2012-12-06 15:12hudsonbotCheckin
2012-12-06 15:12hudsonbotNote Added: 0054751

Notes
(0054706)
hgbot   
2012-12-04 16:20   
Repository: erp/devel/pi
Changeset: ebca3ab5ca867ddf82aa21fc18e0c2ff34cc94e5
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Dec 04 16:18:21 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ebca3ab5ca867ddf82aa21fc18e0c2ff34cc94e5 [^]

fixes issue 22436: Newly added check contraints don't follow
modularity rules

---
M src-db/database/model/tables/FIN_MATCHING_ALGORITHM.xml
---
(0054716)
jonalegriaesarte   
2012-12-05 09:47   
Code review done. Verified.
(0054751)
hudsonbot   
2012-12-06 15:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d438f7014f16 [^]

Maturity status: Test