Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0021267
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementminoralways2012-07-31 15:112012-08-28 10:52
ReportereintelauView Statuspublic 
Assigned Tonaiaramartinez 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisiond3245331b58a
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionProfessional ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0021267: Orders in "Under Way" status insert m_storage_pending records for non stocked items

DescriptionThe fix for issue 20730 (https://issues.openbravo.com/view.php?id=20730 [^]) does not check if a line is for a stocked product before calling m_update_storage_pending.

This will result in records for non-stocked products in the storage pending table which is not consistent
Steps To Reproduce1) Create a Sales Order
2) Add a line for a non stocked product
3) Book the order and choose Process
4) Check the m_storage_pending table and see that a record has been inserted for the non stocked product
Proposed SolutionAmend the trigger as per the attached file
TagsNo tags attached.
Attached Filesxml file icon C_ORDERLINE2_TRG.xml [^] (4,888 bytes) 2012-07-31 15:11

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0051582)
naiaramartinez (developer)
2012-08-28 10:48

Thanks for the contribution. We have done the code review and it looks great.

We will include this patch in mp15.
(0051583)
hgbot (developer)
2012-08-28 10:50

Repository: erp/devel/pi
Changeset: d3245331b58a6b9590ef808482778d744ff53114
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Mon Aug 06 10:13:25 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d3245331b58a6b9590ef808482778d744ff53114 [^]

fixed bug 21267:Not insert in m_storage_pending for stocked=N product
Contribution from eintelau

---
M src-db/database/model/triggers/C_ORDERLINE2_TRG.xml
---
(0051584)
dmiguelez (developer)
2012-08-28 10:51

Code Review + Testing OK

- Issue History
Date Modified Username Field Change
2012-07-31 15:11 eintelau New Issue
2012-07-31 15:11 eintelau Assigned To => mirurita
2012-07-31 15:11 eintelau File Added: C_ORDERLINE2_TRG.xml
2012-07-31 15:11 eintelau Modules => Core
2012-08-03 12:22 naiaramartinez Assigned To mirurita => naiaramartinez
2012-08-22 11:00 naiaramartinez Status new => scheduled
2012-08-22 11:00 naiaramartinez fix_in_branch => pi
2012-08-28 10:48 naiaramartinez Note Added: 0051582
2012-08-28 10:50 hgbot Checkin
2012-08-28 10:50 hgbot Note Added: 0051583
2012-08-28 10:50 hgbot Status scheduled => resolved
2012-08-28 10:50 hgbot Resolution open => fixed
2012-08-28 10:50 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d3245331b58a6b9590ef808482778d744ff53114 [^]
2012-08-28 10:51 dmiguelez Note Added: 0051584
2012-08-28 10:52 dmiguelez Closed by => dmiguelez
2012-08-28 10:52 dmiguelez Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker