Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021267Openbravo ERP07. Sales managementpublic2012-07-31 15:112012-08-28 10:52
Reportereintelau 
Assigned Tonaiaramartinez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021267: Orders in "Under Way" status insert m_storage_pending records for non stocked items
DescriptionThe fix for issue 20730 (https://issues.openbravo.com/view.php?id=20730 [^]) does not check if a line is for a stocked product before calling m_update_storage_pending.

This will result in records for non-stocked products in the storage pending table which is not consistent
Steps To Reproduce1) Create a Sales Order
2) Add a line for a non stocked product
3) Book the order and choose Process
4) Check the m_storage_pending table and see that a record has been inserted for the non stocked product
Proposed SolutionAmend the trigger as per the attached file
Additional Information
TagsNo tags attached.
Relationships
Attached Filesxml C_ORDERLINE2_TRG.xml (4,888) 2012-07-31 15:11
https://issues.openbravo.com/file_download.php?file_id=5483&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-07-31 15:11eintelauNew Issue
2012-07-31 15:11eintelauAssigned To => mirurita
2012-07-31 15:11eintelauFile Added: C_ORDERLINE2_TRG.xml
2012-07-31 15:11eintelauModules => Core
2012-08-03 12:22naiaramartinezAssigned Tomirurita => naiaramartinez
2012-08-22 11:00naiaramartinezStatusnew => scheduled
2012-08-22 11:00naiaramartinezfix_in_branch => pi
2012-08-28 10:48naiaramartinezNote Added: 0051582
2012-08-28 10:50hgbotCheckin
2012-08-28 10:50hgbotNote Added: 0051583
2012-08-28 10:50hgbotStatusscheduled => resolved
2012-08-28 10:50hgbotResolutionopen => fixed
2012-08-28 10:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d3245331b58a6b9590ef808482778d744ff53114 [^]
2012-08-28 10:51dmiguelezNote Added: 0051584
2012-08-28 10:52dmiguelezClosed by => dmiguelez
2012-08-28 10:52dmiguelezStatusresolved => closed

Notes
(0051582)
naiaramartinez   
2012-08-28 10:48   
Thanks for the contribution. We have done the code review and it looks great.

We will include this patch in mp15.
(0051583)
hgbot   
2012-08-28 10:50   
Repository: erp/devel/pi
Changeset: d3245331b58a6b9590ef808482778d744ff53114
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Mon Aug 06 10:13:25 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d3245331b58a6b9590ef808482778d744ff53114 [^]

fixed bug 21267:Not insert in m_storage_pending for stocked=N product
Contribution from eintelau

---
M src-db/database/model/triggers/C_ORDERLINE2_TRG.xml
---
(0051584)
dmiguelez   
2012-08-28 10:51   
Code Review + Testing OK