Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019108 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | critical | have not tried | 2011-11-18 11:07 | 2011-11-22 03:50 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | 2.50 | Fixed in SCM revision | 030efbbc0df1 | |||
| Projection | none | ETA | none | Target Version | 3.0MP5.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019108: License expiration validation is not properly checked | |||||||
| Description | License expiration validation is not properly checked. When license expires, it is not checked till tomcat is restarted or license is refreshed. Technically the problem is due license manager is a singleton class and these checks are performed on initialization. | |||||||
| Steps To Reproduce | -Activate your instance with a license -Wait till expiration date without restarting tomcat nor refreshing the license -After expiration date, check the instance is still active till next refresh | |||||||
| Proposed Solution | Keep license manager as singleton, but do date checking on getInstance | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0042972) hgbot (developer) 2011-11-18 11:15 |
Repository: erp/devel/pi Changeset: a538c52f8e465825b387821fbfd274e70279e47f Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Nov 18 11:14:08 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/a538c52f8e465825b387821fbfd274e70279e47f [^] fixed bug 19108: License expiration validation is not properly checked --- M src/org/openbravo/erpCommon/obps/ActivationKey.java --- |
|
(0042973) alostale (viewer) 2011-11-18 11:20 |
Incorrect patch |
|
(0042990) hgbot (developer) 2011-11-18 14:58 |
Repository: erp/stable/2.50 Changeset: 030efbbc0df18fec0d03e51d5bf7a35503a925ed Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Sun Dec 18 14:57:27 2011 +0100 URL: http://code.openbravo.com/erp/stable/2.50/rev/030efbbc0df18fec0d03e51d5bf7a35503a925ed [^] fixed bug 19108: License expiration validation is not properly checked --- M src/org/openbravo/erpCommon/obps/ActivationKey.java --- |
|
(0042991) marvintm (viewer) 2011-11-18 15:41 |
Reviewed the diff and tested that non-activated instances work, activated instances with a valid license also work, and that when the license expires, the error is shown when the user tries to log in, and he is logged in system admin role. |
|
(0043053) hudsonbot (viewer) 2011-11-22 03:50 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ebd713dfe507 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-11-18 11:14 | alostale | Type | defect => backport |
| 2011-11-18 11:14 | alostale | fix_in_branch | => 2.50 |
| 2011-11-18 11:15 | hgbot | Checkin | |
| 2011-11-18 11:15 | hgbot | Note Added: 0042972 | |
| 2011-11-18 11:15 | hgbot | Status | scheduled => resolved |
| 2011-11-18 11:15 | hgbot | Resolution | open => fixed |
| 2011-11-18 11:15 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/a538c52f8e465825b387821fbfd274e70279e47f [^] |
| 2011-11-18 11:20 | alostale | Note Added: 0042973 | |
| 2011-11-18 11:20 | alostale | Status | resolved => new |
| 2011-11-18 11:20 | alostale | Resolution | fixed => open |
| 2011-11-18 14:58 | hgbot | Checkin | |
| 2011-11-18 14:58 | hgbot | Note Added: 0042990 | |
| 2011-11-18 14:58 | hgbot | Status | new => resolved |
| 2011-11-18 14:58 | hgbot | Resolution | open => fixed |
| 2011-11-18 14:58 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/a538c52f8e465825b387821fbfd274e70279e47f [^] => http://code.openbravo.com/erp/stable/2.50/rev/030efbbc0df18fec0d03e51d5bf7a35503a925ed [^] |
| 2011-11-18 15:41 | marvintm | Note Added: 0042991 | |
| 2011-11-18 15:41 | marvintm | Status | resolved => closed |
| 2011-11-22 03:50 | hudsonbot | Checkin | |
| 2011-11-22 03:50 | hudsonbot | Note Added: 0043053 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |