Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019107 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | critical | have not tried | 2011-11-18 11:07 | 2011-11-22 03:50 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | a538c52f8e46 | |||
| Projection | none | ETA | none | Target Version | 3.0MP5.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019107: License expiration validation is not properly checked | |||||||
| Description | License expiration validation is not properly checked. When license expires, it is not checked till tomcat is restarted or license is refreshed. Technically the problem is due license manager is a singleton class and these checks are performed on initialization. | |||||||
| Steps To Reproduce | -Activate your instance with a license -Wait till expiration date without restarting tomcat nor refreshing the license -After expiration date, check the instance is still active till next refresh | |||||||
| Proposed Solution | Keep license manager as singleton, but do date checking on getInstance | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  userShouldLoginAndLogout.png [^] (71,083 bytes) 2011-11-18 13:09
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0042975) hgbot (developer) 2011-11-18 11:57 |
Repository: erp/devel/pi Changeset: 09ac1059cc80bcabf5ee7185b8e7f4382b0f1204 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Nov 18 11:55:33 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/09ac1059cc80bcabf5ee7185b8e7f4382b0f1204 [^] related to bug 19107: dates are now class fields, don't read them again --- M src/org/openbravo/erpCommon/obps/ActivationKey.java --- |
|
(0042976) hgbot (developer) 2011-11-18 12:03 |
Repository: erp/devel/pi Changeset: 1494f99f239e7d0aa03196fe332d290c4484d95b Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Nov 18 12:02:03 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/1494f99f239e7d0aa03196fe332d290c4484d95b [^] related to bug 19107: removed uneeded variable --- M src/org/openbravo/erpCommon/obps/ActivationKey.java --- |
|
(0042979) marvintm (developer) 2011-11-18 12:24 |
I've reviewed the diff (suggested an small change which has been done), and tested that the system notices that the current date is greater than the expiration date of the current license, without the need to restart tomcat or refresh the license. |
|
(0042984) hgbot (developer) 2011-11-18 13:08 |
Repository: erp/devel/pi Changeset: 2b9485ac8bddb429fd2cac9b40e04af94f547d90 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Nov 18 13:06:54 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/2b9485ac8bddb429fd2cac9b40e04af94f547d90 [^] related to bug 19107: fixed NPE --- M src/org/openbravo/erpCommon/obps/ActivationKey.java --- |
|
(0042985) plujan (manager) 2011-11-18 13:09 |
When accessing a non activated instance you get a 500 error before login. Check attached image. |
|
(0042986) marvintm (developer) 2011-11-18 13:32 |
Tested that the change works on non-activated instances, that the activation process still works, that when the license is still valid, login works as usual, and that when the date is expired, login raises an error as designed. |
|
(0042998) shuehner (administrator) 2011-11-18 20:05 |
Quick recheck in MP5.1 appliance. Activate an instance with a license having expiration date i.e. of 19th November 2011, plus then deactivate ntp daemon + change system date of the appliance to 20th of November. After that trying to login again leads to error message mentioning expired license and redirects to system administrator role (fine). |
|
(0043054) hudsonbot (developer) 2011-11-22 03:50 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ebd713dfe507 [^] Maturity status: Test |
|
(0043055) hudsonbot (developer) 2011-11-22 03:50 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ebd713dfe507 [^] Maturity status: Test |
|
(0043056) hudsonbot (developer) 2011-11-22 03:50 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ebd713dfe507 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-11-18 11:07 | alostale | New Issue | |
| 2011-11-18 11:07 | alostale | Assigned To | => alostale |
| 2011-11-18 11:07 | alostale | Modules | => Core |
| 2011-11-18 11:14 | alostale | Status | new => scheduled |
| 2011-11-18 11:14 | alostale | fix_in_branch | => pi |
| 2011-11-18 11:20 | alostale | Status | scheduled => resolved |
| 2011-11-18 11:20 | alostale | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/a538c52f8e465825b387821fbfd274e70279e47f [^] |
| 2011-11-18 11:20 | alostale | Resolution | open => fixed |
| 2011-11-18 11:57 | hgbot | Checkin | |
| 2011-11-18 11:57 | hgbot | Note Added: 0042975 | |
| 2011-11-18 12:03 | hgbot | Checkin | |
| 2011-11-18 12:03 | hgbot | Note Added: 0042976 | |
| 2011-11-18 12:24 | marvintm | Note Added: 0042979 | |
| 2011-11-18 12:24 | marvintm | Status | resolved => closed |
| 2011-11-18 13:08 | hgbot | Checkin | |
| 2011-11-18 13:08 | hgbot | Note Added: 0042984 | |
| 2011-11-18 13:09 | plujan | Note Added: 0042985 | |
| 2011-11-18 13:09 | plujan | Status | closed => new |
| 2011-11-18 13:09 | plujan | Resolution | fixed => open |
| 2011-11-18 13:09 | plujan | File Added: userShouldLoginAndLogout.png | |
| 2011-11-18 13:11 | alostale | Status | new => scheduled |
| 2011-11-18 13:11 | alostale | Status | scheduled => resolved |
| 2011-11-18 13:11 | alostale | Resolution | open => fixed |
| 2011-11-18 13:32 | marvintm | Note Added: 0042986 | |
| 2011-11-18 13:32 | marvintm | Status | resolved => closed |
| 2011-11-18 20:05 | shuehner | Note Added: 0042998 | |
| 2011-11-22 03:50 | hudsonbot | Checkin | |
| 2011-11-22 03:50 | hudsonbot | Note Added: 0043054 | |
| 2011-11-22 03:50 | hudsonbot | Checkin | |
| 2011-11-22 03:50 | hudsonbot | Note Added: 0043055 | |
| 2011-11-22 03:50 | hudsonbot | Checkin | |
| 2011-11-22 03:50 | hudsonbot | Note Added: 0043056 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |