Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0019107 | Openbravo ERP | A. Platform | public | 2011-11-18 11:07 | 2011-11-22 03:50 |
|
| Reporter | alostale | |
| Assigned To | alostale | |
| Priority | immediate | Severity | critical | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0MP5.1 | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0019107: License expiration validation is not properly checked |
| Description | License expiration validation is not properly checked.
When license expires, it is not checked till tomcat is restarted or license is refreshed.
Technically the problem is due license manager is a singleton class and these checks are performed on initialization. |
| Steps To Reproduce | -Activate your instance with a license
-Wait till expiration date without restarting tomcat nor refreshing the license
-After expiration date, check the instance is still active till next refresh |
| Proposed Solution | Keep license manager as singleton, but do date checking on getInstance |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | depends on | backport | 0019108 | 3.0MP5.1 | closed | alostale | License expiration validation is not properly checked |
|
| Attached Files |  userShouldLoginAndLogout.png (71,083) 2011-11-18 13:09
https://issues.openbravo.com/file_download.php?file_id=4759&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2011-11-18 11:07 | alostale | New Issue | |
| 2011-11-18 11:07 | alostale | Assigned To | => alostale |
| 2011-11-18 11:07 | alostale | Modules | => Core |
| 2011-11-18 11:14 | alostale | Status | new => scheduled |
| 2011-11-18 11:14 | alostale | fix_in_branch | => pi |
| 2011-11-18 11:20 | alostale | Status | scheduled => resolved |
| 2011-11-18 11:20 | alostale | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/a538c52f8e465825b387821fbfd274e70279e47f [^] |
| 2011-11-18 11:20 | alostale | Resolution | open => fixed |
| 2011-11-18 11:57 | hgbot | Checkin | |
| 2011-11-18 11:57 | hgbot | Note Added: 0042975 | |
| 2011-11-18 12:03 | hgbot | Checkin | |
| 2011-11-18 12:03 | hgbot | Note Added: 0042976 | |
| 2011-11-18 12:24 | marvintm | Note Added: 0042979 | |
| 2011-11-18 12:24 | marvintm | Status | resolved => closed |
| 2011-11-18 13:08 | hgbot | Checkin | |
| 2011-11-18 13:08 | hgbot | Note Added: 0042984 | |
| 2011-11-18 13:09 | plujan | Note Added: 0042985 | |
| 2011-11-18 13:09 | plujan | Status | closed => new |
| 2011-11-18 13:09 | plujan | Resolution | fixed => open |
| 2011-11-18 13:09 | plujan | File Added: userShouldLoginAndLogout.png | |
| 2011-11-18 13:11 | alostale | Status | new => scheduled |
| 2011-11-18 13:11 | alostale | Status | scheduled => resolved |
| 2011-11-18 13:11 | alostale | Resolution | open => fixed |
| 2011-11-18 13:32 | marvintm | Note Added: 0042986 | |
| 2011-11-18 13:32 | marvintm | Status | resolved => closed |
| 2011-11-18 20:05 | shuehner | Note Added: 0042998 | |
| 2011-11-22 03:50 | hudsonbot | Checkin | |
| 2011-11-22 03:50 | hudsonbot | Note Added: 0043054 | |
| 2011-11-22 03:50 | hudsonbot | Checkin | |
| 2011-11-22 03:50 | hudsonbot | Note Added: 0043055 | |
| 2011-11-22 03:50 | hudsonbot | Checkin | |
| 2011-11-22 03:50 | hudsonbot | Note Added: 0043056 | |
|
Notes |
|
|
(0042975)
|
|
hgbot
|
|
2011-11-18 11:57
|
|
|
|
|
(0042976)
|
|
hgbot
|
|
2011-11-18 12:03
|
|
|
|
|
|
|
I've reviewed the diff (suggested an small change which has been done), and tested that the system notices that the current date is greater than the expiration date of the current license, without the need to restart tomcat or refresh the license. |
|
|
|
(0042984)
|
|
hgbot
|
|
2011-11-18 13:08
|
|
|
|
|
(0042985)
|
|
plujan
|
|
2011-11-18 13:09
|
|
When accessing a non activated instance you get a 500 error before login.
Check attached image. |
|
|
|
|
|
Tested that the change works on non-activated instances, that the activation process still works, that when the license is still valid, login works as usual, and that when the date is expired, login raises an error as designed. |
|
|
|
|
|
Quick recheck in MP5.1 appliance. Activate an instance with a license having expiration date i.e. of 19th November 2011, plus then deactivate ntp daemon + change system date of the appliance to 20th of November. After that trying to login again leads to error message mentioning expired license and redirects to system administrator role (fine). |
|
|
|
|
|
|
|
|
|
|
|
|
|