Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019108Openbravo ERPA. Platformpublic2011-11-18 11:072011-11-22 03:50
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP5.1Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019108: License expiration validation is not properly checked
DescriptionLicense expiration validation is not properly checked.

When license expires, it is not checked till tomcat is restarted or license is refreshed.

Technically the problem is due license manager is a singleton class and these checks are performed on initialization.
Steps To Reproduce-Activate your instance with a license
-Wait till expiration date without restarting tomcat nor refreshing the license
-After expiration date, check the instance is still active till next refresh
Proposed SolutionKeep license manager as singleton, but do date checking on getInstance
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00191073.0MP5.1 closed alostale License expiration validation is not properly checked 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-11-18 11:14alostaleTypedefect => backport
2011-11-18 11:14alostalefix_in_branch => 2.50
2011-11-18 11:15hgbotCheckin
2011-11-18 11:15hgbotNote Added: 0042972
2011-11-18 11:15hgbotStatusscheduled => resolved
2011-11-18 11:15hgbotResolutionopen => fixed
2011-11-18 11:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a538c52f8e465825b387821fbfd274e70279e47f [^]
2011-11-18 11:20alostaleNote Added: 0042973
2011-11-18 11:20alostaleStatusresolved => new
2011-11-18 11:20alostaleResolutionfixed => open
2011-11-18 14:58hgbotCheckin
2011-11-18 14:58hgbotNote Added: 0042990
2011-11-18 14:58hgbotStatusnew => resolved
2011-11-18 14:58hgbotResolutionopen => fixed
2011-11-18 14:58hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/a538c52f8e465825b387821fbfd274e70279e47f [^] => http://code.openbravo.com/erp/stable/2.50/rev/030efbbc0df18fec0d03e51d5bf7a35503a925ed [^]
2011-11-18 15:41marvintmNote Added: 0042991
2011-11-18 15:41marvintmStatusresolved => closed
2011-11-22 03:50hudsonbotCheckin
2011-11-22 03:50hudsonbotNote Added: 0043053

Notes
(0042972)
hgbot   
2011-11-18 11:15   
Repository: erp/devel/pi
Changeset: a538c52f8e465825b387821fbfd274e70279e47f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Nov 18 11:14:08 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a538c52f8e465825b387821fbfd274e70279e47f [^]

fixed bug 19108: License expiration validation is not properly checked

---
M src/org/openbravo/erpCommon/obps/ActivationKey.java
---
(0042973)
alostale   
2011-11-18 11:20   
Incorrect patch
(0042990)
hgbot   
2011-11-18 14:58   
Repository: erp/stable/2.50
Changeset: 030efbbc0df18fec0d03e51d5bf7a35503a925ed
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Sun Dec 18 14:57:27 2011 +0100
URL: http://code.openbravo.com/erp/stable/2.50/rev/030efbbc0df18fec0d03e51d5bf7a35503a925ed [^]

fixed bug 19108: License expiration validation is not properly checked

---
M src/org/openbravo/erpCommon/obps/ActivationKey.java
---
(0042991)
marvintm   
2011-11-18 15:41   
Reviewed the diff and tested that non-activated instances work, activated instances with a valid license also work, and that when the license expires, the error is shown when the user tries to log in, and he is logged in system admin role.
(0043053)
hudsonbot   
2011-11-22 03:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ebd713dfe507 [^]

Maturity status: Test