Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0018082 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2011-07-26 13:28 | 2011-08-03 15:38 | |||
| Reporter | marvintm | View Status | public | |||||
| Assigned To | marvintm | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 3f2583bb1884 | |||
| Projection | none | ETA | none | Target Version | 3.0MP3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0018082: Performance improvements in image showing | |||||||
| Description | Two proposed performance improvements: - Save the MIME type of the image when creating it. This would allow us to read the MIME type from the database instead of calculating it in ShowImage and ShowImageLogo using the MimeTypeUtil (and this would save time). - Save the size of the image in the database when creating it. This would allow us to read it from the database instead of calculating it in the ImagesActionHandler class. | |||||||
| Steps To Reproduce | . | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0039410) hgbot (developer) 2011-07-26 18:13 |
Repository: erp/devel/pi Changeset: 3f2583bb18845f0ab679aa2c88ca0ce2294ef426 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue Jul 26 18:10:49 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/3f2583bb18845f0ab679aa2c88ca0ce2294ef426 [^] [imageBLOB] Fixed issue 18082. Image size and mime type will be saved and reused to increase performance. --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ImagesActionHandler.java M src-db/database/model/tables/AD_IMAGE.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src/org/openbravo/erpCommon/info/ImageInfoBLOB.java M src/org/openbravo/erpCommon/utility/ImageToDatabaseLoader.java M src/org/openbravo/erpCommon/utility/ShowImage.java M src/org/openbravo/erpCommon/utility/ShowImageLogo.java M src/org/openbravo/erpCommon/utility/Utility.java --- |
|
(0039411) marvintm (developer) 2011-07-26 18:14 |
Fixed by changeset: https://code.openbravo.com/erp/devel/pi/rev/3f2583bb1884 [^] |
|
(0039423) hgbot (developer) 2011-07-27 10:27 |
Repository: erp/devel/pi Changeset: 2dc1e3222b4cdc1958709dfa380b05b100752850 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Wed Jul 27 10:27:12 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/2dc1e3222b4cdc1958709dfa380b05b100752850 [^] Related to issue 18082. Do not save MIME type in case there is no OBContext yet (such as in the Login window) --- M src/org/openbravo/erpCommon/utility/ShowImage.java M src/org/openbravo/erpCommon/utility/ShowImageLogo.java --- |
|
(0039432) hgbot (developer) 2011-07-27 11:24 |
Repository: erp/devel/pi Changeset: efa403a3f67513efaa5cf95e04fb4eaa4bb6c68f Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Wed Jul 27 11:24:11 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/efa403a3f67513efaa5cf95e04fb4eaa4bb6c68f [^] Related to issue 18082. Improved saving of MIME type in ShowImageLogo --- M src/org/openbravo/erpCommon/utility/ShowImageLogo.java --- |
|
(0039695) hudsonbot (developer) 2011-08-01 14:21 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^] Maturity status: Test |
|
(0039700) hudsonbot (developer) 2011-08-01 14:21 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^] Maturity status: Test |
|
(0039703) hudsonbot (developer) 2011-08-01 14:21 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^] Maturity status: Test |
|
(0039829) shuehner (administrator) 2011-08-03 15:38 |
Reviewed/tested on pi/psql/chromium. (rev id: 15596297db75). create.database now insert the images with mimetype directly in the aD_image record. When updating/uploading images mimetype+size will be also directly computed & saved. ShowImage & ShowImageLogo use the saved mime-type if available and don't recompute it. If mime-type is missing it is computed in those servlets and saved for later use. Having mime-type available when displaying the login page removes 1-2s cpu-time as init of the tika library can be skipped then. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-07-26 13:28 | marvintm | New Issue | |
| 2011-07-26 13:28 | marvintm | Assigned To | => marvintm |
| 2011-07-26 13:28 | marvintm | Modules | => Core |
| 2011-07-26 18:13 | marvintm | Status | new => scheduled |
| 2011-07-26 18:13 | marvintm | fix_in_branch | => pi |
| 2011-07-26 18:13 | marvintm | Status | scheduled => resolved |
| 2011-07-26 18:13 | marvintm | Fixed in SCM revision | => 3f2583bb1884 |
| 2011-07-26 18:13 | marvintm | Resolution | open => fixed |
| 2011-07-26 18:13 | hgbot | Checkin | |
| 2011-07-26 18:13 | hgbot | Note Added: 0039410 | |
| 2011-07-26 18:14 | hgbot | Fixed in SCM revision | 3f2583bb1884 => http://code.openbravo.com/erp/devel/pi/rev/3f2583bb18845f0ab679aa2c88ca0ce2294ef426 [^] |
| 2011-07-26 18:14 | marvintm | Note Added: 0039411 | |
| 2011-07-27 10:27 | hgbot | Checkin | |
| 2011-07-27 10:27 | hgbot | Note Added: 0039423 | |
| 2011-07-27 11:24 | hgbot | Checkin | |
| 2011-07-27 11:24 | hgbot | Note Added: 0039432 | |
| 2011-08-01 14:21 | hudsonbot | Checkin | |
| 2011-08-01 14:21 | hudsonbot | Note Added: 0039695 | |
| 2011-08-01 14:21 | hudsonbot | Checkin | |
| 2011-08-01 14:21 | hudsonbot | Note Added: 0039700 | |
| 2011-08-01 14:21 | hudsonbot | Checkin | |
| 2011-08-01 14:21 | hudsonbot | Note Added: 0039703 | |
| 2011-08-03 15:38 | shuehner | Note Added: 0039829 | |
| 2011-08-03 15:38 | shuehner | Status | resolved => closed |
| 2011-11-10 16:05 | dmitry_mezentsev | Relationship added | related to 0019026 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |