Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018082Openbravo ERPA. Platformpublic2011-07-26 13:282011-08-03 15:38
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP3Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018082: Performance improvements in image showing
DescriptionTwo proposed performance improvements:
- Save the MIME type of the image when creating it. This would allow us to read the MIME type from the database instead of calculating it in ShowImage and ShowImageLogo using the MimeTypeUtil (and this would save time).

- Save the size of the image in the database when creating it. This would allow us to read it from the database instead of calculating it in the ImagesActionHandler class.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00190263.0MP5 closed marvintm Logo does not appear in jasper reports when you use a role different from Admin 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-07-26 13:28marvintmNew Issue
2011-07-26 13:28marvintmAssigned To => marvintm
2011-07-26 13:28marvintmModules => Core
2011-07-26 18:13marvintmStatusnew => scheduled
2011-07-26 18:13marvintmfix_in_branch => pi
2011-07-26 18:13marvintmStatusscheduled => resolved
2011-07-26 18:13marvintmFixed in SCM revision => 3f2583bb1884
2011-07-26 18:13marvintmResolutionopen => fixed
2011-07-26 18:13hgbotCheckin
2011-07-26 18:13hgbotNote Added: 0039410
2011-07-26 18:14hgbotFixed in SCM revision3f2583bb1884 => http://code.openbravo.com/erp/devel/pi/rev/3f2583bb18845f0ab679aa2c88ca0ce2294ef426 [^]
2011-07-26 18:14marvintmNote Added: 0039411
2011-07-27 10:27hgbotCheckin
2011-07-27 10:27hgbotNote Added: 0039423
2011-07-27 11:24hgbotCheckin
2011-07-27 11:24hgbotNote Added: 0039432
2011-08-01 14:21hudsonbotCheckin
2011-08-01 14:21hudsonbotNote Added: 0039695
2011-08-01 14:21hudsonbotCheckin
2011-08-01 14:21hudsonbotNote Added: 0039700
2011-08-01 14:21hudsonbotCheckin
2011-08-01 14:21hudsonbotNote Added: 0039703
2011-08-03 15:38shuehnerNote Added: 0039829
2011-08-03 15:38shuehnerStatusresolved => closed
2011-11-10 16:05dmitry_mezentsevRelationship addedrelated to 0019026

Notes
(0039410)
hgbot   
2011-07-26 18:13   
Repository: erp/devel/pi
Changeset: 3f2583bb18845f0ab679aa2c88ca0ce2294ef426
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jul 26 18:10:49 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3f2583bb18845f0ab679aa2c88ca0ce2294ef426 [^]

[imageBLOB] Fixed issue 18082. Image size and mime type will be saved and reused to increase performance.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ImagesActionHandler.java
M src-db/database/model/tables/AD_IMAGE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src/org/openbravo/erpCommon/info/ImageInfoBLOB.java
M src/org/openbravo/erpCommon/utility/ImageToDatabaseLoader.java
M src/org/openbravo/erpCommon/utility/ShowImage.java
M src/org/openbravo/erpCommon/utility/ShowImageLogo.java
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0039411)
marvintm   
2011-07-26 18:14   
Fixed by changeset:

https://code.openbravo.com/erp/devel/pi/rev/3f2583bb1884 [^]
(0039423)
hgbot   
2011-07-27 10:27   
Repository: erp/devel/pi
Changeset: 2dc1e3222b4cdc1958709dfa380b05b100752850
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jul 27 10:27:12 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2dc1e3222b4cdc1958709dfa380b05b100752850 [^]

Related to issue 18082. Do not save MIME type in case there is no OBContext yet (such as in the Login window)

---
M src/org/openbravo/erpCommon/utility/ShowImage.java
M src/org/openbravo/erpCommon/utility/ShowImageLogo.java
---
(0039432)
hgbot   
2011-07-27 11:24   
Repository: erp/devel/pi
Changeset: efa403a3f67513efaa5cf95e04fb4eaa4bb6c68f
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jul 27 11:24:11 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/efa403a3f67513efaa5cf95e04fb4eaa4bb6c68f [^]

Related to issue 18082. Improved saving of MIME type in ShowImageLogo

---
M src/org/openbravo/erpCommon/utility/ShowImageLogo.java
---
(0039695)
hudsonbot   
2011-08-01 14:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^]

Maturity status: Test
(0039700)
hudsonbot   
2011-08-01 14:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^]

Maturity status: Test
(0039703)
hudsonbot   
2011-08-01 14:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^]

Maturity status: Test
(0039829)
shuehner   
2011-08-03 15:38   
Reviewed/tested on pi/psql/chromium. (rev id: 15596297db75). create.database now insert the images with mimetype directly in the aD_image record. When updating/uploading images mimetype+size will be also directly computed & saved.
ShowImage & ShowImageLogo use the saved mime-type if available and don't recompute it. If mime-type is missing it is computed in those servlets and saved for later use. Having mime-type available when displaying the login page removes 1-2s cpu-time as init of the tika library can be skipped then.