Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0014207 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] A. Platform | minor | have not tried | 2010-08-16 20:23 | 2010-08-18 00:00 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 34f2283ba833 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0014207: Remove HttpSecureAppServlet dependency from Utility class | |||||||
| Description | Only a single unneeded method in the org.openbravo.erpCommon.utility.Utility class uses the HttpSecureAppServlet clas in its parameter list. Removing this method simplifies the compile-time dependencies between the classes and (with other needed changes) helps to reduce the amount of compilation needed in the 'ant compile.apply.module' task. The method to be removed is: public static String getTabURL(HttpSecureAppServlet servlet, String tabId, String type) A similar method which will not be changed is also present in the file: public static String getTabURL(ConnectionProvider conn, String tabId, String type) As HttpSecureAppServlet does implement ConnectionProvider (via the extends HttpBaseServlet) all users who before called the to be removed method will pick up the second method on the next recompile automatically so not existing code will be broken. -> API change, but false positive | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0030034) hgbot (developer) 2010-08-16 21:24 |
Repository: erp/devel/pi Changeset: 34f2283ba8335ad6c5d38b07c144012fbbae6390 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Mon Aug 16 20:26:01 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/34f2283ba8335ad6c5d38b07c144012fbbae6390 [^] Fixed 14207: Remove HttpSecureAppServlet dependency from Utility class Remove the only user of the HttpSecureAppServlet type from the Utility class to untangle compile-time dependencies. --- M src/org/openbravo/erpCommon/utility/Utility.java --- |
|
(0030052) marvintm (developer) 2010-08-17 12:45 |
Verified that a call to getTabURL(HttpSecureAppServlet servlet, String tabId, String type) would essentially be equivalent (taking into account the getTabURL(HttpSecureAppServlet servlet, String tabId, String type) method implementation) to a call to getTabURL(ConnectionProvider conn, String tabId, String type), and as HttpSecureAppServlet implements the ConnectionProvider interface, this behaviour indeed happens automatically even if the first method is removed. |
|
(0030060) hudsonbot (developer) 2010-08-17 13:02 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/34f2283ba833 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4443754d9476 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18173.obx [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-08-16 20:23 | shuehner | New Issue | |
| 2010-08-16 20:23 | shuehner | Assigned To | => shuehner |
| 2010-08-16 20:34 | shuehner | Relationship added | related to 0014208 |
| 2010-08-16 21:09 | shuehner | Relationship added | related to 0014209 |
| 2010-08-16 21:24 | hgbot | Checkin | |
| 2010-08-16 21:24 | hgbot | Note Added: 0030034 | |
| 2010-08-16 21:24 | hgbot | Status | new => resolved |
| 2010-08-16 21:24 | hgbot | Resolution | open => fixed |
| 2010-08-16 21:24 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/34f2283ba8335ad6c5d38b07c144012fbbae6390 [^] |
| 2010-08-17 12:45 | marvintm | Note Added: 0030052 | |
| 2010-08-17 12:45 | marvintm | Status | resolved => closed |
| 2010-08-17 13:02 | hudsonbot | Checkin | |
| 2010-08-17 13:02 | hudsonbot | Note Added: 0030060 | |
| 2010-08-18 00:00 | anonymous | sf_bug_id | 0 => 3047310 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |