Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014207Openbravo ERPA. Platformpublic2010-08-16 20:232010-08-18 00:00
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014207: Remove HttpSecureAppServlet dependency from Utility class
DescriptionOnly a single unneeded method in the org.openbravo.erpCommon.utility.Utility class uses the HttpSecureAppServlet clas in its parameter list.

Removing this method simplifies the compile-time dependencies between the classes and (with other needed changes) helps to reduce the amount of compilation needed in the 'ant compile.apply.module' task.

The method to be removed is:
public static String getTabURL(HttpSecureAppServlet servlet, String tabId, String type)

A similar method which will not be changed is also present in the file:
public static String getTabURL(ConnectionProvider conn, String tabId, String type)

As HttpSecureAppServlet does implement ConnectionProvider (via the extends HttpBaseServlet) all users who before called the to be removed method will pick up the second method on the next recompile automatically so not existing code will be broken. -> API change, but false positive
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0014208 closed shuehner Translation import & export code should be separated from the servlet for starting those actions 
related to defect 0014209 closed shuehner try api-check 120 fails 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-08-16 20:23shuehnerNew Issue
2010-08-16 20:23shuehnerAssigned To => shuehner
2010-08-16 20:23shuehnerOBNetwork customer => No
2010-08-16 20:34shuehnerRelationship addedrelated to 0014208
2010-08-16 21:09shuehnerRelationship addedrelated to 0014209
2010-08-16 21:24hgbotCheckin
2010-08-16 21:24hgbotNote Added: 0030034
2010-08-16 21:24hgbotStatusnew => resolved
2010-08-16 21:24hgbotResolutionopen => fixed
2010-08-16 21:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/34f2283ba8335ad6c5d38b07c144012fbbae6390 [^]
2010-08-17 12:45marvintmNote Added: 0030052
2010-08-17 12:45marvintmStatusresolved => closed
2010-08-17 13:02hudsonbotCheckin
2010-08-17 13:02hudsonbotNote Added: 0030060
2010-08-18 00:00anonymoussf_bug_id0 => 3047310

Notes
(0030034)
hgbot   
2010-08-16 21:24   
Repository: erp/devel/pi
Changeset: 34f2283ba8335ad6c5d38b07c144012fbbae6390
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Aug 16 20:26:01 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/34f2283ba8335ad6c5d38b07c144012fbbae6390 [^]

Fixed 14207: Remove HttpSecureAppServlet dependency from Utility class
Remove the only user of the HttpSecureAppServlet type from the Utility class
to untangle compile-time dependencies.

---
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0030052)
marvintm   
2010-08-17 12:45   
Verified that a call to getTabURL(HttpSecureAppServlet servlet, String tabId, String type) would essentially be equivalent (taking into account the getTabURL(HttpSecureAppServlet servlet, String tabId, String type) method implementation) to a call to getTabURL(ConnectionProvider conn, String tabId, String type), and as HttpSecureAppServlet implements the ConnectionProvider interface, this behaviour indeed happens automatically even if the first method is removed.
(0030060)
hudsonbot   
2010-08-17 13:02   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/34f2283ba833 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4443754d9476 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18173.obx [^]