Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2010-08-16 20:342010-08-18 11:11
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisione87917805d68
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo

0014208: Translation import & export code should be separated from the servlet for starting those actions

DescriptionCurrently the import & export translation code is contained directly in the org.openbravo.erpCommon.ad_forms.Translation servlet which displays the UI for these actions.
This should be refactored to have the UI separate from the code doing the import & export as its better practice and decreases the amount of needed compilation for the 'ant compile.apply.module' task which makes this fast slightly faster and more important more stable against code-changes in other parts of the system.
Proposed SolutionCreate a new TranslationManager class and move all import & export related functions from the Translation class to this new file. Then from the Translation servlet and just call the new class instead of methods integrated in the servlet.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0014207 closedshuehner Remove HttpSecureAppServlet dependency from Utility class 

-  Notes
hgbot (developer)
2010-08-17 17:05

Repository: erp/devel/pi
Changeset: fbd378943dad6cb2352e920367f9db762603ede2
Author: Stefan Hühner <stefan.huehner <at>>
Date: Tue Aug 17 16:17:22 2010 +0200
URL: [^]

Fixed 14208: Extract import/export translation out of servlet into a new file
- separate servlet from logic to do the import & export of
  translation from/to xml files which is now in a new class TranslationManager
- Update References in TranslationHandler to use new classname
- Keep public api of the Translation class intact by forwarding calls to new
  class (but see behavior change below)
- Changes done to new TranslationManager: use constant logger, explicit passing
  of a ConnectionProvider instance in the methods instead of relying on a
  setter for this on class level
- Call this new class from the servlet & the apply.module ant task (which does
  import translation for installed translation modules)
- Behavior change: Don't use caller provider log4j instance anymore (ignored
  now) but instead a constant logger in the class itself as rest of the code
- These changes together reduce the set of classes needed to be compiled in the
  compile.apply.module task and further allows trimming the manually maintained
  list of xsql-files for this task

M src/build.xml
M src/org/openbravo/erpCommon/ad_forms/
M src/org/openbravo/erpCommon/ad_forms/
M src/org/openbravo/erpCommon/modules/
A src/org/openbravo/erpCommon/ad_forms/
hgbot (developer)
2010-08-17 17:57

Repository: erp/devel/pi
Changeset: e87917805d6890f01c2dca07b3f5fed562bc3828
Author: Stefan Hühner <stefan.huehner <at>>
Date: Tue Aug 17 17:56:23 2010 +0200
URL: [^]

Fixed 14208: Mark two old methods as deprected
- Mark setLog4j and setConnectionProvicer as deprecated in the Translation class
- don't call/use those methods anymore from the servlet

M src/org/openbravo/erpCommon/ad_forms/
marvintm (developer)
2010-08-17 18:19

Code-reviewed the diff (looks fine) and verified that Applymodules (language import), and Translation Export and Import work correctly.
hudsonbot (developer)
2010-08-18 11:11

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: [^]
Merge Changeset: [^]
Tests: [^]
OBX: [^]
hudsonbot (developer)
2010-08-18 11:11

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: [^]
Merge Changeset: [^]
Tests: [^]
OBX: [^]

- Issue History
Date Modified Username Field Change
2010-08-16 20:34 shuehner New Issue
2010-08-16 20:34 shuehner Assigned To => shuehner
2010-08-16 20:34 shuehner Relationship added related to 0014207
2010-08-17 17:05 hgbot Checkin
2010-08-17 17:05 hgbot Note Added: 0030078
2010-08-17 17:05 hgbot Status new => resolved
2010-08-17 17:05 hgbot Resolution open => fixed
2010-08-17 17:05 hgbot Fixed in SCM revision => [^]
2010-08-17 17:57 hgbot Checkin
2010-08-17 17:57 hgbot Note Added: 0030082
2010-08-17 17:57 hgbot Fixed in SCM revision [^] => [^]
2010-08-17 18:19 marvintm Note Added: 0030085
2010-08-17 18:19 marvintm Status resolved => closed
2010-08-18 00:00 anonymous sf_bug_id 0 => 3047311
2010-08-18 11:11 hudsonbot Checkin
2010-08-18 11:11 hudsonbot Note Added: 0030108
2010-08-18 11:11 hudsonbot Checkin
2010-08-18 11:11 hudsonbot Note Added: 0030109

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker