Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0011715
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2009-12-09 19:382010-04-19 21:10
ReportershuehnerView Statuspublic 
Assigned Toiperdomo 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision67a0d70d7c6d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0011715: DeepLinking: contains both windowId & tabId in link where only tabId is really needed

Descriptionas the code reads windowId based on tabId and already reject non-matching pairs.
Proposed SolutionRemove usage of windowId and use the windowId for the specified tabId instead.

Old links will still work (windowId is just ignored)
New links will be simpler as one parameter less is required.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00128862.50MP17 closediperdomo Deep Linking log NPE and show empty error page on invalid tabId 

-  Notes
(0025638)
hgbot (developer)
2010-03-22 10:23

Repository: erp/devel/pi
Changeset: 67a0d70d7c6deb2e1503b73b5e4d90e7a59ff51a
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Mar 22 10:15:02 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/67a0d70d7c6deb2e1503b73b5e4d90e7a59ff51a [^]

Fixes 11715: [dl] Now windowId is not a required value

---
M src/org/openbravo/erpCommon/security/Menu.java
---
(0025911)
shuehner (administrator)
2010-04-06 19:14

Tested in pi/oracle with rev: ba70331d074a. Working fine with and without windowId now. An error is logged on a non-matching tabId/windowId (same behavior as before).
(0026363)
hudsonbot (developer)
2010-04-19 21:10

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/67a0d70d7c6d [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]

- Issue History
Date Modified Username Field Change
2009-12-09 19:38 shuehner New Issue
2009-12-09 19:38 shuehner Assigned To => iperdomo
2010-01-19 10:12 iperdomo Status new => acknowledged
2010-03-22 09:18 iperdomo Status acknowledged => scheduled
2010-03-22 09:18 iperdomo fix_in_branch => pi
2010-03-22 10:23 hgbot Checkin
2010-03-22 10:23 hgbot Note Added: 0025638
2010-03-22 10:23 hgbot Status scheduled => resolved
2010-03-22 10:23 hgbot Resolution open => fixed
2010-03-22 10:23 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/67a0d70d7c6deb2e1503b73b5e4d90e7a59ff51a [^]
2010-04-06 19:14 shuehner Note Added: 0025911
2010-04-06 19:14 shuehner Status resolved => closed
2010-04-06 19:17 shuehner Relationship added related to 0012886
2010-04-07 00:00 anonymous sf_bug_id 0 => 2982900
2010-04-19 21:10 hudsonbot Checkin
2010-04-19 21:10 hudsonbot Note Added: 0026363


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker