Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011715Openbravo ERPA. Platformpublic2009-12-09 19:382010-04-19 21:10
Reportershuehner 
Assigned Toiperdomo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011715: DeepLinking: contains both windowId & tabId in link where only tabId is really needed
Descriptionas the code reads windowId based on tabId and already reject non-matching pairs.
Steps To Reproduce
Proposed SolutionRemove usage of windowId and use the windowId for the specified tabId instead.

Old links will still work (windowId is just ignored)
New links will be simpler as one parameter less is required.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00128862.50MP17 closed iperdomo Deep Linking log NPE and show empty error page on invalid tabId 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-12-09 19:38shuehnerNew Issue
2009-12-09 19:38shuehnerAssigned To => iperdomo
2010-01-19 10:12iperdomoStatusnew => acknowledged
2010-03-22 09:18iperdomoStatusacknowledged => scheduled
2010-03-22 09:18iperdomofix_in_branch => pi
2010-03-22 10:23hgbotCheckin
2010-03-22 10:23hgbotNote Added: 0025638
2010-03-22 10:23hgbotStatusscheduled => resolved
2010-03-22 10:23hgbotResolutionopen => fixed
2010-03-22 10:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/67a0d70d7c6deb2e1503b73b5e4d90e7a59ff51a [^]
2010-04-06 19:14shuehnerNote Added: 0025911
2010-04-06 19:14shuehnerStatusresolved => closed
2010-04-06 19:17shuehnerRelationship addedrelated to 0012886
2010-04-07 00:00anonymoussf_bug_id0 => 2982900
2010-04-19 21:10hudsonbotCheckin
2010-04-19 21:10hudsonbotNote Added: 0026363

Notes
(0025638)
hgbot   
2010-03-22 10:23   
Repository: erp/devel/pi
Changeset: 67a0d70d7c6deb2e1503b73b5e4d90e7a59ff51a
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Mar 22 10:15:02 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/67a0d70d7c6deb2e1503b73b5e4d90e7a59ff51a [^]

Fixes 11715: [dl] Now windowId is not a required value

---
M src/org/openbravo/erpCommon/security/Menu.java
---
(0025911)
shuehner   
2010-04-06 19:14   
Tested in pi/oracle with rev: ba70331d074a. Working fine with and without windowId now. An error is logged on a non-matching tabId/windowId (same behavior as before).
(0026363)
hudsonbot   
2010-04-19 21:10   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/67a0d70d7c6d [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]