Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0012886
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2010-04-06 19:172010-05-18 12:12
ReportershuehnerView Statuspublic 
Assigned Toiperdomo 
PrioritynormalResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revision8af91206af1a
ProjectionnoneETAnoneTarget Version2.50MP17
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0012886: Deep Linking log NPE and show empty error page on invalid tabId

DescriptionUsing an invalid (non-existing) tabId for deep linking shows an NPE (on tab.getWindow()) and an empty error page to the user.

Logging an error (like invalid tabId: <value>) and going to the normal menu page would be a better way of handling that error.
Steps To ReproduceUse a deep linking url with a non-existing tabId:

example:
http://localhost:8080/openbravo/security/Menu.html?Command=NEW&tabId=221 [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0011715 closediperdomo DeepLinking: contains both windowId & tabId in link where only tabId is really needed 

-  Notes
(0025913)
hgbot (developer)
2010-04-06 19:23

Repository: erp/devel/pi
Changeset: 8af91206af1a2417bbb09d80d9b0baab6371f6b4
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Apr 06 19:30:53 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8af91206af1a2417bbb09d80d9b0baab6371f6b4 [^]

Fixes issue 12886: Prevents NPE on invalid tabId

---
M src/org/openbravo/erpCommon/security/Menu.java
---
(0025914)
shuehner (administrator)
2010-04-06 20:08

Tested on pi/psotgresql, rev: 8af91206af1a. On invalid tabId and error is logged and the user is transparently redirected to the menu.
(0026420)
hudsonbot (developer)
2010-04-19 21:12

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/8af91206af1a [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]

- Issue History
Date Modified Username Field Change
2010-04-06 19:17 shuehner New Issue
2010-04-06 19:17 shuehner Assigned To => iperdomo
2010-04-06 19:17 shuehner Relationship added related to 0011715
2010-04-06 19:17 iperdomo Status new => scheduled
2010-04-06 19:17 iperdomo fix_in_branch => pi
2010-04-06 19:17 iperdomo Target Version => 2.50MP15
2010-04-06 19:17 iperdomo fix_in_branch pi =>
2010-04-06 19:23 hgbot Checkin
2010-04-06 19:23 hgbot Note Added: 0025913
2010-04-06 19:23 hgbot Status scheduled => resolved
2010-04-06 19:23 hgbot Resolution open => fixed
2010-04-06 19:23 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8af91206af1a2417bbb09d80d9b0baab6371f6b4 [^]
2010-04-06 20:08 shuehner Note Added: 0025914
2010-04-06 20:08 shuehner Status resolved => closed
2010-04-06 20:08 shuehner Fixed in Version => pi
2010-04-07 00:00 anonymous sf_bug_id 0 => 2982906
2010-04-19 21:12 hudsonbot Checkin
2010-04-19 21:12 hudsonbot Note Added: 0026420
2010-05-18 12:12 gorka_gil Target Version 2.50MP15 => 2.50MP17


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker