Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030641 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | minor | always | 2015-08-24 11:00 | 2016-02-02 09:35 | |||
| Reporter | maite | View Status | public | |||||
| Assigned To | aferraz | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | e91be7b7dbef | ||||
| Projection | none | ETA | none | Target Version | 3.0PR15Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | dmiguelez | |||||||
| Web browser | ||||||||
| Modules | Advanced Payables and Receivables Mngmt | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2014-09-23 | |||||||
| Regression introduced in release | 3.0PR14Q4 | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0030641: Payment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab | |||||||
| Description | Payment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab | |||||||
| Steps To Reproduce | 1. Access "Cuenta de Banco" financial account 2. Create new transaction and press + button to add payment 3. Realize that Payment Method field is filled with "Cheque" 4. Select "Alimentos y Supermercados, S.A" business partner and realize that Payment Method combo is not reloaded with business partner default payment method (Transferencia), which was standard behavior before add transaction refactor | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||||||||||||||||||||||||||||
|
|||||||||||||||||||||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0079712) aferraz (manager) 2015-08-25 14:40 |
Test plan: - Set "Cheque" as default payment method to "Hoteles Buenas Noches, S.A." business partner - Access "Cuenta de Banco" financial account - Create new transaction and press + button to add payment - Realize that Payment Method field is filled with "Cheque" - Select "Alimentos y Supermercados, S.A" business partner and realize that Payment Method combo is reloaded with business partner default payment method (Transferencia). Check Order/Invoice grid is also correctly reloaded. - Select "Hoteles Buenas Noches, S.A." business partner and realize that Payment Method combo is reloaded with business partner default payment method (Cheque). Check Order/Invoice grid is also correctly reloaded. - Select "Restaurantes Luna Llena, S.A." business partner and realize that Payment Method combo is reloaded with business partner default payment method (Transferencia). Check Order/Invoice grid is also correctly reloaded. |
|
(0079733) hgbot (developer) 2015-08-26 10:01 |
Repository: erp/devel/pi Changeset: e91be7b7dbef1e1f6d3ee7326ab04ece6ce13368 Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Tue Aug 25 14:00:35 2015 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e91be7b7dbef1e1f6d3ee7326ab04ece6ce13368 [^] Fixes issue 30641: Payment Method not reloaded in Add Payment process Payment Method was not being reloaded when setting Business Partner in Add Payment process opened from Transaction tab. ReceivedFromPaymentMethodActionHandler was not breaking the loop when a valid payment method was found. Also, payment method name will be retrieved to display it correctly in Add Payment window. --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ReceivedFromPaymentMethodActionHandler.java M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js --- |
|
(0079736) dmiguelez (developer) 2015-08-26 10:01 |
Code Review + Testing Ok |
|
(0079762) hudsonbot (developer) 2015-08-26 21:54 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d7da276db20c [^] Maturity status: Test |
|
(0080042) aferraz (manager) 2015-09-03 11:54 |
Reopened as the following scenario is not working properly: - Go to Financial Account window, search by "Caja". - Move to Payment Method tab and create "Transferencia" payment method as active = false - Go to Business Partner window, select "Alimentos y Supermercados" and set "Transferencia" payment method and "Caja" financial account as default in Customer tab. - Go back to "Caja" Financial Account - Move to Transactions tab and add a new one (BP Deposit). - Click on the "+" option of Payment field. - In the "Add Payment" window, select "Alimentos y Supermercados" in the field "Received From". - Realize that "Transferencia" payment method is shown, although it is not active for this financial account. |
|
(0080048) psanjuan (manager) 2015-09-03 13:31 edited on: 2015-09-03 13:32 |
Test plan described in first note verified. Scenario above verified for both BP Deposit and BP Withdrawal transaction. Currently "Transferencia" payment method is not shown because it is not Active. Verified. Issue can be closed. |
|
(0080095) hgbot (developer) 2015-09-04 12:32 |
Repository: erp/devel/pi Changeset: 5f4c2906f294d346092b75032013fdda02da0b75 Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri Sep 04 10:26:47 2015 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/5f4c2906f294d346092b75032013fdda02da0b75 [^] Related to issue 30641: Reload payment method only if it is active Reload payment method when changing business partner in the selector only if business partner default payment method is active for the current financial account. Also ReceivedFromPaymentMethodActionHandler performance has been improved. --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ReceivedFromPaymentMethodActionHandler.java --- |
|
(0080106) dmiguelez (developer) 2015-09-04 12:36 |
Additional commit to complete fix: http://code.openbravo.com/erp/devel/pi/rev/5f4c2906f294d346092b75032013fdda02da0b75 [^] |
|
(0080108) dmiguelez (developer) 2015-09-04 12:36 |
Code Review + Testing Ok |
|
(0080216) hudsonbot (developer) 2015-09-07 21:18 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f3ddf66cdf4b [^] Maturity status: Test |
|
(0083811) hgbot (developer) 2016-02-02 09:35 |
Repository: tools/automation/int Changeset: 3441e287dc6493eccf4e4c3e02877c281ba7889a Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri Sep 25 11:33:45 2015 +0200 URL: http://code.openbravo.com/tools/automation/int/rev/3441e287dc6493eccf4e4c3e02877c281ba7889a [^] Related to issue 30641, Related to issue 29942: Added some automated tests --- M src-test/com/openbravo/test/integration/erp/gui/financial/receivablespayables/transactions/AddPaymentProcess.java M src-test/com/openbravo/test/integration/erp/gui/financial/receivablespayables/transactions/financialaccount/TransactionTab.java M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/BusinessPartnerTab.java M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/BusinessPartnerWindow.java M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/classic/BusinessPartnerTab.java M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/classic/BusinessPartnerWindow.java M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/RegressionSuite.java M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/build.xml M src-test/com/openbravo/test/integration/erp/testscripts/financial/receivablespayables/transactions/FinancialAccount.java M src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/BusinessPartner.java M src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/BusinessPartnerScript.java A src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/VendorCreditorTab.java A src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/classic/VendorCreditorTab.java A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression30641In29942In.java A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression30641Out29942Out.java A src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/VendorCreditorClassicScript.java A src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/VendorCreditorScript.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-08-24 11:00 | maite | New Issue | |
| 2015-08-24 11:00 | maite | Assigned To | => Triage Finance |
| 2015-08-24 11:00 | maite | Modules | => Advanced Payables and Receivables Mngmt |
| 2015-08-24 11:00 | maite | Resolution time | => 1442700000 |
| 2015-08-24 11:00 | maite | Triggers an Emergency Pack | => No |
| 2015-08-24 11:00 | maite | Issue Monitored: networkb | |
| 2015-08-25 09:09 | aferraz | Assigned To | Triage Finance => aferraz |
| 2015-08-25 11:54 | aferraz | Relationship added | caused by 0029387 |
| 2015-08-25 11:56 | aferraz | Regression level | => Production - Confirmed Stable |
| 2015-08-25 11:56 | aferraz | Regression date | => 2014-09-23 |
| 2015-08-25 11:56 | aferraz | Regression introduced in release | => 3.0PR14Q4 |
| 2015-08-25 11:56 | aferraz | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^] |
| 2015-08-25 12:00 | aferraz | Status | new => scheduled |
| 2015-08-25 14:40 | aferraz | Note Added: 0079712 | |
| 2015-08-26 10:01 | hgbot | Checkin | |
| 2015-08-26 10:01 | hgbot | Note Added: 0079733 | |
| 2015-08-26 10:01 | hgbot | Status | scheduled => resolved |
| 2015-08-26 10:01 | hgbot | Resolution | open => fixed |
| 2015-08-26 10:01 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/e91be7b7dbef1e1f6d3ee7326ab04ece6ce13368 [^] |
| 2015-08-26 10:01 | dmiguelez | Review Assigned To | => dmiguelez |
| 2015-08-26 10:01 | dmiguelez | Note Added: 0079736 | |
| 2015-08-26 10:01 | dmiguelez | Status | resolved => closed |
| 2015-08-26 21:54 | hudsonbot | Checkin | |
| 2015-08-26 21:54 | hudsonbot | Note Added: 0079762 | |
| 2015-09-03 11:54 | aferraz | Note Added: 0080042 | |
| 2015-09-03 11:54 | aferraz | Status | closed => new |
| 2015-09-03 11:54 | aferraz | Resolution | fixed => open |
| 2015-09-03 12:02 | aferraz | Relationship added | related to 0030712 |
| 2015-09-03 12:03 | aferraz | Relationship added | related to 0030719 |
| 2015-09-03 12:30 | aferraz | Severity | major => minor |
| 2015-09-03 13:31 | psanjuan | Note Added: 0080048 | |
| 2015-09-03 13:32 | psanjuan | Note Edited: 0080048 | View Revisions |
| 2015-09-03 13:32 | psanjuan | Note Edited: 0080048 | View Revisions |
| 2015-09-04 12:32 | hgbot | Checkin | |
| 2015-09-04 12:32 | hgbot | Note Added: 0080095 | |
| 2015-09-04 12:36 | dmiguelez | Status | new => scheduled |
| 2015-09-04 12:36 | dmiguelez | Note Added: 0080106 | |
| 2015-09-04 12:36 | dmiguelez | Status | scheduled => resolved |
| 2015-09-04 12:36 | dmiguelez | Resolution | open => fixed |
| 2015-09-04 12:36 | dmiguelez | Note Added: 0080108 | |
| 2015-09-04 12:36 | dmiguelez | Status | resolved => closed |
| 2015-09-07 21:18 | hudsonbot | Checkin | |
| 2015-09-07 21:18 | hudsonbot | Note Added: 0080216 | |
| 2015-09-10 12:56 | aferraz | Relationship added | related to 0030623 |
| 2016-02-02 09:35 | hgbot | Checkin | |
| 2016-02-02 09:35 | hgbot | Note Added: 0083811 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |