Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030661
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] Z. Othersminoralways2015-08-24 11:002015-09-04 12:37
ReportermaiteView Statuspublic 
Assigned Toaferraz 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision725f39b6fa93
ProjectionnoneETAnoneTarget Version3.0PR15Q3.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression levelProduction - Confirmed Stable
Regression date2014-09-23
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
Triggers an Emergency PackNo
Summary

0030661: Payment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab

DescriptionPayment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab
Steps To Reproduce1. Access "Cuenta de Banco" financial account
2. Create new transaction and press + button to add payment
3. Realize that Payment Method field is filled with "Cheque"
4. Select "Alimentos y Supermercados, S.A" business partner and realize that Payment Method combo is not reloaded with business partner default payment method (Transferencia), which was standard behavior before add transaction refactor
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 00306413.0PR15Q4 closedaferraz Payment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab 

-  Notes
(0079734)
hgbot (developer)
2015-08-26 10:01

 Repository: erp/backports/3.0PR15Q3.1
Changeset: 725f39b6fa93991651d51a44a18ef84d1fc923f3
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Aug 25 14:00:35 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3.1/rev/725f39b6fa93991651d51a44a18ef84d1fc923f3 [^]

Fixes issue 30661: Payment Method not reloaded in Add Payment process

Payment Method was not being reloaded when setting Business Partner in Add Payment process opened from Transaction tab.
ReceivedFromPaymentMethodActionHandler was not breaking the loop when a valid payment method was found.
Also, payment method name will be retrieved to display it correctly in Add Payment window.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ReceivedFromPaymentMethodActionHandler.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0079735)
dmiguelez (developer)
2015-08-26 10:01

 Code Review + Testing Ok
(0080043)
aferraz (manager)
2015-09-03 11:55

 Reopened as the following scenario is not working properly:

- Go to Financial Account window, search by "Caja".
- Move to Payment Method tab and create "Transferencia" payment method as active = false
- Go to Business Partner window, select "Alimentos y Supermercados" and set "Transferencia" payment method and "Caja" financial account as default in Customer tab.
- Go back to "Caja" Financial Account
- Move to Transactions tab and add a new one (BP Deposit).
- Click on the "+" option of Payment field.
- In the "Add Payment" window, select "Alimentos y Supermercados" in the field "Received From".
- Realize that "Transferencia" payment method is shown, although it is not active for this financial account.
(0080100)
hgbot (developer)
2015-09-04 12:32

 Repository: erp/backports/3.0PR15Q3.1
Changeset: ba4ab8980e961a22e9e70601abc8d7f0f29550df
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 04 10:26:47 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3.1/rev/ba4ab8980e961a22e9e70601abc8d7f0f29550df [^]

Related to issue 30661: Reload payment method only if it is active

Reload payment method when changing business partner in the selector only if business partner default payment method is active for the current financial account.
Also ReceivedFromPaymentMethodActionHandler performance has been improved.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ReceivedFromPaymentMethodActionHandler.java
---
(0080109)
dmiguelez (developer)
2015-09-04 12:37

 Additional commit to complete fix:
 http://code.openbravo.com/erp/backports/3.0PR15Q3.1/rev/ba4ab8980e961a22e9e70601abc8d7f0f29550df [^]
(0080110)
dmiguelez (developer)
2015-09-04 12:37

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2015-08-25 12:00 aferraz Type defect => backport
2015-08-25 12:00 aferraz Target Version 3.0PR15Q4 => 3.0PR15Q3.1
2015-08-26 10:01 hgbot Checkin
2015-08-26 10:01 hgbot Note Added: 0079734
2015-08-26 10:01 hgbot Status scheduled => resolved
2015-08-26 10:01 hgbot Resolution open => fixed
2015-08-26 10:01 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q3.1/rev/725f39b6fa93991651d51a44a18ef84d1fc923f3 [^]
2015-08-26 10:01 dmiguelez Review Assigned To => dmiguelez
2015-08-26 10:01 dmiguelez Note Added: 0079735
2015-08-26 10:01 dmiguelez Status resolved => closed
2015-09-03 11:55 aferraz Note Added: 0080043
2015-09-03 11:55 aferraz Status closed => new
2015-09-03 11:55 aferraz Resolution fixed => open
2015-09-03 12:30 aferraz Severity major => minor
2015-09-04 12:32 hgbot Checkin
2015-09-04 12:32 hgbot Note Added: 0080100
2015-09-04 12:37 dmiguelez Status new => acknowledged
2015-09-04 12:37 dmiguelez Status acknowledged => scheduled
2015-09-04 12:37 dmiguelez Note Added: 0080109
2015-09-04 12:37 dmiguelez Status scheduled => resolved
2015-09-04 12:37 dmiguelez Resolution open => fixed
2015-09-04 12:37 dmiguelez Note Added: 0080110
2015-09-04 12:37 dmiguelez Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker