Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030661Openbravo ERPZ. Otherspublic2015-08-24 11:002015-09-04 12:37
Reportermaite 
Assigned Toaferraz 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3.1Fixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-09-23
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
Triggers an Emergency PackNo
Summary0030661: Payment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab
DescriptionPayment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab
Steps To Reproduce1. Access "Cuenta de Banco" financial account
2. Create new transaction and press + button to add payment
3. Realize that Payment Method field is filled with "Cheque"
4. Select "Alimentos y Supermercados, S.A" business partner and realize that Payment Method combo is not reloaded with business partner default payment method (Transferencia), which was standard behavior before add transaction refactor
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00306413.0PR15Q4 closed aferraz Payment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-25 12:00aferrazTypedefect => backport
2015-08-25 12:00aferrazTarget Version3.0PR15Q4 => 3.0PR15Q3.1
2015-08-26 10:01hgbotCheckin
2015-08-26 10:01hgbotNote Added: 0079734
2015-08-26 10:01hgbotStatusscheduled => resolved
2015-08-26 10:01hgbotResolutionopen => fixed
2015-08-26 10:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q3.1/rev/725f39b6fa93991651d51a44a18ef84d1fc923f3 [^]
2015-08-26 10:01dmiguelezReview Assigned To => dmiguelez
2015-08-26 10:01dmiguelezNote Added: 0079735
2015-08-26 10:01dmiguelezStatusresolved => closed
2015-09-03 11:55aferrazNote Added: 0080043
2015-09-03 11:55aferrazStatusclosed => new
2015-09-03 11:55aferrazResolutionfixed => open
2015-09-03 12:30aferrazSeveritymajor => minor
2015-09-04 12:32hgbotCheckin
2015-09-04 12:32hgbotNote Added: 0080100
2015-09-04 12:37dmiguelezStatusnew => acknowledged
2015-09-04 12:37dmiguelezStatusacknowledged => scheduled
2015-09-04 12:37dmiguelezNote Added: 0080109
2015-09-04 12:37dmiguelezStatusscheduled => resolved
2015-09-04 12:37dmiguelezResolutionopen => fixed
2015-09-04 12:37dmiguelezNote Added: 0080110
2015-09-04 12:37dmiguelezStatusresolved => closed

Notes
(0079734)
hgbot   
2015-08-26 10:01   
Repository: erp/backports/3.0PR15Q3.1
Changeset: 725f39b6fa93991651d51a44a18ef84d1fc923f3
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Aug 25 14:00:35 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3.1/rev/725f39b6fa93991651d51a44a18ef84d1fc923f3 [^]

Fixes issue 30661: Payment Method not reloaded in Add Payment process

Payment Method was not being reloaded when setting Business Partner in Add Payment process opened from Transaction tab.
ReceivedFromPaymentMethodActionHandler was not breaking the loop when a valid payment method was found.
Also, payment method name will be retrieved to display it correctly in Add Payment window.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ReceivedFromPaymentMethodActionHandler.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0079735)
dmiguelez   
2015-08-26 10:01   
Code Review + Testing Ok
(0080043)
aferraz   
2015-09-03 11:55   
Reopened as the following scenario is not working properly:

- Go to Financial Account window, search by "Caja".
- Move to Payment Method tab and create "Transferencia" payment method as active = false
- Go to Business Partner window, select "Alimentos y Supermercados" and set "Transferencia" payment method and "Caja" financial account as default in Customer tab.
- Go back to "Caja" Financial Account
- Move to Transactions tab and add a new one (BP Deposit).
- Click on the "+" option of Payment field.
- In the "Add Payment" window, select "Alimentos y Supermercados" in the field "Received From".
- Realize that "Transferencia" payment method is shown, although it is not active for this financial account.
(0080100)
hgbot   
2015-09-04 12:32   
Repository: erp/backports/3.0PR15Q3.1
Changeset: ba4ab8980e961a22e9e70601abc8d7f0f29550df
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 04 10:26:47 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3.1/rev/ba4ab8980e961a22e9e70601abc8d7f0f29550df [^]

Related to issue 30661: Reload payment method only if it is active

Reload payment method when changing business partner in the selector only if business partner default payment method is active for the current financial account.
Also ReceivedFromPaymentMethodActionHandler performance has been improved.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ReceivedFromPaymentMethodActionHandler.java
---
(0080109)
dmiguelez   
2015-09-04 12:37   
Additional commit to complete fix:
 http://code.openbravo.com/erp/backports/3.0PR15Q3.1/rev/ba4ab8980e961a22e9e70601abc8d7f0f29550df [^]
(0080110)
dmiguelez   
2015-09-04 12:37   
Code Review + Testing Ok