Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030641Openbravo ERPZ. Otherspublic2015-08-24 11:002016-02-02 09:35
Reportermaite 
Assigned Toaferraz 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4Fixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-09-23
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
Triggers an Emergency PackNo
Summary0030641: Payment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab
DescriptionPayment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab
Steps To Reproduce1. Access "Cuenta de Banco" financial account
2. Create new transaction and press + button to add payment
3. Realize that Payment Method field is filled with "Cheque"
4. Select "Alimentos y Supermercados, S.A" business partner and realize that Payment Method combo is not reloaded with business partner default payment method (Transferencia), which was standard behavior before add transaction refactor
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00306613.0PR15Q3.1 closed aferraz Payment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab 
depends on backport 00306623.0PR15Q2.5 closed aferraz Payment Method not reloaded when setting Business Partner in Add Payment process from Transaction tab 
caused by feature request 0029387 closed Sandrahuguet Transaction refactor project 
related to defect 00307123.0PR15Q4 closed aferraz Payment Method not filled when running Add Payment From Invoice and business partner has not default Financial Account 
related to defect 00307193.0PR15Q4 closed aferraz Deposit To in Add Payment should only show financial accounts where selected payment method is active 
related to defect 00306233.0PR15Q4 closed aferraz "deposit to" field in Add Payment process does not show all available financial accounts 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-24 11:00maiteNew Issue
2015-08-24 11:00maiteAssigned To => Triage Finance
2015-08-24 11:00maiteModules => Advanced Payables and Receivables Mngmt
2015-08-24 11:00maiteResolution time => 1442700000
2015-08-24 11:00maiteTriggers an Emergency Pack => No
2015-08-24 11:00maiteIssue Monitored: networkb
2015-08-25 09:09aferrazAssigned ToTriage Finance => aferraz
2015-08-25 11:54aferrazRelationship addedcaused by 0029387
2015-08-25 11:56aferrazRegression level => Production - Confirmed Stable
2015-08-25 11:56aferrazRegression date => 2014-09-23
2015-08-25 11:56aferrazRegression introduced in release => 3.0PR14Q4
2015-08-25 11:56aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
2015-08-25 12:00aferrazStatusnew => scheduled
2015-08-25 14:40aferrazNote Added: 0079712
2015-08-26 10:01hgbotCheckin
2015-08-26 10:01hgbotNote Added: 0079733
2015-08-26 10:01hgbotStatusscheduled => resolved
2015-08-26 10:01hgbotResolutionopen => fixed
2015-08-26 10:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e91be7b7dbef1e1f6d3ee7326ab04ece6ce13368 [^]
2015-08-26 10:01dmiguelezReview Assigned To => dmiguelez
2015-08-26 10:01dmiguelezNote Added: 0079736
2015-08-26 10:01dmiguelezStatusresolved => closed
2015-08-26 21:54hudsonbotCheckin
2015-08-26 21:54hudsonbotNote Added: 0079762
2015-09-03 11:54aferrazNote Added: 0080042
2015-09-03 11:54aferrazStatusclosed => new
2015-09-03 11:54aferrazResolutionfixed => open
2015-09-03 12:02aferrazRelationship addedrelated to 0030712
2015-09-03 12:03aferrazRelationship addedrelated to 0030719
2015-09-03 12:30aferrazSeveritymajor => minor
2015-09-03 13:31psanjuanNote Added: 0080048
2015-09-03 13:32psanjuanNote Edited: 0080048bug_revision_view_page.php?bugnote_id=0080048#r9325
2015-09-03 13:32psanjuanNote Edited: 0080048bug_revision_view_page.php?bugnote_id=0080048#r9326
2015-09-04 12:32hgbotCheckin
2015-09-04 12:32hgbotNote Added: 0080095
2015-09-04 12:36dmiguelezStatusnew => scheduled
2015-09-04 12:36dmiguelezNote Added: 0080106
2015-09-04 12:36dmiguelezStatusscheduled => resolved
2015-09-04 12:36dmiguelezResolutionopen => fixed
2015-09-04 12:36dmiguelezNote Added: 0080108
2015-09-04 12:36dmiguelezStatusresolved => closed
2015-09-07 21:18hudsonbotCheckin
2015-09-07 21:18hudsonbotNote Added: 0080216
2015-09-10 12:56aferrazRelationship addedrelated to 0030623
2016-02-02 09:35hgbotCheckin
2016-02-02 09:35hgbotNote Added: 0083811

Notes
(0079712)
aferraz   
2015-08-25 14:40   
Test plan:

- Set "Cheque" as default payment method to "Hoteles Buenas Noches, S.A." business partner
- Access "Cuenta de Banco" financial account
- Create new transaction and press + button to add payment
- Realize that Payment Method field is filled with "Cheque"
- Select "Alimentos y Supermercados, S.A" business partner and realize that Payment Method combo is reloaded with business partner default payment method (Transferencia). Check Order/Invoice grid is also correctly reloaded.
- Select "Hoteles Buenas Noches, S.A." business partner and realize that Payment Method combo is reloaded with business partner default payment method (Cheque). Check Order/Invoice grid is also correctly reloaded.
- Select "Restaurantes Luna Llena, S.A." business partner and realize that Payment Method combo is reloaded with business partner default payment method (Transferencia). Check Order/Invoice grid is also correctly reloaded.
(0079733)
hgbot   
2015-08-26 10:01   
Repository: erp/devel/pi
Changeset: e91be7b7dbef1e1f6d3ee7326ab04ece6ce13368
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Aug 25 14:00:35 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e91be7b7dbef1e1f6d3ee7326ab04ece6ce13368 [^]

Fixes issue 30641: Payment Method not reloaded in Add Payment process

Payment Method was not being reloaded when setting Business Partner in Add Payment process opened from Transaction tab.
ReceivedFromPaymentMethodActionHandler was not breaking the loop when a valid payment method was found.
Also, payment method name will be retrieved to display it correctly in Add Payment window.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ReceivedFromPaymentMethodActionHandler.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0079736)
dmiguelez   
2015-08-26 10:01   
Code Review + Testing Ok
(0079762)
hudsonbot   
2015-08-26 21:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d7da276db20c [^]
Maturity status: Test
(0080042)
aferraz   
2015-09-03 11:54   
Reopened as the following scenario is not working properly:

- Go to Financial Account window, search by "Caja".
- Move to Payment Method tab and create "Transferencia" payment method as active = false
- Go to Business Partner window, select "Alimentos y Supermercados" and set "Transferencia" payment method and "Caja" financial account as default in Customer tab.
- Go back to "Caja" Financial Account
- Move to Transactions tab and add a new one (BP Deposit).
- Click on the "+" option of Payment field.
- In the "Add Payment" window, select "Alimentos y Supermercados" in the field "Received From".
- Realize that "Transferencia" payment method is shown, although it is not active for this financial account.
(0080048)
psanjuan   
2015-09-03 13:31   
(edited on: 2015-09-03 13:32)
Test plan described in first note verified.

Scenario above verified for both BP Deposit and BP Withdrawal transaction.
Currently "Transferencia" payment method is not shown because it is not Active.

Verified. Issue can be closed.
(0080095)
hgbot   
2015-09-04 12:32   
Repository: erp/devel/pi
Changeset: 5f4c2906f294d346092b75032013fdda02da0b75
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 04 10:26:47 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5f4c2906f294d346092b75032013fdda02da0b75 [^]

Related to issue 30641: Reload payment method only if it is active

Reload payment method when changing business partner in the selector only if business partner default payment method is active for the current financial account.
Also ReceivedFromPaymentMethodActionHandler performance has been improved.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ReceivedFromPaymentMethodActionHandler.java
---
(0080106)
dmiguelez   
2015-09-04 12:36   
Additional commit to complete fix:
http://code.openbravo.com/erp/devel/pi/rev/5f4c2906f294d346092b75032013fdda02da0b75 [^]
(0080108)
dmiguelez   
2015-09-04 12:36   
Code Review + Testing Ok
(0080216)
hudsonbot   
2015-09-07 21:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f3ddf66cdf4b [^]
Maturity status: Test
(0083811)
hgbot   
2016-02-02 09:35   
Repository: tools/automation/int
Changeset: 3441e287dc6493eccf4e4c3e02877c281ba7889a
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 25 11:33:45 2015 +0200
URL: http://code.openbravo.com/tools/automation/int/rev/3441e287dc6493eccf4e4c3e02877c281ba7889a [^]

Related to issue 30641, Related to issue 29942: Added some automated tests

---
M src-test/com/openbravo/test/integration/erp/gui/financial/receivablespayables/transactions/AddPaymentProcess.java
M src-test/com/openbravo/test/integration/erp/gui/financial/receivablespayables/transactions/financialaccount/TransactionTab.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/BusinessPartnerTab.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/BusinessPartnerWindow.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/classic/BusinessPartnerTab.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/classic/BusinessPartnerWindow.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/build.xml
M src-test/com/openbravo/test/integration/erp/testscripts/financial/receivablespayables/transactions/FinancialAccount.java
M src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/BusinessPartner.java
M src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/BusinessPartnerScript.java
A src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/VendorCreditorTab.java
A src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/classic/VendorCreditorTab.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression30641In29942In.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression30641Out29942Out.java
A src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/VendorCreditorClassicScript.java
A src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/VendorCreditorScript.java
---