0008348: Report dimensional invoice shows invoices of all organizations

Description

In sales invoice dimensional report, if you don't select any organization, all invoices are showns, independently of organizations that user conected has access

Steps To Reproduce

user1 only has access to org1
user2 only has access to org2

create invoice in org1
access to OpenbravoERP with user2 and execute sales invoice dimensional report with combo "Organization" void.

The problem is that, if filter is left blank, organization 0 (and all its sub-organizations tree) is taken by default and causes this wrong filtering.

Proposed Solution

The proposed solution is the following: if a user leaves the Organization combo-box blank, the report will be filtered by the organization (and sub-organizations tree) the user is logged with.

Technical solution:
1.Inside if (vars.commandIn("DEFAULT", "DEFAULT_COMPARATIVE")), replace value set in String strOrg = vars.getGlobalVariable("inpOrg", "ReportInvoiceCustomerDimensionalAnalysesJR|org", "0"); by String strOrg = vars.getGlobalVariable("inpOrg", "ReportInvoiceCustomerDimensionalAnalysesJR|org", "");

2. Inside if (vars.commandIn("EDIT_HTML", "EDIT_HTML_COMPARATIVE")) and if (vars.commandIn("EDIT_PDF", "EDIT_PDF_COMPARATIVE")), replace String strOrg = vars.getGlobalVariable("inpOrg", "ReportInvoiceCustomerDimensionalAnalysesJR|org", "0"); by String strOrg = vars.getRequestGlobalVariable("inpOrg", "ReportInvoiceCustomerDimensionalAnalysesJR|org");

3. Inside printPageHtml, just before the selects (if (strComparative.equals("Y"))), add: if (strOrg.equals("")) strOrg = vars.getOrg();

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	backport	0008394		closed	areefbasha	Reports shows data of all organizations
blocks	defect	0008343		closed	areefbasha	Report dimensional invoice shows invoices of all organizations

Notes
(0015090) hgbot (developer) 2009-03-31 17:22	Repository: erp/stable/2.40 Changeset: 6ff611975f13ada629b69d52b538474899fc8b73 Author: areefbasha <areef.basha <at> openbravo.com> Date: Tue Mar 31 20:50:39 2009 -0400 URL: http://code.openbravo.com/erp/stable/2.40/rev/6ff611975f13ada629b69d52b538474899fc8b73 [^] Fixed 8348: Report dimensional invoice shows invoices of all organizations. --- M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR.java ---

(0016241) sureshbabu (reporter) 2009-05-11 11:03	Tested working fine

Issue History
Date Modified	Username	Field	Change
2009-03-30 18:20	rafaroda	Type	defect => backport
2009-03-30 18:20	rafaroda	fix_in_branch	=> 2.40
2009-03-31 06:58	areefbasha	Assigned To	sathiyan => areefbasha
2009-03-31 17:22	hgbot	Checkin
2009-03-31 17:22	hgbot	Note Added: 0015090
2009-03-31 17:22	hgbot	Status	scheduled => resolved
2009-03-31 17:22	hgbot	Resolution	open => fixed
2009-03-31 17:22	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/stable/2.40/rev/6ff611975f13ada629b69d52b538474899fc8b73 [^]
2009-04-02 09:36	rafaroda	Relationship added	related to 0008394
2009-05-10 19:37	psarobe	Fixed in Version	=> 2.40MP4
2009-05-11 11:03	sureshbabu	Status	resolved => closed
2009-05-11 11:03	sureshbabu	Note Added: 0016241