Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0008343
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2009-03-30 14:002009-04-25 00:00
ReporternetworkbView Statuspublic 
Assigned Toareefbasha 
PriorityimmediateResolutionfixedFixed in Version2.50MP1
StatusclosedFix in branchpiFixed in SCM revisionbcd9ef5fe9b9
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_11
OS VersionrPath LinuxDatabase version8.3.5Ant version1.7.1
Product Version2.40MP3SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0008343: Report dimensional invoice shows invoices of all organizations

DescriptionIn sales invoice dimensional report, if you don't select any organization, all invoices are showns, independently of organizations that user conected has access
Steps To Reproduceuser1 only has access to org1
user2 only has access to org2

create invoice in org1
access to OpenbravoERP with user2 and execute sales invoice dimensional report with combo "Organization" void.

The problem is that, if filter is left blank, organization 0 (and all its sub-organizations tree) is taken by default and causes this wrong filtering.

Proposed SolutionThe proposed solution is the following: if a user leaves the Organization combo-box blank, the report will be filtered by the organization (and sub-organizations tree) the user is logged with.

Technical solution:
1.Inside if (vars.commandIn("DEFAULT", "DEFAULT_COMPARATIVE")), replace value set in String strOrg = vars.getGlobalVariable("inpOrg", "ReportInvoiceCustomerDimensionalAnalysesJR|org", "0"); by String strOrg = vars.getGlobalVariable("inpOrg", "ReportInvoiceCustomerDimensionalAnalysesJR|org", "");

2. Inside if (vars.commandIn("EDIT_HTML", "EDIT_HTML_COMPARATIVE")) and if (vars.commandIn("EDIT_PDF", "EDIT_PDF_COMPARATIVE")), replace String strOrg = vars.getGlobalVariable("inpOrg", "ReportInvoiceCustomerDimensionalAnalysesJR|org", "0"); by String strOrg = vars.getRequestGlobalVariable("inpOrg", "ReportInvoiceCustomerDimensionalAnalysesJR|org");

3. Inside printPageHtml, just before the selects (if (strComparative.equals("Y"))), add: if (strOrg.equals("")) strOrg = vars.getOrg();
Tagsmain
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0008348 closedareefbasha Report dimensional invoice shows invoices of all organizations 
has duplicate defect 0008682 closedAinhoaPagola The filter on the dimensional reports maintains the values after remove a previous selection 
has duplicate backport 00086602.40 closedAinhoaPagola Dimensional Reports don't clean every filter 
related to defect 0008372 closedareefbasha Reports shows data of all organizations 

-  Notes
(0015091)
hgbot (developer)
2009-03-31 18:22

 Repository: erp/devel/pi
Changeset: bcd9ef5fe9b90d715870196f3460a79c8352cd6a
Author: areefbasha <areef.basha <at> openbravo.com>
Date: Tue Mar 31 21:50:21 2009 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/bcd9ef5fe9b90d715870196f3460a79c8352cd6a [^]

Fixed 8343: Report dimensional invoice shows invoices of all organizations.

---
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR.java
---
(0015667)
sureshbabu (reporter)
2009-04-24 09:55

 Tested working fine

- Issue History
Date Modified Username Field Change
2009-03-30 14:00 networkb New Issue
2009-03-30 14:00 networkb Assigned To => rafaroda
2009-03-30 14:00 networkb Regression testing => No
2009-03-30 18:20 rafaroda Assigned To rafaroda => sathiyan
2009-03-30 18:20 rafaroda Proposed Solution updated
2009-03-30 18:20 rafaroda Steps to Reproduce Updated
2009-03-30 18:20 rafaroda Status new => scheduled
2009-03-30 18:20 rafaroda fix_in_branch => pi
2009-03-31 06:58 areefbasha Assigned To sathiyan => areefbasha
2009-03-31 18:22 hgbot Checkin
2009-03-31 18:22 hgbot Note Added: 0015091
2009-03-31 18:22 hgbot Status scheduled => resolved
2009-03-31 18:22 hgbot Resolution open => fixed
2009-03-31 18:22 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bcd9ef5fe9b90d715870196f3460a79c8352cd6a [^]
2009-04-02 09:35 rafaroda Relationship added related to 0008372
2009-04-21 18:10 AinhoaPagola Relationship added has duplicate 0008682
2009-04-22 11:24 psarobe Tag Attached: main
2009-04-24 09:55 sureshbabu Status resolved => closed
2009-04-24 09:55 sureshbabu Note Added: 0015667
2009-04-24 09:55 sureshbabu Fixed in Version => main
2009-04-25 00:00 anonymous sf_bug_id 0 => 2780812
2009-10-29 12:56 rafaroda Relationship added has duplicate 0008660

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker