Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0008177
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2009-03-17 19:042009-04-22 00:01
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version2.50
StatusclosedFix in branchpiFixed in SCM revision217112210a53
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.40SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0008177: Calculations done by XmlEngine (i.e. sum) are done using double. which leads to calculation errors.

DescriptionXmlEngine can do some calculations when rendering i.e. a report. Example total sum of some values shown in the rows.

This calculations are done using double which leads to errors. Depending on the output-formatting these errors are sometimes 'hidden' as the rounded value is by accident the correct value.
Steps To Reproduce- Use the Payment Aging Balance report as example [1].
- Enter data to be shown in the report to either only show ten lines of Value '0.1' in some column or to include ten extra lines of value '0.1'. One way of entering data for this is to follow the description in the page ag [2]
- edit the config/Format.xml to change autoInform formatting to the following '#,##0.####################'
- See that the total value shown in the report is incorrect.


[1] Financial Management || Receivables & Payables || Analysis Tools || Payment Aging Balance || Payment Aging Balance
[2] http://wiki.openbravo.com/wiki/Talk:Demo_Script/Op01_Pending_receivables_by_date_ranges [^]
Proposed SolutionChange XmlEngine internal representation from double -> BigDecimal
TagsNo tags attached.
Attached Filesxml file icon Format.xml [^] (3,303 bytes) 2009-03-17 19:04
png file icon xmlengine_doubles_std.png [^] (81,394 bytes) 2009-03-17 19:04

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0008242 closedshuehner Calculations done by XmlEngine (i.e. sum) are done using double. which leads to calculation errors. 
related to defect 0008098 closedshuehner Double representation should not be used for numbers as it is inprecise 
related to defect 00121002.50MP14 closeddbaz Firefox doesn't add numbers correctly in Sales Management 

-  Notes
(0014740)
shuehner (administrator)
2009-03-17 19:05

 Added screenshot of incorrect calculation and Format.xml with the needed change.
(0014741)
shuehner (administrator)
2009-03-17 19:06

 Note: These incorrect calculation can happen with every XmlEngine-generated report doing calculations in the report (sum,avg,...) with the 'right' input values.
(0014895)
hgbot (developer)
2009-03-24 12:40

 Repository: erp/devel/pi
Changeset: 217112210a5303d7f401b97d51c7723f322b17b7
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Mar 24 12:40:34 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/217112210a5303d7f401b97d51c7723f322b17b7 [^]

Fixed 8177: change xmlEngine calculations from using double -> BigDecimal

---
M src-core/src/org/openbravo/xmlEngine/FunctionAddValue.java
M src-core/src/org/openbravo/xmlEngine/FunctionDivideValue.java
M src-core/src/org/openbravo/xmlEngine/FunctionEqualValue.java
M src-core/src/org/openbravo/xmlEngine/FunctionGtValue.java
M src-core/src/org/openbravo/xmlEngine/FunctionLtValue.java
M src-core/src/org/openbravo/xmlEngine/FunctionMaxValue.java
M src-core/src/org/openbravo/xmlEngine/FunctionMedValue.java
M src-core/src/org/openbravo/xmlEngine/FunctionMinValue.java
M src-core/src/org/openbravo/xmlEngine/FunctionModuleValue.java
M src-core/src/org/openbravo/xmlEngine/FunctionMultiplyValue.java
M src-core/src/org/openbravo/xmlEngine/FunctionSubtractValue.java
M src-core/src/org/openbravo/xmlEngine/FunctionSumValue.java
M src-core/src/org/openbravo/xmlEngine/FunctionTemplate.java
---

- Issue History
Date Modified Username Field Change
2009-03-17 19:04 shuehner New Issue
2009-03-17 19:04 shuehner Assigned To => shuehner
2009-03-17 19:04 shuehner Regression testing => No
2009-03-17 19:04 shuehner File Added: Format.xml
2009-03-17 19:04 shuehner File Added: xmlengine_doubles_std.png
2009-03-17 19:05 shuehner Note Added: 0014740
2009-03-17 19:06 shuehner Note Added: 0014741
2009-03-17 19:06 shuehner Relationship added related to 0008098
2009-03-23 19:30 shuehner Status new => scheduled
2009-03-23 19:30 shuehner fix_in_branch => pi
2009-03-24 12:40 hgbot Checkin
2009-03-24 12:40 hgbot Note Added: 0014895
2009-03-24 12:40 hgbot Status scheduled => resolved
2009-03-24 12:40 hgbot Resolution open => fixed
2009-03-24 12:40 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/217112210a5303d7f401b97d51c7723f322b17b7 [^]
2009-04-21 10:53 psarobe Status resolved => closed
2009-04-22 00:01 anonymous sf_bug_id 0 => 2778081
2010-02-02 21:22 shuehner Relationship added related to 0012100

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker