Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0008098
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2009-03-12 16:352009-04-22 00:01
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PriorityhighResolutionfixedFixed in Version2.50
StatusclosedFix in branchpiFixed in SCM revision2f1991b64f1a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0008098: Double representation should not be used for numbers as it is inprecise

DescriptionDouble's are still used as intermediate representation in two places. Depending on values and configured precision this leads to wrong numbers displayed to the user.

XmlEngine/DataGrid (still) use Double when formatting according to formats defined in Format.xml
Steps To Reproduce- Go to MRP -> Manufacturing plan
- Enter a header
- Enter a single line
- Execute the following sql in the underlying database (just to shortcut the process of entering this value):
update mrp_run_productionline set qty = '0.77777777777777777777777777';
- Last step changes the quantity of all Manufacturingplan lines to this value.
- edit config/Format.xml
  change the formatOutput value for "qtyRelation" to "#,##0.###############################"
- display the manufacturing plan line again and so that not the correct value (as entered in the update step) is displayed but a different one.
- The correct value should be displayed as the configured Format.xml entry has more digits as the example quantity value.
Proposed SolutionFix XmlEngine & DataGrid to not use double as intermediate format when formatting numbers.

TagsNo tags attached.
Attached Filespng file icon issue-8098.png [^] (15,830 bytes) 2009-03-12 16:45

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00045122.50 closedvmromanos Float Point Errors 
related to defect 0008177 closedshuehner Calculations done by XmlEngine (i.e. sum) are done using double. which leads to calculation errors. 
depends on backport 0008134 closedshuehner Double representation should not be used for numbers as it is inprecise 

-  Notes
(0014617)
shuehner (administrator)
2009-03-12 16:39

I did not verify but this bug is probably present backwards other version too (2.40,2.35,...)
(0014618)
shuehner (administrator)
2009-03-12 16:45

Attached file with screenshot for the described case.
(0014784)
hgbot (developer)
2009-03-18 13:50

Repository: erp/devel/pi
Changeset: 2f1991b64f1adae427c6863f6accafe5a86a367b
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Mar 18 13:43:55 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2f1991b64f1adae427c6863f6accafe5a86a367b [^]

Fixed 8098: changed outputformatting in edit & grid view to not use double as intermediate representation
Use BigDecimal instead to avoid floating point problems

---
M src-core/src/org/openbravo/xmlEngine/FieldValue.java
M src/org/openbravo/erpCommon/utility/DataGrid.java
---

- Issue History
Date Modified Username Field Change
2009-03-12 16:35 shuehner New Issue
2009-03-12 16:35 shuehner Assigned To => rafaroda
2009-03-12 16:35 shuehner Regression testing => No
2009-03-12 16:35 shuehner Relationship added related to 0004512
2009-03-12 16:39 shuehner Note Added: 0014617
2009-03-12 16:45 shuehner File Added: issue-8098.png
2009-03-12 16:45 shuehner Note Added: 0014618
2009-03-16 11:39 rafaroda Assigned To rafaroda => shuehner
2009-03-16 11:39 rafaroda Priority normal => high
2009-03-16 11:39 rafaroda Status new => scheduled
2009-03-16 11:39 rafaroda fix_in_branch => pi
2009-03-17 19:06 shuehner Relationship added related to 0008177
2009-03-18 13:50 hgbot Checkin
2009-03-18 13:50 hgbot Note Added: 0014784
2009-03-18 13:50 hgbot Status scheduled => resolved
2009-03-18 13:50 hgbot Resolution open => fixed
2009-03-18 13:50 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2f1991b64f1adae427c6863f6accafe5a86a367b [^]
2009-04-21 10:33 psarobe Status resolved => closed
2009-04-22 00:01 anonymous sf_bug_id 0 => 2778073


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker