Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0007577
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 01. General setupmajoralways2009-02-16 13:392009-03-05 08:01
ReporterrafarodaView Statuspublic 
Assigned Toshuehner 
PriorityimmediateResolutionfixedFixed in Version2.40MP3
StatusclosedFix in branch2.40Fixed in SCM revision13493
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.5
OS VersionUbuntu 7.10Database version8.3Ant version1.7
Product VersionpiSCM revision9059 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0007577: Improve messaging where there is no conversion rate

DescriptionWhen there is no conversion rate a message is displayed. It has to be fixed in two ways:
1) Only display the message, not additional error message.
2) Parse it well in PostgreSQL.
Steps To ReproduceSELECT C_Currency_rate(TO_NUMBER('100'), TO_NUMBER('133'), TO_DATE('01-01-2008'), null, TO_NUMBER('1000000'), TO_NUMBER('1000000')) FROM DUAL;
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0007721 closedshuehner On PostgreSQL, there is an incorrect error message when creating periods for non numerical Fiscal Years 
blocks defect 0005625 closedshuehner Improve messaging where there is no conversion rate 
blocks backport 0007305 closedrafaroda Procurement reports do not handle currencies 

-  Notes
(0013529)
rafaroda (developer)
2009-02-16 13:40

We are having a problem with database functions errors handling that is preventing us to address an OBN issue.

What we need to do is to get an error message built inside a function in a similar way that we handle messages built within procedures. The message that we get making try and catch in Java to this database function is:

javax.servlet.ServletException: @CODE=0@ERROR: @NoConversionRate@ (EUR-€) @to@ (CNY-¥) @ForDate@ '07-08-2006', @Client@ 'BigBazaar' @And@ @ACCS_AD_ORG_ID_D@ 'Main'.

This is then passed to Utility.translateError function that does not parse it 100% correctly in Oracle and does not parse it at all in PostgreSQL.

Our concern is whether we have to change something in the database function when RAISE EXCEPTION the error or our platform (Utility.translateError) is not capable to parse error messages coming from functions (in the same way it does it from procedure errors).
(0013765)
svnbot (reporter)
2009-02-19 19:55

Repository: openbravo
Revision: 13428
Author: huehner
Date: 2009-02-19 19:55:00 +0100 (Thu, 19 Feb 2009)

Fixed 7577
Fix showing translated error messages in pl-code which contain @template@ strings on postgresql

---
U branches/r2.40/src/org/openbravo/erpCommon/utility/ErrorTextParserPOSTGRE.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=13428&sc=1 [^]
(0013834)
shuehner (administrator)
2009-02-20 13:03

reopen as defect was also reopened
(0013839)
svnbot (reporter)
2009-02-20 14:11

Repository: openbravo
Revision: 13468
Author: huehner
Date: 2009-02-20 14:11:10 +0100 (Fri, 20 Feb 2009)

Fixed 7577
- Fix error reporting in main catch block for all servlets to work with the error translation code.
- Improve logging of the exception handled at that location by also log its stacktrace.

---
U branches/r2.40/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=13468&sc=1 [^]
(0013873)
shuehner (administrator)
2009-02-20 19:36

The change did break parsing of error messages returned by running processes (through ad_pinstance) creating the regression reported in 7721.
(0013883)
svnbot (reporter)
2009-02-22 14:24

Repository: openbravo
Revision: 13493
Author: huehner
Date: 2009-02-22 14:24:45 +0100 (Sun, 22 Feb 2009)

Fixed 7577
Adjust for second type of callers using different pattern in input string

---
U branches/r2.40/src/org/openbravo/erpCommon/utility/ErrorTextParserPOSTGRE.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=13493&sc=1 [^]
(0014412)
sureshbabu (reporter)
2009-03-05 08:01

Retested in context http://79.125.57.19/openbravo240mp3psg [^]

- Issue History
Date Modified Username Field Change
2009-02-16 13:39 rafaroda New Issue
2009-02-16 13:39 rafaroda Assigned To => shuehner
2009-02-16 13:39 rafaroda Regression testing => No
2009-02-16 13:39 rafaroda Issue generated from 0005625
2009-02-16 13:39 rafaroda Relationship added blocks 0005625
2009-02-16 13:40 rafaroda Note Added: 0013529
2009-02-16 13:40 rafaroda Status new => scheduled
2009-02-16 13:42 rafaroda Relationship added blocks 0007305
2009-02-16 13:42 rafaroda Description Updated
2009-02-16 13:49 rafaroda Proposed Solution updated
2009-02-16 13:49 rafaroda fix_in_branch => 2.40
2009-02-19 12:36 shuehner Priority urgent => immediate
2009-02-19 19:55 svnbot Checkin
2009-02-19 19:55 svnbot Note Added: 0013765
2009-02-19 19:55 svnbot Status scheduled => resolved
2009-02-19 19:55 svnbot Resolution open => fixed
2009-02-19 19:55 svnbot svn_revision => 13428
2009-02-20 13:03 shuehner Status resolved => new
2009-02-20 13:03 shuehner Resolution fixed => open
2009-02-20 13:03 shuehner Note Added: 0013834
2009-02-20 14:11 svnbot Checkin
2009-02-20 14:11 svnbot Note Added: 0013839
2009-02-20 14:11 svnbot Status new => resolved
2009-02-20 14:11 svnbot Resolution open => fixed
2009-02-20 14:11 svnbot svn_revision 13428 => 13468
2009-02-20 19:36 shuehner Status resolved => new
2009-02-20 19:36 shuehner Resolution fixed => open
2009-02-20 19:36 shuehner Note Added: 0013873
2009-02-22 14:23 shuehner Relationship added related to 0007721
2009-02-22 14:24 svnbot Checkin
2009-02-22 14:24 svnbot Note Added: 0013883
2009-02-22 14:24 svnbot Status new => resolved
2009-02-22 14:24 svnbot Resolution open => fixed
2009-02-22 14:24 svnbot svn_revision 13468 => 13493
2009-03-03 17:31 psarobe Fixed in Version => 2.40MP3
2009-03-05 08:01 sureshbabu Status resolved => closed
2009-03-05 08:01 sureshbabu Note Added: 0014412


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker