Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0007577Openbravo ERP01. General setuppublic2009-02-16 13:392009-03-05 08:01
Reporterrafaroda 
Assigned Toshuehner 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 7.10
Product Versionpi 
Target VersionFixed in Version2.40MP3 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0007577: Improve messaging where there is no conversion rate
DescriptionWhen there is no conversion rate a message is displayed. It has to be fixed in two ways:
1) Only display the message, not additional error message.
2) Parse it well in PostgreSQL.
Steps To ReproduceSELECT C_Currency_rate(TO_NUMBER('100'), TO_NUMBER('133'), TO_DATE('01-01-2008'), null, TO_NUMBER('1000000'), TO_NUMBER('1000000')) FROM DUAL;
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0007721 closed shuehner On PostgreSQL, there is an incorrect error message when creating periods for non numerical Fiscal Years 
blocks defect 0005625 closed shuehner Improve messaging where there is no conversion rate 
blocks backport 0007305 closed rafaroda Procurement reports do not handle currencies 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-02-16 13:39rafarodaNew Issue
2009-02-16 13:39rafarodaAssigned To => shuehner
2009-02-16 13:39rafarodaRegression testing => No
2009-02-16 13:39rafarodaIssue generated from0005625
2009-02-16 13:39rafarodaRelationship addedblocks 0005625
2009-02-16 13:40rafarodaNote Added: 0013529
2009-02-16 13:40rafarodaStatusnew => scheduled
2009-02-16 13:42rafarodaRelationship addedblocks 0007305
2009-02-16 13:42rafarodaDescription Updated
2009-02-16 13:49rafarodaProposed Solution updated
2009-02-16 13:49rafarodafix_in_branch => 2.40
2009-02-19 12:36shuehnerPriorityurgent => immediate
2009-02-19 19:55svnbotCheckin
2009-02-19 19:55svnbotNote Added: 0013765
2009-02-19 19:55svnbotStatusscheduled => resolved
2009-02-19 19:55svnbotResolutionopen => fixed
2009-02-19 19:55svnbotsvn_revision => 13428
2009-02-20 13:03shuehnerStatusresolved => new
2009-02-20 13:03shuehnerResolutionfixed => open
2009-02-20 13:03shuehnerNote Added: 0013834
2009-02-20 14:11svnbotCheckin
2009-02-20 14:11svnbotNote Added: 0013839
2009-02-20 14:11svnbotStatusnew => resolved
2009-02-20 14:11svnbotResolutionopen => fixed
2009-02-20 14:11svnbotsvn_revision13428 => 13468
2009-02-20 19:36shuehnerStatusresolved => new
2009-02-20 19:36shuehnerResolutionfixed => open
2009-02-20 19:36shuehnerNote Added: 0013873
2009-02-22 14:23shuehnerRelationship addedrelated to 0007721
2009-02-22 14:24svnbotCheckin
2009-02-22 14:24svnbotNote Added: 0013883
2009-02-22 14:24svnbotStatusnew => resolved
2009-02-22 14:24svnbotResolutionopen => fixed
2009-02-22 14:24svnbotsvn_revision13468 => 13493
2009-03-03 17:31psarobeFixed in Version => 2.40MP3
2009-03-05 08:01sureshbabuStatusresolved => closed
2009-03-05 08:01sureshbabuNote Added: 0014412

Notes
(0013529)
rafaroda   
2009-02-16 13:40   
We are having a problem with database functions errors handling that is preventing us to address an OBN issue.

What we need to do is to get an error message built inside a function in a similar way that we handle messages built within procedures. The message that we get making try and catch in Java to this database function is:

javax.servlet.ServletException: @CODE=0@ERROR: @NoConversionRate@ (EUR-€) @to@ (CNY-¥) @ForDate@ '07-08-2006', @Client@ 'BigBazaar' @And@ @ACCS_AD_ORG_ID_D@ 'Main'.

This is then passed to Utility.translateError function that does not parse it 100% correctly in Oracle and does not parse it at all in PostgreSQL.

Our concern is whether we have to change something in the database function when RAISE EXCEPTION the error or our platform (Utility.translateError) is not capable to parse error messages coming from functions (in the same way it does it from procedure errors).
(0013765)
svnbot   
2009-02-19 19:55   
Repository: openbravo
Revision: 13428
Author: huehner
Date: 2009-02-19 19:55:00 +0100 (Thu, 19 Feb 2009)

Fixed 7577
Fix showing translated error messages in pl-code which contain @template@ strings on postgresql

---
U branches/r2.40/src/org/openbravo/erpCommon/utility/ErrorTextParserPOSTGRE.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=13428&sc=1 [^]
(0013834)
shuehner   
2009-02-20 13:03   
reopen as defect was also reopened
(0013839)
svnbot   
2009-02-20 14:11   
Repository: openbravo
Revision: 13468
Author: huehner
Date: 2009-02-20 14:11:10 +0100 (Fri, 20 Feb 2009)

Fixed 7577
- Fix error reporting in main catch block for all servlets to work with the error translation code.
- Improve logging of the exception handled at that location by also log its stacktrace.

---
U branches/r2.40/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=13468&sc=1 [^]
(0013873)
shuehner   
2009-02-20 19:36   
The change did break parsing of error messages returned by running processes (through ad_pinstance) creating the regression reported in 7721.
(0013883)
svnbot   
2009-02-22 14:24   
Repository: openbravo
Revision: 13493
Author: huehner
Date: 2009-02-22 14:24:45 +0100 (Sun, 22 Feb 2009)

Fixed 7577
Adjust for second type of callers using different pattern in input string

---
U branches/r2.40/src/org/openbravo/erpCommon/utility/ErrorTextParserPOSTGRE.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=13493&sc=1 [^]
(0014412)
sureshbabu   
2009-03-05 08:01   
Retested in context http://79.125.57.19/openbravo240mp3psg [^]