Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0006903 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 09. Financial management | minor | have not tried | 2009-01-15 10:10 | 2009-02-20 15:35 | |||
| Reporter | plujan | View Status | public | |||||
| Assigned To | vmromanos | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 2.50beta | |||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 13402 | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 64 bit | Database | PostgreSQL | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | 2.50alpha-r6 | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0006903: On Fiscal Calendar, Year field has no validation | |||||||
| Description | When creating a Fiscal Calendar I should enter the Fiscal Year, but this field has no validation, so I can enter no valid values and save. Then, the Create Periods button performs an incorrect action. | |||||||
| Steps To Reproduce | 1. Go Financial Management > Accounting > Setup > Fiscal Calendar 2. Create a new Calendar 3. Create a new Year, on Fiscal Year field enter a valid value, 2009 4. Save and click on Create Periods. All this works fine. 5. Go back Year tab and create a new record. This time enter a text "current". 6. Save. It is possible to save. Create periods. The periods are created for 9999 year, but no error is shown. 5. Go back Year tab and create a new record. This time enter a negative value, -2. 6. Save. It is possible to save. Create periods. The periods are created for 0003 year, but no error is shown. Note that name is missing the two digit year. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0012309) psarobe (viewer) 2009-01-19 11:20 |
The solution could be to make a trigger or callout |
|
(0012704) vmromanos (viewer) 2009-01-27 18:32 |
We have decided to create both a callout and a check into the Create Periods procedure. The callout will inform the user if he inserts a non-numeric value, and the procedure will exit if the fiscal year is not in a valid numeric format |
|
(0012709) svnbot (viewer) 2009-01-27 19:16 |
Repository: openbravo Revision: 12337 Author: vmromanos Date: 2009-01-27 19:15:38 +0100 (Tue, 27 Jan 2009) Fixed bug 6903: On Fiscal Calendar, Year field has no validation. Created a callout and added a check into the C_YearPeriods procedure. --- A trunk/src/org/openbravo/erpCommon/ad_callouts/SL_Year_Validation.java U trunk/src-db/database/model/functions/C_YEARPERIODS.xml U trunk/src-db/database/sourcedata/AD_CALLOUT.xml U trunk/src-db/database/sourcedata/AD_COLUMN.xml U trunk/src-db/database/sourcedata/AD_MESSAGE.xml U trunk/src-db/database/sourcedata/AD_MODEL_OBJECT.xml U trunk/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml U trunk/src-db/database/sourcedata/AD_TEXTINTERFACES.xml --- https://dev.openbravo.com/websvn/openbravo/?rev=12337&sc=1 [^] |
|
(0013712) sureshbabu (viewer) 2009-02-19 08:24 |
If the user enters a non numeric value in Fiscal year field the callout is rightly informing the user, but the system still accepts the Negative number. |
|
(0013737) svnbot (viewer) 2009-02-19 13:25 |
Repository: openbravo Revision: 13402 Author: vmromanos Date: 2009-02-19 13:25:09 +0100 (Thu, 19 Feb 2009) Fixed bug 6903: On Fiscal Calendar, Year field has no validation. We also don't avoid negative values --- U trunk/src/org/openbravo/erpCommon/ad_callouts/SL_Year_Validation.java U trunk/src-db/database/model/functions/C_YEARPERIODS.xml --- https://dev.openbravo.com/websvn/openbravo/?rev=13402&sc=1 [^] |
|
(0013847) plujan (viewer) 2009-02-20 15:34 |
See related bug 0007723 to fully understand this fix |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2009-01-15 10:10 | plujan | New Issue | |
| 2009-01-15 10:10 | plujan | Assigned To | => rafaroda |
| 2009-01-15 10:10 | plujan | sf_bug_id | 0 => 2509254 |
| 2009-01-15 10:10 | plujan | OBNetwork customer | => No |
| 2009-01-15 10:10 | plujan | Regression testing | => No |
| 2009-01-15 10:12 | plujan | version | => 2.50alpha-r6 |
| 2009-01-19 11:20 | psarobe | Status | new => scheduled |
| 2009-01-19 11:20 | psarobe | Note Added: 0012309 | |
| 2009-01-19 11:20 | psarobe | Assigned To | rafaroda => eduardo_Argal |
| 2009-01-19 11:20 | psarobe | fix_in_branch | => trunk |
| 2009-01-27 09:10 | vmromanos | Assigned To | eduardo_Argal => vmromanos |
| 2009-01-27 18:32 | vmromanos | Note Added: 0012704 | |
| 2009-01-27 19:16 | svnbot | Checkin | |
| 2009-01-27 19:16 | svnbot | Note Added: 0012709 | |
| 2009-01-27 19:16 | svnbot | Status | scheduled => resolved |
| 2009-01-27 19:16 | svnbot | Resolution | open => fixed |
| 2009-01-27 19:16 | svnbot | svn_revision | => 12337 |
| 2009-02-19 08:24 | sureshbabu | Status | resolved => new |
| 2009-02-19 08:24 | sureshbabu | Resolution | fixed => open |
| 2009-02-19 08:24 | sureshbabu | Note Added: 0013712 | |
| 2009-02-19 13:25 | svnbot | Checkin | |
| 2009-02-19 13:25 | svnbot | Note Added: 0013737 | |
| 2009-02-19 13:25 | svnbot | Status | new => resolved |
| 2009-02-19 13:25 | svnbot | Resolution | open => fixed |
| 2009-02-19 13:25 | svnbot | svn_revision | 12337 => 13402 |
| 2009-02-20 15:32 | plujan | Relationship added | related to 0007723 |
| 2009-02-20 15:34 | plujan | Status | resolved => closed |
| 2009-02-20 15:34 | plujan | Note Added: 0013847 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |