0006824: Send alerts by e-mail

Description

In an alert, in tab 'Alert Recipient' selecting a role and an user, Openbravo sends an email to all users with this role.

Steps To Reproduce

1.- Selecting an alert
2.- In tab 'Alert Recipient' selecting a role and an user and marking 'Send Email'
3.- Openbravo sends an email to all users with the selected role (It must sends only an email to the selected user)

Proposed Solution

At file 'PeriodicAlert_data.xsql', at method 'prepareMails', the clause SQL must be:
           SELECT C.SMTPHOST,
                       REQUESTUSER,
                       REQUESTUSERPW,
                       C.REQUESTEMAIL AS MAILFROM,
                       U.EMAIL AS MAILTO,
                       C.AD_LANGUAGE
                  FROM AD_ALERTRECIPIENT R,
                       AD_USER U,
                       AD_CLIENT C
                 WHERE AD_ALERTRULE_ID = TO_NUMBER(?)
                   AND SENDEMAIL = 'Y'
                   AND R.AD_USER_ID = U.AD_USER_ID
                   AND C.AD_CLIENT_ID = U.AD_CLIENT_ID

instead:

          SELECT C.SMTPHOST,
                 REQUESTUSER,
                 REQUESTUSERPW,
                 C.REQUESTEMAIL AS MAILFROM,
                 U.EMAIL AS MAILTO,
                 C.AD_LANGUAGE
            FROM AD_ALERTRECIPIENT R,
                 AD_USER U,
                 AD_CLIENT C
           WHERE AD_ALERTRULE_ID = TO_NUMBER(?)
             AND SENDEMAIL = 'Y'
             AND R.AD_USER_ID = U.AD_USER_ID
             AND C.AD_CLIENT_ID = U.AD_CLIENT_ID
          union
          SELECT C.SMTPHOST,
                 REQUESTUSER,
                 REQUESTUSERPW,
                 C.REQUESTEMAIL AS MAILFROM,
                 U.EMAIL AS MAILTO,
                 C.AD_LANGUAGE
            FROM AD_ALERTRECIPIENT R,
                 AD_CLIENT C,
                 AD_USER U
           WHERE AD_ALERTRULE_ID = TO_NUMBER(?)
             AND SENDEMAIL = 'Y'
             AND C.AD_CLIENT_ID = U.AD_CLIENT_ID
             and u.ad_user_id in (select ad_user_id
                                    from ad_user_roles ur
                                   where ur.ad_role_id = r.ad_role_id)

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0006492

closed

anthony_wolski

Send alerts by e-mail

Notes
(0012521) svnbot (viewer) 2009-01-22 12:28	Repository: openbravo Revision: 12149 Author: anthony.wolski Date: 2009-01-22 12:28:12 +0100 (Thu, 22 Jan 2009) Fixes issue 0006824. Only send email to selected user. --- U branches/r2.40/src/org/openbravo/erpCommon/ad_background/PeriodicAlert_data.xsql --- https://dev.openbravo.com/websvn/openbravo/?rev=12149&sc=1 [^]

Issue History
Date Modified	Username	Field	Change
2009-01-09 17:31	psarobe	Type	defect => backport
2009-01-09 17:31	psarobe	fix_in_branch	=> 2.40
2009-01-10 18:07	rafaroda	Assigned To	rafaroda => anthony_wolski
2009-01-22 12:28	svnbot	Checkin
2009-01-22 12:28	svnbot	Note Added: 0012521
2009-01-22 12:28	svnbot	Status	scheduled => resolved
2009-01-22 12:28	svnbot	Resolution	open => fixed
2009-01-22 12:28	svnbot	svn_revision	=> 12149
2009-03-03 17:09	psarobe	Status	resolved => closed