0006492: Send alerts by e-mail

Description

In an alert, in tab 'Alert Recipient' selecting a role and an user, Openbravo sends an email to all users with this role.

Steps To Reproduce

1.- Selecting an alert
2.- In tab 'Alert Recipient' selecting a role and an user and marking 'Send Email'
3.- Openbravo sends an email to all users with the selected role (It must sends only an email to the selected user)

Proposed Solution

At file 'PeriodicAlert_data.xsql', at method 'prepareMails', the clause SQL must be:
           SELECT C.SMTPHOST,
                       REQUESTUSER,
                       REQUESTUSERPW,
                       C.REQUESTEMAIL AS MAILFROM,
                       U.EMAIL AS MAILTO,
                       C.AD_LANGUAGE
                  FROM AD_ALERTRECIPIENT R,
                       AD_USER U,
                       AD_CLIENT C
                 WHERE AD_ALERTRULE_ID = TO_NUMBER(?)
                   AND SENDEMAIL = 'Y'
                   AND R.AD_USER_ID = U.AD_USER_ID
                   AND C.AD_CLIENT_ID = U.AD_CLIENT_ID

instead:

          SELECT C.SMTPHOST,
                 REQUESTUSER,
                 REQUESTUSERPW,
                 C.REQUESTEMAIL AS MAILFROM,
                 U.EMAIL AS MAILTO,
                 C.AD_LANGUAGE
            FROM AD_ALERTRECIPIENT R,
                 AD_USER U,
                 AD_CLIENT C
           WHERE AD_ALERTRULE_ID = TO_NUMBER(?)
             AND SENDEMAIL = 'Y'
             AND R.AD_USER_ID = U.AD_USER_ID
             AND C.AD_CLIENT_ID = U.AD_CLIENT_ID
          union
          SELECT C.SMTPHOST,
                 REQUESTUSER,
                 REQUESTUSERPW,
                 C.REQUESTEMAIL AS MAILFROM,
                 U.EMAIL AS MAILTO,
                 C.AD_LANGUAGE
            FROM AD_ALERTRECIPIENT R,
                 AD_CLIENT C,
                 AD_USER U
           WHERE AD_ALERTRULE_ID = TO_NUMBER(?)
             AND SENDEMAIL = 'Y'
             AND C.AD_CLIENT_ID = U.AD_CLIENT_ID
             and u.ad_user_id in (select ad_user_id
                                    from ad_user_roles ur
                                   where ur.ad_role_id = r.ad_role_id)

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

backport

0006824

closed

anthony_wolski

Send alerts by e-mail

Notes
(0012529) svnbot (reporter) 2009-01-22 15:43	Repository: openbravo Revision: 12160 Author: anthony.wolski Date: 2009-01-22 15:43:10 +0100 (Thu, 22 Jan 2009) Fixes issue 0006492. Only select selected users. --- U trunk/src/org/openbravo/erpCommon/ad_process/AlertProcess_data.xsql --- https://dev.openbravo.com/websvn/openbravo/?rev=12160&sc=1 [^]

Issue History
Date Modified	Username	Field	Change
2008-12-11 16:46	ccasuso	New Issue
2008-12-11 16:46	ccasuso	Assigned To	=> rafaroda
2008-12-11 16:46	ccasuso	sf_bug_id	0 => 2417462
2008-12-11 16:49	mmarquez	Issue Monitored: mmarquez
2008-12-11 16:49	ccasuso	Issue Monitored: ccasuso
2009-01-09 17:31	psarobe	Status	new => scheduled
2009-01-09 17:31	psarobe	fix_in_branch	=> trunk
2009-01-10 18:07	rafaroda	Assigned To	rafaroda => anthony_wolski
2009-01-22 15:43	svnbot	Checkin
2009-01-22 15:43	svnbot	Note Added: 0012529
2009-01-22 15:43	svnbot	Status	scheduled => resolved
2009-01-22 15:43	svnbot	Resolution	open => fixed
2009-01-22 15:43	svnbot	svn_revision	=> 12160
2009-04-21 11:05	psarobe	Status	resolved => closed