Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0006279
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2008-11-30 22:542009-03-06 12:34
ReportermtaalView Statuspublic 
Assigned ToHennadzi 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision11233
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0006279: Openbravo source code contains String comparison using == instead of equals

DescriptionThere are approx. 42 places in the openbravo source code where == is used for string comparison instead of equals, for examples:
        if(newC_ValidCombination_ID == "") {
            return;
        } else {
            load(null, conn, newC_ValidCombination_ID);
            return;
        }

This is wrong, the above will almost always be false.
Steps To Reproduce
The occurrences of the illegal situation can be found by searching for the following term in the Openbravo source code:
== "
Proposed Solution
The correct comparison should be:
        if(newC_ValidCombination_ID != null && newC_ValidCombination_ID.equals("")) {
            return;
        } else {
            load(null, conn, newC_ValidCombination_ID);
            return;
        }
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0011139)
svnbot (viewer)
2008-12-10 12:23

 Repository: openbravo
Revision: 11082
Author: hennadzi
Date: 2008-12-10 12:23:45 +0100 (Wed, 10 Dec 2008)

Bug fixed 0006279: Openbravo source code contains String comparison using == instead of equals

---
U trunk/src/org/openbravo/erpCommon/ad_actionButton/ProjectCopyFrom.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/ProjectSetType.java
U trunk/src/org/openbravo/erpCommon/ad_callouts/SE_Expense_BP_Project.java
U trunk/src/org/openbravo/erpCommon/ad_callouts/SL_Inventory_Product.java
U trunk/src/org/openbravo/erpCommon/ad_callouts/SL_WRPhase_Sequence.java
U trunk/src/org/openbravo/erpCommon/ad_forms/Account.java
U trunk/src/org/openbravo/erpCommon/ad_forms/AcctSchemaElement.java
U trunk/src/org/openbravo/erpCommon/ad_forms/AcctServer.java
U trunk/src/org/openbravo/erpCommon/ad_forms/DocLine.java
U trunk/src/org/openbravo/erpCommon/ad_forms/ProductInfo.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportBPartner.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportBudget.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportOrder.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportTax.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementDaily.java
U trunk/src/org/openbravo/erpCommon/utility/JRFormatFactory.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=11082&sc=1 [^]
(0011238)
svnbot (viewer)
2008-12-12 12:50

 Repository: openbravo
Revision: 11147
Author: hennadzi
Date: 2008-12-12 12:49:58 +0100 (Fri, 12 Dec 2008)

Fixed bug 0006279: Recommited due to mistake in verification for null

---
U trunk/src/org/openbravo/erpCommon/ad_forms/DocLine.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportBPartner.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportBudget.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportTax.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=11147&sc=1 [^]
(0011327)
mtaal (viewer)
2008-12-14 21:08

 I found 5 remaining:
openbravo/src/org/openbravo/erpCommon/utility/Utility.java:1641 H B ES: Comparison of String parameter using == or != in org.openbravo.erpCommon.utility.Utility.addDaysToDate(String, String, DateFormat)
openbravo/src/org/openbravo/erpCommon/ad_callouts/SL_ScheduledMaintenance_Maintenance.java:63 M B ES: Comparison of String parameter using == or != in org.openbravo.erpCommon.ad_callouts.SL_ScheduledMaintenance_Maintenance.printPage(HttpServletResponse, VariablesSecureApp, String, String)
openbravo/src/org/openbravo/erpCommon/ad_reports/ReportBudgetGenerateExcel.java:206 M B ES: Comparison of String parameter using == or != in org.openbravo.erpCommon.ad_reports.ReportBudgetGenerateExcel.printPageDataExcel(HttpServletResponse, VariablesSecureApp, String, String, String, String, String, String, String, String, String, String, String, String)
openbravo/src/org/openbravo/erpCommon/ad_actionButton/ProjectSetType.java:245 H B ES: Comparison of String parameter using == or != in org.openbravo.erpCommon.ad_actionButton.ProjectSetType.calculateStartDate(String, DateFormat)
openbravo/src/org/openbravo/erpCommon/ad_actionButton/ProjectSetType.java:257 H B ES: Comparison of String parameter using == or != in org.openbravo.erpCommon.ad_actionButton.ProjectSetType.calculateContractDate(String, String, DateFormat)
(0011328)
mtaal (viewer)
2008-12-14 21:08

 See the note above/before this one.

gr. Martin
(0011406)
svnbot (viewer)
2008-12-16 12:03

 Repository: openbravo
Revision: 11233
Author: hennadzi
Date: 2008-12-16 12:03:15 +0100 (Tue, 16 Dec 2008)

Fixed bug 0006279: Openbravo source code contains String comparison using == instead of equals

---
U trunk/src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/ProjectSetType.java
U trunk/src/org/openbravo/erpCommon/ad_callouts/SE_Expense_BP_Project.java
U trunk/src/org/openbravo/erpCommon/ad_callouts/SL_ScheduledMaintenance_Maintenance.java
U trunk/src/org/openbravo/erpCommon/ad_forms/AcctSchema.java
U trunk/src/org/openbravo/erpCommon/ad_forms/AcctServer.java
U trunk/src/org/openbravo/erpCommon/ad_forms/DocLine_Invoice.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportBPartner.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportBudgetGenerateExcel.java
U trunk/src/org/openbravo/erpCommon/utility/Utility.java
U trunk/src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
U trunk/src-core/src/org/openbravo/xmlEngine/FunctionMedValue.java
U trunk/src-core/src/org/openbravo/xmlEngine/FunctionSumValue.java
_U trunk/src-test/org/openbravo/test/security/AllowedOrganizationsTest.java
_U trunk/src-test/org/openbravo/test/security/WritableReadableOrganizationTest.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=11233&sc=1 [^]

- Issue History
Date Modified Username Field Change
2008-11-30 22:54 mtaal New Issue
2008-11-30 22:54 mtaal Assigned To => rafaroda
2008-11-30 22:54 mtaal sf_bug_id 0 => 2367076
2008-11-30 22:54 mtaal OBNetwork customer => No
2008-11-30 22:54 mtaal Regression testing => No
2008-12-01 13:04 shuehner Issue Monitored: shuehner
2008-12-03 19:03 pjuvara Priority normal => high
2008-12-09 13:00 pheenan Assigned To rafaroda => Dowid
2008-12-09 13:57 Dowid Assigned To Dowid => Hennadzi
2008-12-10 12:23 svnbot Checkin
2008-12-10 12:23 svnbot Note Added: 0011139
2008-12-10 12:23 svnbot Status new => resolved
2008-12-10 12:23 svnbot Resolution open => fixed
2008-12-10 12:23 svnbot svn_revision => 11082
2008-12-12 12:50 svnbot Checkin
2008-12-12 12:50 svnbot Note Added: 0011238
2008-12-12 12:50 svnbot svn_revision 11082 => 11147
2008-12-14 21:08 mtaal Note Added: 0011327
2008-12-14 21:08 mtaal Status resolved => new
2008-12-14 21:08 mtaal Resolution fixed => open
2008-12-14 21:08 mtaal Note Added: 0011328
2008-12-16 12:03 svnbot Checkin
2008-12-16 12:03 svnbot Note Added: 0011406
2008-12-16 12:03 svnbot Status new => resolved
2008-12-16 12:03 svnbot Resolution open => fixed
2008-12-16 12:03 svnbot svn_revision 11147 => 11233
2009-01-09 17:48 shuehner Issue End Monitor: shuehner
2009-03-06 12:34 psarobe Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker