Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0006279Openbravo ERPA. Platformpublic2008-11-30 22:542009-03-06 12:34
Reportermtaal 
Assigned ToHennadzi 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0006279: Openbravo source code contains String comparison using == instead of equals
DescriptionThere are approx. 42 places in the openbravo source code where == is used for string comparison instead of equals, for examples:
        if(newC_ValidCombination_ID == "") {
            return;
        } else {
            load(null, conn, newC_ValidCombination_ID);
            return;
        }

This is wrong, the above will almost always be false.
Steps To Reproduce
The occurrences of the illegal situation can be found by searching for the following term in the Openbravo source code:
== "
Proposed Solution
The correct comparison should be:
        if(newC_ValidCombination_ID != null && newC_ValidCombination_ID.equals("")) {
            return;
        } else {
            load(null, conn, newC_ValidCombination_ID);
            return;
        }
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-11-30 22:54mtaalNew Issue
2008-11-30 22:54mtaalAssigned To => rafaroda
2008-11-30 22:54mtaalsf_bug_id0 => 2367076
2008-11-30 22:54mtaalOBNetwork customer => No
2008-11-30 22:54mtaalRegression testing => No
2008-12-01 13:04shuehnerIssue Monitored: shuehner
2008-12-03 19:03pjuvaraPrioritynormal => high
2008-12-09 13:00pheenanAssigned Torafaroda => Dowid
2008-12-09 13:57DowidAssigned ToDowid => Hennadzi
2008-12-10 12:23svnbotCheckin
2008-12-10 12:23svnbotNote Added: 0011139
2008-12-10 12:23svnbotStatusnew => resolved
2008-12-10 12:23svnbotResolutionopen => fixed
2008-12-10 12:23svnbotsvn_revision => 11082
2008-12-12 12:50svnbotCheckin
2008-12-12 12:50svnbotNote Added: 0011238
2008-12-12 12:50svnbotsvn_revision11082 => 11147
2008-12-14 21:08mtaalNote Added: 0011327
2008-12-14 21:08mtaalStatusresolved => new
2008-12-14 21:08mtaalResolutionfixed => open
2008-12-14 21:08mtaalNote Added: 0011328
2008-12-16 12:03svnbotCheckin
2008-12-16 12:03svnbotNote Added: 0011406
2008-12-16 12:03svnbotStatusnew => resolved
2008-12-16 12:03svnbotResolutionopen => fixed
2008-12-16 12:03svnbotsvn_revision11147 => 11233
2009-01-09 17:48shuehnerIssue End Monitor: shuehner
2009-03-06 12:34psarobeStatusresolved => closed

Notes
(0011139)
svnbot   
2008-12-10 12:23   
Repository: openbravo
Revision: 11082
Author: hennadzi
Date: 2008-12-10 12:23:45 +0100 (Wed, 10 Dec 2008)

Bug fixed 0006279: Openbravo source code contains String comparison using == instead of equals

---
U trunk/src/org/openbravo/erpCommon/ad_actionButton/ProjectCopyFrom.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/ProjectSetType.java
U trunk/src/org/openbravo/erpCommon/ad_callouts/SE_Expense_BP_Project.java
U trunk/src/org/openbravo/erpCommon/ad_callouts/SL_Inventory_Product.java
U trunk/src/org/openbravo/erpCommon/ad_callouts/SL_WRPhase_Sequence.java
U trunk/src/org/openbravo/erpCommon/ad_forms/Account.java
U trunk/src/org/openbravo/erpCommon/ad_forms/AcctSchemaElement.java
U trunk/src/org/openbravo/erpCommon/ad_forms/AcctServer.java
U trunk/src/org/openbravo/erpCommon/ad_forms/DocLine.java
U trunk/src/org/openbravo/erpCommon/ad_forms/ProductInfo.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportBPartner.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportBudget.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportOrder.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportTax.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementDaily.java
U trunk/src/org/openbravo/erpCommon/utility/JRFormatFactory.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=11082&sc=1 [^]
(0011238)
svnbot   
2008-12-12 12:50   
Repository: openbravo
Revision: 11147
Author: hennadzi
Date: 2008-12-12 12:49:58 +0100 (Fri, 12 Dec 2008)

Fixed bug 0006279: Recommited due to mistake in verification for null

---
U trunk/src/org/openbravo/erpCommon/ad_forms/DocLine.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportBPartner.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportBudget.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportTax.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=11147&sc=1 [^]
(0011327)
mtaal   
2008-12-14 21:08   
I found 5 remaining:
openbravo/src/org/openbravo/erpCommon/utility/Utility.java:1641 H B ES: Comparison of String parameter using == or != in org.openbravo.erpCommon.utility.Utility.addDaysToDate(String, String, DateFormat)
openbravo/src/org/openbravo/erpCommon/ad_callouts/SL_ScheduledMaintenance_Maintenance.java:63 M B ES: Comparison of String parameter using == or != in org.openbravo.erpCommon.ad_callouts.SL_ScheduledMaintenance_Maintenance.printPage(HttpServletResponse, VariablesSecureApp, String, String)
openbravo/src/org/openbravo/erpCommon/ad_reports/ReportBudgetGenerateExcel.java:206 M B ES: Comparison of String parameter using == or != in org.openbravo.erpCommon.ad_reports.ReportBudgetGenerateExcel.printPageDataExcel(HttpServletResponse, VariablesSecureApp, String, String, String, String, String, String, String, String, String, String, String, String)
openbravo/src/org/openbravo/erpCommon/ad_actionButton/ProjectSetType.java:245 H B ES: Comparison of String parameter using == or != in org.openbravo.erpCommon.ad_actionButton.ProjectSetType.calculateStartDate(String, DateFormat)
openbravo/src/org/openbravo/erpCommon/ad_actionButton/ProjectSetType.java:257 H B ES: Comparison of String parameter using == or != in org.openbravo.erpCommon.ad_actionButton.ProjectSetType.calculateContractDate(String, String, DateFormat)
(0011328)
mtaal   
2008-12-14 21:08   
See the note above/before this one.

gr. Martin
(0011406)
svnbot   
2008-12-16 12:03   
Repository: openbravo
Revision: 11233
Author: hennadzi
Date: 2008-12-16 12:03:15 +0100 (Tue, 16 Dec 2008)

Fixed bug 0006279: Openbravo source code contains String comparison using == instead of equals

---
U trunk/src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/ProjectSetType.java
U trunk/src/org/openbravo/erpCommon/ad_callouts/SE_Expense_BP_Project.java
U trunk/src/org/openbravo/erpCommon/ad_callouts/SL_ScheduledMaintenance_Maintenance.java
U trunk/src/org/openbravo/erpCommon/ad_forms/AcctSchema.java
U trunk/src/org/openbravo/erpCommon/ad_forms/AcctServer.java
U trunk/src/org/openbravo/erpCommon/ad_forms/DocLine_Invoice.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportBPartner.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportBudgetGenerateExcel.java
U trunk/src/org/openbravo/erpCommon/utility/Utility.java
U trunk/src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
U trunk/src-core/src/org/openbravo/xmlEngine/FunctionMedValue.java
U trunk/src-core/src/org/openbravo/xmlEngine/FunctionSumValue.java
_U trunk/src-test/org/openbravo/test/security/AllowedOrganizationsTest.java
_U trunk/src-test/org/openbravo/test/security/WritableReadableOrganizationTest.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=11233&sc=1 [^]