Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0058278
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Retail APIcriticalalways2025-03-18 15:522025-03-25 12:32
ReporterkchoperenaView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commithttps://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/commit/da86faca2b4f882ce6e21baf40011d95e5539def [^]
Triggers an Emergency PackNo
Summary

0058278: Export Order API: originalSalesOrderDocumentNumber, originalOrderLineId & returnedQuantity properties are not working anymore

DescriptionThere is a regresion introduced by the https://openbravo.atlassian.net/browse/RM-19389 [^]

The development includes an extension of a ExportJavaPropertyMappingHandler that breaks the implementation done in the ExportOrderLineJavaPropertyMappingHandler extension

Because of that, all the properties defined in ExportOrderLineJavaPropertyMappingHandler and OrderLineJavaPropertyMappingHandler are not working
Steps To ReproducePRE-REQUIREMENTS:
- Config the event subscription Web POS Order Creation. You can use https://webhook.site/ [^] as the external system that will receive the JSON

STEPS:
1.- Log into the POS2 and create a simple pick & carry ticket
2.- Using the Order selector, search the created order and in the contextual menu select "Verified Return" option to return completely the ticket

RESULT:
In the JSON we are sending to the external system, there is no info about originalSalesOrderDocumentNumber, originalOrderLineId & returnedQuantity
Proposed SolutionAs a correct implementation example, you can follow what was done in the OrderLineJavaPropertyMappingHandler java
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0177005)
hgbot (developer)
2025-03-20 05:17

 Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/merge_requests/27 [^]
(0177220)
hgbot (developer)
2025-03-25 11:52

 Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/103 [^]
(0177224)
hgbot (developer)
2025-03-25 12:31

 Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: a0abdf8d63bf48f1a3aec3060c13596dbd35bda5
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 25-03-2025 11:31:27
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/ci/modules/org.openbravo.api.tests/-/commit/a0abdf8d63bf48f1a3aec3060c13596dbd35bda5 [^]

Related to ISSUE-58278: Remove references of stock incident properties from json used in the tests

---
M src-test/data/export/filter/order/OrderByIncludedOrders.json
M src-test/data/export/filter/order/OrderByOrgOrderDate.json
M src-test/data/export/filter/order/OrderByOrgOrderDateRange.json
M src-test/data/export/filter/order/OrderByPickingCompletedPerWarehouseSinceDate.json
---
(0177225)
hgbot (developer)
2025-03-25 12:31

 Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/103 [^]
(0177226)
hgbot (developer)
2025-03-25 12:32

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api [^]
Changeset: f730af4260af28fab93256cdb036e934bfc248fd
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 25-03-2025 11:32:09
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/commit/f730af4260af28fab93256cdb036e934bfc248fd [^]

Fixes ISSUE-58278: Export Order API: originalSalesOrderDocumentNumber, originalOrderLineId & returnedQuantity properties are not working anymore

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/mappings/order/ExportOrderLinePropertyMappingHandler.java
---
(0177227)
hgbot (developer)
2025-03-25 12:32

 Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/merge_requests/27 [^]

- Issue History
Date Modified Username Field Change
2025-03-18 15:52 kchoperena New Issue
2025-03-18 15:52 kchoperena Assigned To => Retail
2025-03-18 15:52 kchoperena OBNetwork customer => OBPS
2025-03-18 15:52 kchoperena Regression introduced by commit => https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/commit/da86faca2b4f882ce6e21baf40011d95e5539def [^]
2025-03-18 15:52 kchoperena Triggers an Emergency Pack => No
2025-03-19 07:00 guillermogil Assigned To Retail => Triage Omni WMS
2025-03-19 08:19 mtaal Assigned To Triage Omni WMS => AtulOpenbravo
2025-03-19 12:54 martinsdan Issue Monitored: martinsdan
2025-03-19 12:54 martinsdan Issue End Monitor: martinsdan
2025-03-19 13:40 AtulOpenbravo Status new => scheduled
2025-03-20 05:17 hgbot Merge Request Status => open
2025-03-20 05:17 hgbot Note Added: 0177005
2025-03-25 11:23 hgbot Merge Request Status open => approved
2025-03-25 11:52 hgbot Note Added: 0177220
2025-03-25 12:31 hgbot Note Added: 0177224
2025-03-25 12:31 hgbot Note Added: 0177225
2025-03-25 12:32 hgbot Resolution open => fixed
2025-03-25 12:32 hgbot Status scheduled => closed
2025-03-25 12:32 hgbot Note Added: 0177226
2025-03-25 12:32 hgbot Note Added: 0177227

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker