Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0058278Retail ModulesRetail APIpublic2025-03-18 15:522025-03-25 12:32
Reporterkchoperena 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commithttps://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/commit/da86faca2b4f882ce6e21baf40011d95e5539def [^]
Triggers an Emergency PackNo
Summary0058278: Export Order API: originalSalesOrderDocumentNumber, originalOrderLineId & returnedQuantity properties are not working anymore
DescriptionThere is a regresion introduced by the https://openbravo.atlassian.net/browse/RM-19389 [^]

The development includes an extension of a ExportJavaPropertyMappingHandler that breaks the implementation done in the ExportOrderLineJavaPropertyMappingHandler extension

Because of that, all the properties defined in ExportOrderLineJavaPropertyMappingHandler and OrderLineJavaPropertyMappingHandler are not working
Steps To ReproducePRE-REQUIREMENTS:
- Config the event subscription Web POS Order Creation. You can use https://webhook.site/ [^] as the external system that will receive the JSON

STEPS:
1.- Log into the POS2 and create a simple pick & carry ticket
2.- Using the Order selector, search the created order and in the contextual menu select "Verified Return" option to return completely the ticket

RESULT:
In the JSON we are sending to the external system, there is no info about originalSalesOrderDocumentNumber, originalOrderLineId & returnedQuantity
Proposed SolutionAs a correct implementation example, you can follow what was done in the OrderLineJavaPropertyMappingHandler java
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2025-03-18 15:52kchoperenaNew Issue
2025-03-18 15:52kchoperenaAssigned To => Retail
2025-03-18 15:52kchoperenaOBNetwork customer => OBPS
2025-03-18 15:52kchoperenaRegression introduced by commit => https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/commit/da86faca2b4f882ce6e21baf40011d95e5539def [^]
2025-03-18 15:52kchoperenaTriggers an Emergency Pack => No
2025-03-19 07:00guillermogilAssigned ToRetail => Triage Omni WMS
2025-03-19 08:19mtaalAssigned ToTriage Omni WMS => AtulOpenbravo
2025-03-19 12:54martinsdanIssue Monitored: martinsdan
2025-03-19 12:54martinsdanIssue End Monitor: martinsdan
2025-03-19 13:40AtulOpenbravoStatusnew => scheduled
2025-03-20 05:17hgbotMerge Request Status => open
2025-03-20 05:17hgbotNote Added: 0177005
2025-03-25 11:23hgbotMerge Request Statusopen => approved
2025-03-25 11:52hgbotNote Added: 0177220
2025-03-25 12:31hgbotNote Added: 0177224
2025-03-25 12:31hgbotNote Added: 0177225
2025-03-25 12:32hgbotResolutionopen => fixed
2025-03-25 12:32hgbotStatusscheduled => closed
2025-03-25 12:32hgbotNote Added: 0177226
2025-03-25 12:32hgbotNote Added: 0177227

Notes
(0177005)
hgbot   
2025-03-20 05:17   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/merge_requests/27 [^]
(0177220)
hgbot   
2025-03-25 11:52   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/103 [^]
(0177224)
hgbot   
2025-03-25 12:31   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: a0abdf8d63bf48f1a3aec3060c13596dbd35bda5
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 25-03-2025 11:31:27
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/ci/modules/org.openbravo.api.tests/-/commit/a0abdf8d63bf48f1a3aec3060c13596dbd35bda5 [^]

Related to ISSUE-58278: Remove references of stock incident properties from json used in the tests

---
M src-test/data/export/filter/order/OrderByIncludedOrders.json
M src-test/data/export/filter/order/OrderByOrgOrderDate.json
M src-test/data/export/filter/order/OrderByOrgOrderDateRange.json
M src-test/data/export/filter/order/OrderByPickingCompletedPerWarehouseSinceDate.json
---
(0177225)
hgbot   
2025-03-25 12:31   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/103 [^]
(0177226)
hgbot   
2025-03-25 12:32   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api [^]
Changeset: f730af4260af28fab93256cdb036e934bfc248fd
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 25-03-2025 11:32:09
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/commit/f730af4260af28fab93256cdb036e934bfc248fd [^]

Fixes ISSUE-58278: Export Order API: originalSalesOrderDocumentNumber, originalOrderLineId & returnedQuantity properties are not working anymore

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/mappings/order/ExportOrderLinePropertyMappingHandler.java
---
(0177227)
hgbot   
2025-03-25 12:32   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/merge_requests/27 [^]