Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0057815
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminoralways2025-01-31 10:162025-02-15 18:48
ReporterjinigoView Statuspublic 
Assigned ToBimla_vm 
PrioritynormalResolutionfixedFixed in Version25Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0057815: [25Q1] Anonymous customer should not be validated when no email is present

DescriptionWhen email validation is configured in the Openbravo CRM, the anonymous customer (VBS Customer) is marked as invalid if no email is associated with it. This is incorrect because the anonymous customer is not supposed to have an email, and therefore should not be subject to validation.
Steps To Reproduce1. Go to Backoffice
2. Go to CRM Connector Configuration
3. Select Openbravo CRM
4. In 'API Property for Customer' select 'email'
5. In Validations & Notifications set the following values:
- Validation: Informative
- Validation Type: Empty
- Show Notification Icon in Order Header: Wrong Format
6. Ensure that 'VSB Customer' has not email (Business Partner -> VBS Customer -> Contact subtab)
7. Log in to POS2
8. Click VBS Customer -> New customer
9. Complete Greetings, Name and Last Name
10. Click Save and Assign
11. Click 'Not now' in 'Incorrect Customer Data Detected'

Error icon is shown next to the customer (correct)

12. Select any product and complete a payment

Error icon is shown next to anonymous customer (incorrect)
TagsNo tags attached.
Attached Filespng file icon Error icon next to anonymous customer.png [^] (36,087 bytes) 2025-01-31 10:16

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 005795425Q1 closedsreehari [25Q1] Anonymous customer should not be validated when no email is present 
depends on backport 005795524Q4.2 closedsreehari [25Q1] Anonymous customer should not be validated when no email is present 
related to defect 0057906 closedsreehari CRM no code : When validation information is configured in CRM, icon is not removed in anonymous customer 

-  Notes
(0175204)
hgbot (developer)
2025-02-06 10:10

 Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/78 [^]
(0175205)
hgbot (developer)
2025-02-06 10:11

 Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3463 [^]
(0175504)
sreehari (developer)
2025-02-12 07:20

 Related Issues
**************
https://issues.openbravo.com/view.php?id=56989 [^] and https://issues.openbravo.com/view.php?id=57906 [^] - Whatever CRM is used, notification and validations will not be triggered if it is a anonymous customer

https://issues.openbravo.com/view.php?id=57378 [^] - it is not expected to validate for anonymous customer
(0175511)
hgbot (developer)
2025-02-12 08:25

 Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/826 [^]
(0175699)
hgbot (developer)
2025-02-15 18:48

 Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 21388529ac3d4a0bb23681df6b4181f2554d873d
Author: Bimla V Mayavan <b.mayavan@external.orisha.com>
Date: 15-02-2025 17:48:16
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/21388529ac3d4a0bb23681df6b4181f2554d873d [^]

Related ISSUE-57815: Improve condition to detect anonymous customer

---
M web/org.openbravo.mobile.core/app/integration/external-business-partner/CRMConfigurationHelper.js
---
(0175700)
hgbot (developer)
2025-02-15 18:48

 Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/826 [^]
(0175701)
hgbot (developer)
2025-02-15 18:48

 Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: 27278dd15d41c9349d787b1b5ae893bb5e541e74
Author: Bimla V Mayavan <b.mayavan@external.orisha.com>
Date: 15-02-2025 17:40:54
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/27278dd15d41c9349d787b1b5ae893bb5e541e74 [^]

Related to ISSUE-57815: Fixed test cases

---
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/LoyaltyTicketBPButton/__test__/LoyaltyTicketBPButton.test.jsx
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/LoyaltyTicketBPButtonWithDocType/__test__/LoyaltyTicketBPButtonWithDocType.test.jsx
---
(0175702)
hgbot (developer)
2025-02-15 18:48

 Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/78 [^]
(0175703)
hgbot (developer)
2025-02-15 18:48

 Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3463 [^]
(0175704)
hgbot (developer)
2025-02-15 18:48

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 9b43cf27e4ec42bb6882b434a44fdb7113463f69
Author: Bimla V Mayavan <b.mayavan@external.orisha.com>
Date: 15-02-2025 17:48:22
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/9b43cf27e4ec42bb6882b434a44fdb7113463f69 [^]

Fixed ISSUE-57815: CRM validation for Anonymous customer should not be executed

---
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/__test__/ButtonBar1.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ButtonBar2/__test__/ButtonBar2.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ButtonBar4/__test__/ButtonBar4.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerNotification/CustomerNotification.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPNotifications/TicketBPNotifications.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPNotifications/__test__/TicketBPNotifications.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderBPButton/__test__/TicketHeaderBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListLocalGrid/__test__/TicketListLocalGrid.test.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/__test__/TicketListRemoteGrid.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/DeleteTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/LoadLocalTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/NewTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AssignExternalBusinessPartner.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/UnassignExternalBusinessPartner.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/LoadExternalBpNotifications.js
---

- Issue History
Date Modified Username Field Change
2025-01-31 10:16 jinigo New Issue
2025-01-31 10:16 jinigo Assigned To => Retail
2025-01-31 10:16 jinigo File Added: Error icon next to anonymous customer.png
2025-01-31 10:16 jinigo Triggers an Emergency Pack => No
2025-01-31 10:55 guillermogil Assigned To Retail => guilleaer
2025-02-05 09:00 Bimla_vm Assigned To guilleaer => Bimla_vm
2025-02-05 09:00 Bimla_vm Status new => scheduled
2025-02-06 10:10 hgbot Note Added: 0175204
2025-02-06 10:11 hgbot Note Added: 0175205
2025-02-12 07:16 sreehari Status scheduled => acknowledged
2025-02-12 07:16 sreehari Status acknowledged => scheduled
2025-02-12 07:20 sreehari Note Added: 0175504
2025-02-12 07:21 sreehari Relationship added related to 0057906
2025-02-12 08:25 hgbot Note Added: 0175511
2025-02-13 17:18 lorenzofidalgo Issue Monitored: lorenzofidalgo
2025-02-15 18:48 hgbot Note Added: 0175699
2025-02-15 18:48 hgbot Note Added: 0175700
2025-02-15 18:48 hgbot Note Added: 0175701
2025-02-15 18:48 hgbot Note Added: 0175702
2025-02-15 18:48 hgbot Resolution open => fixed
2025-02-15 18:48 hgbot Status scheduled => closed
2025-02-15 18:48 hgbot Note Added: 0175703
2025-02-15 18:48 hgbot Fixed in Version => 25Q2
2025-02-15 18:48 hgbot Note Added: 0175704

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker