Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057815POS2POSpublic2025-01-31 10:162025-02-15 18:48
Reporterjinigo 
Assigned ToBimla_vm 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version25Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057815: [25Q1] Anonymous customer should not be validated when no email is present
DescriptionWhen email validation is configured in the Openbravo CRM, the anonymous customer (VBS Customer) is marked as invalid if no email is associated with it. This is incorrect because the anonymous customer is not supposed to have an email, and therefore should not be subject to validation.
Steps To Reproduce1. Go to Backoffice
2. Go to CRM Connector Configuration
3. Select Openbravo CRM
4. In 'API Property for Customer' select 'email'
5. In Validations & Notifications set the following values:
- Validation: Informative
- Validation Type: Empty
- Show Notification Icon in Order Header: Wrong Format
6. Ensure that 'VSB Customer' has not email (Business Partner -> VBS Customer -> Contact subtab)
7. Log in to POS2
8. Click VBS Customer -> New customer
9. Complete Greetings, Name and Last Name
10. Click Save and Assign
11. Click 'Not now' in 'Incorrect Customer Data Detected'

Error icon is shown next to the customer (correct)

12. Select any product and complete a payment

Error icon is shown next to anonymous customer (incorrect)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005795425Q1 closed sreehari [25Q1] Anonymous customer should not be validated when no email is present 
depends on backport 005795524Q4.2 closed sreehari [25Q1] Anonymous customer should not be validated when no email is present 
related to defect 0057906 closed sreehari CRM no code : When validation information is configured in CRM, icon is not removed in anonymous customer 
Attached Filespng Error icon next to anonymous customer.png (36,087) 2025-01-31 10:16
https://issues.openbravo.com/file_download.php?file_id=20822&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2025-01-31 10:16jinigoNew Issue
2025-01-31 10:16jinigoAssigned To => Retail
2025-01-31 10:16jinigoFile Added: Error icon next to anonymous customer.png
2025-01-31 10:16jinigoTriggers an Emergency Pack => No
2025-01-31 10:55guillermogilAssigned ToRetail => guilleaer
2025-02-05 09:00Bimla_vmAssigned Toguilleaer => Bimla_vm
2025-02-05 09:00Bimla_vmStatusnew => scheduled
2025-02-06 10:10hgbotNote Added: 0175204
2025-02-06 10:11hgbotNote Added: 0175205
2025-02-12 07:16sreehariStatusscheduled => acknowledged
2025-02-12 07:16sreehariStatusacknowledged => scheduled
2025-02-12 07:20sreehariNote Added: 0175504
2025-02-12 07:21sreehariRelationship addedrelated to 0057906
2025-02-12 08:25hgbotNote Added: 0175511
2025-02-13 17:18lorenzofidalgoIssue Monitored: lorenzofidalgo
2025-02-15 18:48hgbotNote Added: 0175699
2025-02-15 18:48hgbotNote Added: 0175700
2025-02-15 18:48hgbotNote Added: 0175701
2025-02-15 18:48hgbotNote Added: 0175702
2025-02-15 18:48hgbotResolutionopen => fixed
2025-02-15 18:48hgbotStatusscheduled => closed
2025-02-15 18:48hgbotNote Added: 0175703
2025-02-15 18:48hgbotFixed in Version => 25Q2
2025-02-15 18:48hgbotNote Added: 0175704

Notes
(0175204)
hgbot   
2025-02-06 10:10   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/78 [^]
(0175205)
hgbot   
2025-02-06 10:11   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3463 [^]
(0175504)
sreehari   
2025-02-12 07:20   
Related Issues
**************
https://issues.openbravo.com/view.php?id=56989 [^] and https://issues.openbravo.com/view.php?id=57906 [^] - Whatever CRM is used, notification and validations will not be triggered if it is a anonymous customer

https://issues.openbravo.com/view.php?id=57378 [^] - it is not expected to validate for anonymous customer
(0175511)
hgbot   
2025-02-12 08:25   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/826 [^]
(0175699)
hgbot   
2025-02-15 18:48   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 21388529ac3d4a0bb23681df6b4181f2554d873d
Author: Bimla V Mayavan <b.mayavan@external.orisha.com>
Date: 15-02-2025 17:48:16
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/21388529ac3d4a0bb23681df6b4181f2554d873d [^]

Related ISSUE-57815: Improve condition to detect anonymous customer

---
M web/org.openbravo.mobile.core/app/integration/external-business-partner/CRMConfigurationHelper.js
---
(0175700)
hgbot   
2025-02-15 18:48   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/826 [^]
(0175701)
hgbot   
2025-02-15 18:48   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: 27278dd15d41c9349d787b1b5ae893bb5e541e74
Author: Bimla V Mayavan <b.mayavan@external.orisha.com>
Date: 15-02-2025 17:40:54
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/27278dd15d41c9349d787b1b5ae893bb5e541e74 [^]

Related to ISSUE-57815: Fixed test cases

---
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/LoyaltyTicketBPButton/__test__/LoyaltyTicketBPButton.test.jsx
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/LoyaltyTicketBPButtonWithDocType/__test__/LoyaltyTicketBPButtonWithDocType.test.jsx
---
(0175702)
hgbot   
2025-02-15 18:48   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/78 [^]
(0175703)
hgbot   
2025-02-15 18:48   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3463 [^]
(0175704)
hgbot   
2025-02-15 18:48   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 9b43cf27e4ec42bb6882b434a44fdb7113463f69
Author: Bimla V Mayavan <b.mayavan@external.orisha.com>
Date: 15-02-2025 17:48:22
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/9b43cf27e4ec42bb6882b434a44fdb7113463f69 [^]

Fixed ISSUE-57815: CRM validation for Anonymous customer should not be executed

---
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/__test__/ButtonBar1.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ButtonBar2/__test__/ButtonBar2.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ButtonBar4/__test__/ButtonBar4.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerNotification/CustomerNotification.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPNotifications/TicketBPNotifications.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPNotifications/__test__/TicketBPNotifications.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderBPButton/__test__/TicketHeaderBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListLocalGrid/__test__/TicketListLocalGrid.test.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/__test__/TicketListRemoteGrid.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/DeleteTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/LoadLocalTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/NewTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AssignExternalBusinessPartner.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/UnassignExternalBusinessPartner.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/LoadExternalBpNotifications.js
---