Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0057512
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminoralways2024-12-19 20:392025-01-20 17:04
ReportersofidossantView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0057512: Error with Credit Note

DescriptionIf we use the check in the bp of “Unique Credit Note”, when we make a return of that bp, and we use the payment method Credit Note, the credit note that is printed gives a document number and an amount, that if I then verify in backoffice does not exist.

VIDEO:
https://drive.google.com/file/d/1ii8NKPWFPT9HcBIY1pgdkyku8NmsVbmt/view?usp=sharing [^]
Steps To Reproduce1- Check bp example Arturo, in the tab Customer, the check “Unique Credit Note” is Yes.
https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/?tabId=223&recordId=EDC5DBD82C3B4E3896B3955E041B242C [^]
2- Check in the channel touchpoint, example VBS-3, add Credit Note Sequence Prefix example SOFIATEST
https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/?tabId=FF80818132F311740132F3233778004B&recordId=DEC7E041C6F64101BEDDC398100EB90C [^]
3- Go to the webpos2, ex. VBS-3
4 - Do a order with the bp in the step 1. payment in cash
5 - Open the order in the step 4, and clck in verificate return.
6 - Pay with credit note, and check the printer

You will see the document nro for the credit note "SOFIATES- ..." (the config that the step 2) but if you check in the backoffice, the credit note don't exist.
Proposed SolutionThe problem is that the modification for the document nro and the amount is in backoffice

if (bp.isGcnvUniquecreditnote() && !(StringUtils.equals(anonBpId, bp.getId()))) {
        final OBCriteria<GiftCardInst> giftCardInstCriteria = OBDal.getInstance()
            .createCriteria(GiftCardInst.class);
        giftCardInstCriteria.add(Restrictions.eq(GiftCardInst.PROPERTY_BUSINESSPARTNER, bp));
        giftCardInstCriteria.add(
            Restrictions.ne(GiftCardInst.PROPERTY_ALERTSTATUS, GiftCardGLItemUtils.STATUS_CLOSED));
        giftCardInstCriteria.add(Restrictions.eq(GiftCardInst.PROPERTY_ISCANCELLED, false));
        giftCardInstCriteria.add(Restrictions.eq(GiftCardInst.PROPERTY_TYPE, "BasedOnCreditNote"));
        final List<GiftCardInst> giftCardInstList = giftCardInstCriteria.list();

        long maxTime = 0;
        for (GiftCardInst giftCardInst : giftCardInstList) {
          if (giftCardInst.getCreationDate().getTime() > maxTime) {
            defDocNo = giftCardInst.getSearchKey().split("\\*C")[0];
            maxTime = giftCardInst.getCreationDate().getTime();
          }
        }
        giftcard.setSearchKey(defDocNo);
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0174262)
hgbot (developer)
2025-01-17 08:22

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/416 [^]
(0174425)
hgbot (developer)
2025-01-20 17:04

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 3b01dac638744817c8258746fe9e52813a641459
Author: Ranjith S R <r.rangaraju@external.orisha.com>
Date: 20-01-2025 16:04:42
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/3b01dac638744817c8258746fe9e52813a641459 [^]

Fixed ISSUE-57512: Implement Unique Credit Note in POs2

---
M src/org/openbravo/retail/giftcards/FindCreditNote.java
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/GiftCardUtils.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/__test__/TicketExtension.test.jsx
---
(0174426)
hgbot (developer)
2025-01-20 17:04

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/416 [^]

- Issue History
Date Modified Username Field Change
2024-12-19 20:39 sofidossant New Issue
2024-12-19 20:39 sofidossant Assigned To => Retail
2024-12-19 20:39 sofidossant Triggers an Emergency Pack => No
2024-12-19 20:41 sofidossant Proposed Solution updated
2025-01-08 18:15 guilleaer Assigned To Retail => guilleaer
2025-01-08 18:15 guilleaer Status new => acknowledged
2025-01-09 08:50 ranjith_qualiantech_com Assigned To guilleaer => ranjith_qualiantech_com
2025-01-09 08:50 ranjith_qualiantech_com Status acknowledged => scheduled
2025-01-17 08:22 hgbot Note Added: 0174262
2025-01-20 17:04 hgbot Resolution open => fixed
2025-01-20 17:04 hgbot Status scheduled => closed
2025-01-20 17:04 hgbot Note Added: 0174425
2025-01-20 17:04 hgbot Note Added: 0174426

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker