0057512: Error with Credit Note

Description

If we use the check in the bp of “Unique Credit Note”, when we make a return of that bp, and we use the payment method Credit Note, the credit note that is printed gives a document number and an amount, that if I then verify in backoffice does not exist.

VIDEO:
https://drive.google.com/file/d/1ii8NKPWFPT9HcBIY1pgdkyku8NmsVbmt/view?usp=sharing [^]

Steps To Reproduce

1- Check bp example Arturo, in the tab Customer, the check “Unique Credit Note” is Yes.
https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/?tabId=223&recordId=EDC5DBD82C3B4E3896B3955E041B242C [^]
2- Check in the channel touchpoint, example VBS-3, add Credit Note Sequence Prefix example SOFIATEST
https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/?tabId=FF80818132F311740132F3233778004B&recordId=DEC7E041C6F64101BEDDC398100EB90C [^]
3- Go to the webpos2, ex. VBS-3
4 - Do a order with the bp in the step 1. payment in cash
5 - Open the order in the step 4, and clck in verificate return.
6 - Pay with credit note, and check the printer

You will see the document nro for the credit note "SOFIATES- ..." (the config that the step 2) but if you check in the backoffice, the credit note don't exist.

Proposed Solution

The problem is that the modification for the document nro and the amount is in backoffice

if (bp.isGcnvUniquecreditnote() && !(StringUtils.equals(anonBpId, bp.getId()))) {
        final OBCriteria<GiftCardInst> giftCardInstCriteria = OBDal.getInstance()
            .createCriteria(GiftCardInst.class);
        giftCardInstCriteria.add(Restrictions.eq(GiftCardInst.PROPERTY_BUSINESSPARTNER, bp));
        giftCardInstCriteria.add(
            Restrictions.ne(GiftCardInst.PROPERTY_ALERTSTATUS, GiftCardGLItemUtils.STATUS_CLOSED));
        giftCardInstCriteria.add(Restrictions.eq(GiftCardInst.PROPERTY_ISCANCELLED, false));
        giftCardInstCriteria.add(Restrictions.eq(GiftCardInst.PROPERTY_TYPE, "BasedOnCreditNote"));
        final List<GiftCardInst> giftCardInstList = giftCardInstCriteria.list();

        long maxTime = 0;
        for (GiftCardInst giftCardInst : giftCardInstList) {
          if (giftCardInst.getCreationDate().getTime() > maxTime) {
            defDocNo = giftCardInst.getSearchKey().split("\\*C")[0];
            maxTime = giftCardInst.getCreationDate().getTime();
          }
        }
        giftcard.setSearchKey(defDocNo);

Issue History
Date Modified	Username	Field	Change
2024-12-19 20:39	sofidossant	New Issue
2024-12-19 20:39	sofidossant	Assigned To	=> Retail
2024-12-19 20:39	sofidossant	Triggers an Emergency Pack	=> No
2024-12-19 20:41	sofidossant	Proposed Solution updated

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
There are no notes attached to this issue.