Openbravo Issue Tracking System - POS2
View Issue Details
0057512POS2POSpublic2024-12-19 20:392025-01-20 17:04
sofidossant 
ranjith_qualiantech_com 
normalminoralways
closedfixed 
5
 
 
No
0057512: Error with Credit Note
If we use the check in the bp of “Unique Credit Note”, when we make a return of that bp, and we use the payment method Credit Note, the credit note that is printed gives a document number and an amount, that if I then verify in backoffice does not exist.

VIDEO:
https://drive.google.com/file/d/1ii8NKPWFPT9HcBIY1pgdkyku8NmsVbmt/view?usp=sharing [^]
1- Check bp example Arturo, in the tab Customer, the check “Unique Credit Note” is Yes.
https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/?tabId=223&recordId=EDC5DBD82C3B4E3896B3955E041B242C [^]
2- Check in the channel touchpoint, example VBS-3, add Credit Note Sequence Prefix example SOFIATEST
https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/?tabId=FF80818132F311740132F3233778004B&recordId=DEC7E041C6F64101BEDDC398100EB90C [^]
3- Go to the webpos2, ex. VBS-3
4 - Do a order with the bp in the step 1. payment in cash
5 - Open the order in the step 4, and clck in verificate return.
6 - Pay with credit note, and check the printer

You will see the document nro for the credit note "SOFIATES- ..." (the config that the step 2) but if you check in the backoffice, the credit note don't exist.
The problem is that the modification for the document nro and the amount is in backoffice

if (bp.isGcnvUniquecreditnote() && !(StringUtils.equals(anonBpId, bp.getId()))) {
        final OBCriteria<GiftCardInst> giftCardInstCriteria = OBDal.getInstance()
            .createCriteria(GiftCardInst.class);
        giftCardInstCriteria.add(Restrictions.eq(GiftCardInst.PROPERTY_BUSINESSPARTNER, bp));
        giftCardInstCriteria.add(
            Restrictions.ne(GiftCardInst.PROPERTY_ALERTSTATUS, GiftCardGLItemUtils.STATUS_CLOSED));
        giftCardInstCriteria.add(Restrictions.eq(GiftCardInst.PROPERTY_ISCANCELLED, false));
        giftCardInstCriteria.add(Restrictions.eq(GiftCardInst.PROPERTY_TYPE, "BasedOnCreditNote"));
        final List<GiftCardInst> giftCardInstList = giftCardInstCriteria.list();

        long maxTime = 0;
        for (GiftCardInst giftCardInst : giftCardInstList) {
          if (giftCardInst.getCreationDate().getTime() > maxTime) {
            defDocNo = giftCardInst.getSearchKey().split("\\*C")[0];
            maxTime = giftCardInst.getCreationDate().getTime();
          }
        }
        giftcard.setSearchKey(defDocNo);
No tags attached.
Issue History
2024-12-19 20:39sofidossantNew Issue
2024-12-19 20:39sofidossantAssigned To => Retail
2024-12-19 20:39sofidossantTriggers an Emergency Pack => No
2024-12-19 20:41sofidossantProposed Solution updated
2025-01-08 18:15guilleaerAssigned ToRetail => guilleaer
2025-01-08 18:15guilleaerStatusnew => acknowledged
2025-01-09 08:50ranjith_qualiantech_comAssigned Toguilleaer => ranjith_qualiantech_com
2025-01-09 08:50ranjith_qualiantech_comStatusacknowledged => scheduled
2025-01-17 08:22hgbotNote Added: 0174262
2025-01-20 17:04hgbotResolutionopen => fixed
2025-01-20 17:04hgbotStatusscheduled => closed
2025-01-20 17:04hgbotNote Added: 0174425
2025-01-20 17:04hgbotNote Added: 0174426

Notes
(0174262)
hgbot   
2025-01-17 08:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/416 [^]
(0174425)
hgbot   
2025-01-20 17:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 3b01dac638744817c8258746fe9e52813a641459
Author: Ranjith S R <r.rangaraju@external.orisha.com>
Date: 20-01-2025 16:04:42
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/3b01dac638744817c8258746fe9e52813a641459 [^]

Fixed ISSUE-57512: Implement Unique Credit Note in POs2

---
M src/org/openbravo/retail/giftcards/FindCreditNote.java
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/GiftCardUtils.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/__test__/TicketExtension.test.jsx
---
(0174426)
hgbot   
2025-01-20 17:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/416 [^]