Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0056656
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminorN/A2024-10-04 12:042024-11-07 16:43
Reportergorka_gilView Statuspublic 
Assigned ToSABARINATH P 
PrioritynormalResolutionfixedFixed in VersionPR25Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0056656: funds transfer: tests are broken

DescriptionBecause of this issue : https://issues.openbravo.com/view.php?id=56654, [^]

the tests of funds transfer are not executed in ci.

Apart of that they are broken from 7 years ago, since they are calling to createTransfer function of 8 params:
https://gitlab.com/openbravo/product/openbravo/-/blob/master/src-test/src/org/openbravo/advpaymentmngt/test/FundsTransferTest.java#L167 [^]

This function createTransfer of 8 params it is calling to itself, so it will fail for infinite loop:
https://gitlab.com/openbravo/product/openbravo/-/blob/8ae3396ac3f1a13a082069c6010659536649cc1d/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/FundsTransferActionHandler.java#L157 [^]

This function of 8 params should be deleted, and call directly to the function of 9 params.

Note: deleting that public function it is an api change, but since the function it is broke from 7 years, then we are sure that none it is using it.

After do this the tests are failing for other reasons that should be also fixed.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0056654 closedTriage Omni OMS org.openbravo.advpaymentmngt junit tests are not executed in ci 

-  Notes
(0170265)
hgbot (developer)
2024-10-10 15:30

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1389 [^]
(0171654)
hgbot (developer)
2024-11-07 16:43

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1389 [^]
(0171655)
hgbot (developer)
2024-11-07 16:43

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 188da85ee2621ba2275ddb1fa49aa2fda8db1507
Author: Sabarinath <s.palanisamy@external.orisha.com>
Date: 07-11-2024 10:54:16
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/188da85ee2621ba2275ddb1fa49aa2fda8db1507 [^]

Fixed ISSUE-56656: Modifying FundsTransfer junit test.

---
M src-test/src/org/openbravo/advpaymentmngt/test/FundsTransferTest.java
---

- Issue History
Date Modified Username Field Change
2024-10-04 12:04 gorka_gil New Issue
2024-10-04 12:04 gorka_gil Assigned To => Triage Omni OMS
2024-10-04 12:04 gorka_gil Modules => Core
2024-10-04 12:04 gorka_gil Triggers an Emergency Pack => No
2024-10-04 12:05 gorka_gil Relationship added related to 0056654
2024-10-07 09:36 SABARINATH P Assigned To Triage Omni OMS => SABARINATH P
2024-10-08 10:16 SABARINATH P Status new => scheduled
2024-10-10 15:30 hgbot Note Added: 0170265
2024-11-07 16:43 hgbot Resolution open => fixed
2024-11-07 16:43 hgbot Status scheduled => closed
2024-11-07 16:43 hgbot Note Added: 0171654
2024-11-07 16:43 hgbot Fixed in Version => PR25Q1
2024-11-07 16:43 hgbot Note Added: 0171655

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker