0056656: funds transfer: tests are broken - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0056656

Openbravo ERP

09. Financial management

public

2024-10-04 12:04

2024-11-07 16:43

Reporter

gorka_gil

Assigned To

SABARINATH P

Priority

normal

Severity

minor

Reproducibility

N/A

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

PR25Q1

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0056656: funds transfer: tests are broken

Description

Because of this issue : https://issues.openbravo.com/view.php?id=56654, [^]

the tests of funds transfer are not executed in ci.

Apart of that they are broken from 7 years ago, since they are calling to createTransfer function of 8 params:
https://gitlab.com/openbravo/product/openbravo/-/blob/master/src-test/src/org/openbravo/advpaymentmngt/test/FundsTransferTest.java#L167 [^]

This function createTransfer of 8 params it is calling to itself, so it will fail for infinite loop:
https://gitlab.com/openbravo/product/openbravo/-/blob/8ae3396ac3f1a13a082069c6010659536649cc1d/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/FundsTransferActionHandler.java#L157 [^]

This function of 8 params should be deleted, and call directly to the function of 9 params.

Note: deleting that public function it is an api change, but since the function it is broke from 7 years, then we are sure that none it is using it.

After do this the tests are failing for other reasons that should be also fixed.

Steps To Reproduce

Proposed Solution

Additional Information