Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0056621
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminoralways2024-10-02 12:292024-11-29 12:55
Reporterfermin_ostivarView Statuspublic 
Assigned ToRajesh_18 
PrioritynormalResolutionfixedFixed in Version25Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Regression levelProduction - QA Approved
Regression date2024-08-14
Regression introduced in releasemain
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/111409aa501e50d733b8b0c375a2bcbd071ad192 [^]
Triggers an Emergency PackNo
Summary

0056621: Sales Representative removed when a product is added

DescriptionThe Sales Representative selected is removed when a product is added to the order.
Steps To Reproduce[BOS]
At TouchPoint Type level:
Sales Representative in New Orders * -> Keep it blank
Sales Representative is Mandatory -> False

[POS]
Login
Select a "Sales Representative"
Add a Product

The sales representative is removed from the order
Proposed SolutionDo not remove the sales representative from the order
TagsNo tags attached.
Attached Files? file icon Screencast from 02-10-24 12:25:31.webm [^] (1,524,413 bytes) 2024-10-02 12:29

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0055749 closedsreehari The sales representative is being automatically added to a Verified Return when it should be empty. 
depends on backport 005733324Q4 closedRajesh_18 Sales Representative removed when a product is added 
depends on backport 005733424Q3.3 closedRajesh_18 Sales Representative removed when a product is added 
depends on backport 005733524Q2.5 closedRajesh_18 Sales Representative removed when a product is added 

-  Notes
(0169997)
hgbot (developer)
2024-10-04 11:22

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2967 [^]
(0169998)
hgbot (developer)
2024-10-04 11:25

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/79 [^]
(0172772)
hgbot (developer)
2024-11-29 12:52

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 92ebc93594840393366a1fd63706fa6af72ecc55
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 29-11-2024 11:52:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/92ebc93594840393366a1fd63706fa6af72ecc55 [^]

Fixed ISSUE-56621: Sales Representative is set based on the configuration

---
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/setTicketHeaderAndLineWithSalesRepresentative.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProductActionPreparation.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetDefaultSalesRepresentative.js
R web-jspack/org.openbravo.pos2/src/model/ticket/actions/ReturnVerifiedTicketHooks.js
R web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/ReturnVerifiedTicketHooks.test.js
---
(0172773)
hgbot (developer)
2024-11-29 12:52

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2967 [^]
(0172774)
hgbot (developer)
2024-11-29 12:52

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns [^]
Changeset: 127e7703a4c8880a27d01d50bfe5d7c567dad843
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 04-10-2024 14:23:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/commit/127e7703a4c8880a27d01d50bfe5d7c567dad843 [^]

Related to ISSUE-56621: Sales Representative is set based on the configuration

---
M web/org.openbravo.retail.returns/app/model/business-object/ticket/actions/ReturnVerifiedTicket.js
---
(0172775)
hgbot (developer)
2024-11-29 12:52

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/79 [^]
(0172776)
marvintm (manager)
2024-11-29 12:55

 - Tested that reported problem doesn't happen (now sales representative is not automatically removed when products are added)
- Tested that original issue reported is also not reproducible (when performing verified returns, now the configuration set in the channel touchpoint type is used, so sales representative will or will not be set automatically depending on how the terminal is configured)
- Tested that the configuration to set or not the sales representative is still considered when creating normal orders

- Issue History
Date Modified Username Field Change
2024-10-02 12:29 fermin_ostivar New Issue
2024-10-02 12:29 fermin_ostivar Assigned To => Retail
2024-10-02 12:29 fermin_ostivar File Added: Screencast from 02-10-24 12:25:31.webm
2024-10-02 12:29 fermin_ostivar Triggers an Emergency Pack => No
2024-10-02 12:34 guillermogil Status new => acknowledged
2024-10-02 12:34 guillermogil Relationship added related to 0055749
2024-10-02 12:35 guillermogil Severity major => minor
2024-10-03 11:07 Rajesh_18 Assigned To Retail => Rajesh_18
2024-10-03 11:07 Rajesh_18 Status acknowledged => scheduled
2024-10-03 17:31 Rajesh_18 Regression level => Production - QA Approved
2024-10-03 17:31 Rajesh_18 Regression date => 2024-08-14
2024-10-03 17:31 Rajesh_18 Regression introduced in release => main
2024-10-03 17:31 Rajesh_18 Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/111409aa501e50d733b8b0c375a2bcbd071ad192 [^]
2024-10-04 11:22 hgbot Note Added: 0169997
2024-10-04 11:25 hgbot Note Added: 0169998
2024-11-29 12:51 marvintm Status scheduled => acknowledged
2024-11-29 12:51 marvintm Status acknowledged => scheduled
2024-11-29 12:52 hgbot Resolution open => fixed
2024-11-29 12:52 hgbot Status scheduled => closed
2024-11-29 12:52 hgbot Fixed in Version => 25Q1
2024-11-29 12:52 hgbot Note Added: 0172772
2024-11-29 12:52 hgbot Note Added: 0172773
2024-11-29 12:52 hgbot Note Added: 0172774
2024-11-29 12:52 hgbot Note Added: 0172775
2024-11-29 12:55 marvintm Note Added: 0172776

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker