Openbravo Issue Tracking System - POS2 |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0056621 | POS2 | POS | public | 2024-10-02 12:29 | 2024-11-29 12:55 |
|
| Reporter | fermin_ostivar | |
| Assigned To | Rajesh_18 | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | | Fixed in Version | 25Q1 | |
| Merge Request Status | approved |
| Review Assigned To | |
| OBNetwork customer | No |
| Support ticket | 110175 |
| Regression level | Production - QA Approved |
| Regression date | 2024-08-14 |
| Regression introduced in release | main |
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/111409aa501e50d733b8b0c375a2bcbd071ad192 [^] |
| Triggers an Emergency Pack | No |
|
| Summary | 0056621: Sales Representative removed when a product is added |
| Description | The Sales Representative selected is removed when a product is added to the order. |
| Steps To Reproduce | [BOS]
At TouchPoint Type level:
Sales Representative in New Orders * -> Keep it blank
Sales Representative is Mandatory -> False
[POS]
Login
Select a "Sales Representative"
Add a Product
The sales representative is removed from the order |
| Proposed Solution | Do not remove the sales representative from the order |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0055749 | | closed | sreehari | The sales representative is being automatically added to a Verified Return when it should be empty. | | depends on | backport | 0057333 | 24Q4 | closed | Rajesh_18 | Sales Representative removed when a product is added | | depends on | backport | 0057334 | 24Q3.3 | closed | Rajesh_18 | Sales Representative removed when a product is added | | depends on | backport | 0057335 | 24Q2.5 | closed | Rajesh_18 | Sales Representative removed when a product is added |
|
| Attached Files |  Screencast from 02-10-24 12:25:31.webm (1,524,413) 2024-10-02 12:29
https://issues.openbravo.com/file_download.php?file_id=20211&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2024-10-02 12:29 | fermin_ostivar | New Issue | |
| 2024-10-02 12:29 | fermin_ostivar | Assigned To | => Retail |
| 2024-10-02 12:29 | fermin_ostivar | File Added: Screencast from 02-10-24 12:25:31.webm | |
| 2024-10-02 12:29 | fermin_ostivar | OBNetwork customer | => No |
| 2024-10-02 12:29 | fermin_ostivar | Support ticket | => 110175 |
| 2024-10-02 12:29 | fermin_ostivar | Triggers an Emergency Pack | => No |
| 2024-10-02 12:34 | guillermogil | Status | new => acknowledged |
| 2024-10-02 12:34 | guillermogil | Relationship added | related to 0055749 |
| 2024-10-02 12:35 | guillermogil | Severity | major => minor |
| 2024-10-03 11:07 | Rajesh_18 | Assigned To | Retail => Rajesh_18 |
| 2024-10-03 11:07 | Rajesh_18 | Status | acknowledged => scheduled |
| 2024-10-03 17:31 | Rajesh_18 | Regression level | => Production - QA Approved |
| 2024-10-03 17:31 | Rajesh_18 | Regression date | => 2024-08-14 |
| 2024-10-03 17:31 | Rajesh_18 | Regression introduced in release | => main |
| 2024-10-03 17:31 | Rajesh_18 | Regression introduced by commit | => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/111409aa501e50d733b8b0c375a2bcbd071ad192 [^] |
| 2024-10-04 11:22 | hgbot | Merge Request Status | => open |
| 2024-10-04 11:22 | hgbot | Note Added: 0169997 | |
| 2024-10-04 11:25 | hgbot | Note Added: 0169998 | |
| 2024-11-29 12:51 | marvintm | Status | scheduled => acknowledged |
| 2024-11-29 12:51 | marvintm | Status | acknowledged => scheduled |
| 2024-11-29 12:51 | hgbot | Merge Request Status | open => approved |
| 2024-11-29 12:52 | hgbot | Resolution | open => fixed |
| 2024-11-29 12:52 | hgbot | Status | scheduled => closed |
| 2024-11-29 12:52 | hgbot | Fixed in Version | => 25Q1 |
| 2024-11-29 12:52 | hgbot | Note Added: 0172772 | |
| 2024-11-29 12:52 | hgbot | Note Added: 0172773 | |
| 2024-11-29 12:52 | hgbot | Note Added: 0172774 | |
| 2024-11-29 12:52 | hgbot | Note Added: 0172775 | |
| 2024-11-29 12:55 | marvintm | Note Added: 0172776 | |
|
Notes |
|
|
(0169997)
|
|
hgbot
|
|
2024-10-04 11:22
|
|
|
|
|
(0169998)
|
|
hgbot
|
|
2024-10-04 11:25
|
|
|
|
|
(0172772)
|
|
hgbot
|
|
2024-11-29 12:52
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 92ebc93594840393366a1fd63706fa6af72ecc55
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 29-11-2024 11:52:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/92ebc93594840393366a1fd63706fa6af72ecc55 [^]
Fixed ISSUE-56621: Sales Representative is set based on the configuration
---
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/setTicketHeaderAndLineWithSalesRepresentative.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProductActionPreparation.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetDefaultSalesRepresentative.js
R web-jspack/org.openbravo.pos2/src/model/ticket/actions/ReturnVerifiedTicketHooks.js
R web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/ReturnVerifiedTicketHooks.test.js
---
|
|
|
|
(0172773)
|
|
hgbot
|
|
2024-11-29 12:52
|
|
|
|
|
(0172774)
|
|
hgbot
|
|
2024-11-29 12:52
|
|
|
|
|
(0172775)
|
|
hgbot
|
|
2024-11-29 12:52
|
|
|
|
|
|
- Tested that reported problem doesn't happen (now sales representative is not automatically removed when products are added)
- Tested that original issue reported is also not reproducible (when performing verified returns, now the configuration set in the channel touchpoint type is used, so sales representative will or will not be set automatically depending on how the terminal is configured)
- Tested that the configuration to set or not the sales representative is still considered when creating normal orders |
|