Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0056345
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminoralways2024-09-03 08:102024-09-05 15:39
ReportermigueldejuanaView Statuspublic 
Assigned Tosreehari 
PrioritynormalResolutionopenFixed in Version
StatusscheduledFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0056345: External Orders API

DescriptionWhen building the request for External Orders we do not define a proper request data in some tipe of actions.

SEARCH and LOAD actions send a request with a wrong structure having data inside data:

data: {
  data: {
    ...
  }
}

We should only have one data instead of 2 nested datas.
We can take COMMIT action as example.
Steps To Reproduce- In Organization check "Enable External Orders"
- In External System window, create a new onw with Protocol "Javascript - Frontend" and set JS Class Name to "OB.EXOTEST.ExternalOrdersSimulator"
- Create an Event Subscription of type "External Event Order" and select created External System
- Login in POS2 and got to option menu External Orders
- In the filter write "00"
- SEARCH action is launched and we can see in the console the request sent with data nested
- Click on one row and - LOAD action is launched and we can see in the console the request sent with data nested
- Complete the ticket and - COMMIT action is launched and we can see in the console the request sent WITHOUT data nested
Proposed SolutionWe have to send the request without nested data and change External Simulator to adapt it to the new structure
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 005638024Q3.1 closedsreehari External Orders API 
depends on backport 005638124Q2.3 closedsreehari External Orders API 
causes defect 0056683pi closedsreehari External Orders API 

-  Notes
(0168754)
hgbot (developer)
2024-09-05 05:50

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/6 [^]
(0168755)
hgbot (developer)
2024-09-05 08:24

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/6 [^]
(0168756)
hgbot (developer)
2024-09-05 08:24

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders [^]
Changeset: 5bc77c8fe1e017557743903fa1b64256807549a7
Author: Sreehari Venkataraman <s.venkataraman@external.orisha.com>
Date: 04-09-2024 14:45:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/commit/5bc77c8fe1e017557743903fa1b64256807549a7 [^]

Fixes ISSUE-56345: Removed nested data object request

---
M web-jspack/org.openbravo.events.orders/src/components/ExternalOrders/ExternalOrdersGrid/GetExternalOrdersList.js
M web-jspack/org.openbravo.events.orders/src/components/ExternalOrders/ExternalOrdersGrid/GetExternalOrdersTicket.js
M web/org.openbravo.events.orders/app/model/business-object/simulator/ExternalOrdersSimulator.js
---

- Issue History
Date Modified Username Field Change
2024-09-03 08:10 migueldejuana New Issue
2024-09-03 08:10 migueldejuana Assigned To => Retail
2024-09-03 08:10 migueldejuana Triggers an Emergency Pack => No
2024-09-03 08:13 sreehari Assigned To Retail => sreehari
2024-09-04 08:09 sreehari Status new => scheduled
2024-09-05 05:50 hgbot Note Added: 0168754
2024-09-05 08:24 hgbot Note Added: 0168755
2024-09-05 08:24 hgbot Resolution open => fixed
2024-09-05 08:24 hgbot Status scheduled => closed
2024-09-05 08:24 hgbot Note Added: 0168756
2024-09-05 15:31 sreehari Status closed => new
2024-09-05 15:31 sreehari Resolution fixed => open
2024-09-05 15:39 sreehari Status new => scheduled
2024-10-08 09:22 sreehari Relationship added causes 0056683


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker