Openbravo Issue Tracking System - POS2
View Issue Details
0056345POS2POSpublic2024-09-03 08:102024-09-05 15:39
migueldejuana 
sreehari 
normalminoralways
scheduledopen 
5
 
 
No
0056345: External Orders API
When building the request for External Orders we do not define a proper request data in some tipe of actions.

SEARCH and LOAD actions send a request with a wrong structure having data inside data:

data: {
  data: {
    ...
  }
}

We should only have one data instead of 2 nested datas.
We can take COMMIT action as example.
- In Organization check "Enable External Orders"
- In External System window, create a new onw with Protocol "Javascript - Frontend" and set JS Class Name to "OB.EXOTEST.ExternalOrdersSimulator"
- Create an Event Subscription of type "External Event Order" and select created External System
- Login in POS2 and got to option menu External Orders
- In the filter write "00"
- SEARCH action is launched and we can see in the console the request sent with data nested
- Click on one row and - LOAD action is launched and we can see in the console the request sent with data nested
- Complete the ticket and - COMMIT action is launched and we can see in the console the request sent WITHOUT data nested
We have to send the request without nested data and change External Simulator to adapt it to the new structure
No tags attached.
depends on backport 005638024Q3.1 closed sreehari External Orders API 
depends on backport 005638124Q2.3 closed sreehari External Orders API 
causes defect 0056683pi closed sreehari External Orders API 
Issue History
2024-09-03 08:10migueldejuanaNew Issue
2024-09-03 08:10migueldejuanaAssigned To => Retail
2024-09-03 08:10migueldejuanaTriggers an Emergency Pack => No
2024-09-03 08:13sreehariAssigned ToRetail => sreehari
2024-09-04 08:09sreehariStatusnew => scheduled
2024-09-05 05:50hgbotNote Added: 0168754
2024-09-05 08:24hgbotNote Added: 0168755
2024-09-05 08:24hgbotResolutionopen => fixed
2024-09-05 08:24hgbotStatusscheduled => closed
2024-09-05 08:24hgbotNote Added: 0168756
2024-09-05 15:31sreehariStatusclosed => new
2024-09-05 15:31sreehariResolutionfixed => open
2024-09-05 15:39sreehariStatusnew => scheduled
2024-10-08 09:22sreehariRelationship addedcauses 0056683

Notes
(0168754)
hgbot   
2024-09-05 05:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/6 [^]
(0168755)
hgbot   
2024-09-05 08:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/6 [^]
(0168756)
hgbot   
2024-09-05 08:24   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders [^]
Changeset: 5bc77c8fe1e017557743903fa1b64256807549a7
Author: Sreehari Venkataraman <s.venkataraman@external.orisha.com>
Date: 04-09-2024 14:45:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/commit/5bc77c8fe1e017557743903fa1b64256807549a7 [^]

Fixes ISSUE-56345: Removed nested data object request

---
M web-jspack/org.openbravo.events.orders/src/components/ExternalOrders/ExternalOrdersGrid/GetExternalOrdersList.js
M web-jspack/org.openbravo.events.orders/src/components/ExternalOrders/ExternalOrdersGrid/GetExternalOrdersTicket.js
M web/org.openbravo.events.orders/app/model/business-object/simulator/ExternalOrdersSimulator.js
---