Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0055625
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Copy Retail Storeminoralways2024-05-30 12:392024-06-07 08:53
ReportermartinsdanView Statuspublic 
Assigned Tosreehari 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version11
OS VersionUbuntu 18.04.1 LTSDatabase version10.10Ant version1.10.5
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression levelPackaging and release
Regression date2024-03-20
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/049be8553b7975a7cf5486a4987feceaf914225f [^]
Triggers an Emergency PackNo
Summary

0055625: Spread payment for all tills is not working

DescriptionSpread Payment Method does not work between Touchpoint Types when they are created at * Organization.
When creating a Touchpoint Type Payment Method cloning from one created with org*, it fails with a NPE.

[http-nio-127.0.0.1-8080-exec-6] ERROR org.openbravo.copyprocess.process.CopyEntityProcess - null
java.lang.NullPointerException: null
    at org.openbravo.retail.copystore.process.DefaultPropertiesHandler$TerminalPaymentTypeProperties$TerminalPaymentTypeCurrencyProperty.handleProperty(DefaultPropertiesHandler.java:1057) ~[classes/:?]
    at org.openbravo.copyprocess.process.CopyEntityProcess.processProperty(CopyEntityProcess.java:626) [classes/:?]
    at org.openbravo.copyprocess.process.CopyEntityProcess.cloneObject(CopyEntityProcess.java:220) [classes/:?]
    at org.openbravo.retail.copystore.process.CopyPaymentMethodProcess.createNewTerminalTypePaymentMethod(CopyPaymentMethodProcess.java:262) ~[classes/:?]
Steps To ReproduceEnsure you have a touchpoint associated with a touchpoint type created at * level.

- Create a new payment method in that touchpoint
- Click "Spread payment for selected tills"
- Select a different touchpoint type

It fails without an error message
Proposed SolutionWhen trying to copy the payment method to a new Touchpoint Type, a new Touchpoint Type Payment Method needs to be created. As the original one is created at * org, that org does not have a currency, and a currency validation fails.

The process needs to be updated, considering touchpoint types can be created at *.

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/blob/master/src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java?ref_type=heads#L1057 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0055627 closedsreehari Spread payment method for selected tills does not work for the same Touchpoint Type 
depends on backport 0055669RR24Q2 closedsreehari Spread payment for all tills is not working 
caused by defect 0054976 closedRetail Currency for Payment Method and - Cash Management events in Copy Retail Store 

-  Notes
(0165480)
hgbot (developer)
2024-06-03 15:23

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/72 [^]
(0165495)
hgbot (developer)
2024-06-04 06:54

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore [^]
Changeset: 682589ddc349845685425210f579d269a8c6ab10
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 04-06-2024 04:50:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/682589ddc349845685425210f579d269a8c6ab10 [^]

Fixes ISSUE-55625: Added null validation, now payment currency is set
*when Organization has no currency, currency from the payment method is set

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0165496)
hgbot (developer)
2024-06-04 06:54

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/72 [^]

- Issue History
Date Modified Username Field Change
2024-05-30 12:39 martinsdan New Issue
2024-05-30 12:39 martinsdan Assigned To => Retail
2024-05-30 12:39 martinsdan OBNetwork customer => OBPS
2024-05-30 12:39 martinsdan Triggers an Emergency Pack => No
2024-05-30 12:39 martinsdan Issue Monitored: azabaleta
2024-05-30 14:26 rafaroda Relationship added related to 0055627
2024-06-03 08:09 guillermogil Status new => acknowledged
2024-06-03 08:18 sreehari Assigned To Retail => sreehari
2024-06-03 08:18 sreehari Status acknowledged => scheduled
2024-06-03 15:23 hgbot Merge Request Status => open
2024-06-03 15:23 hgbot Note Added: 0165480
2024-06-04 06:54 hgbot Merge Request Status open => approved
2024-06-04 06:54 hgbot Resolution open => fixed
2024-06-04 06:54 hgbot Status scheduled => closed
2024-06-04 06:54 hgbot Note Added: 0165495
2024-06-04 06:54 hgbot Note Added: 0165496
2024-06-04 06:57 guillermogil Regression level => Packaging and release
2024-06-04 06:57 guillermogil Regression date => 2024-03-20
2024-06-04 06:57 guillermogil Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/049be8553b7975a7cf5486a4987feceaf914225f [^]
2024-06-04 06:57 guillermogil Relationship added caused by 0054976
2024-06-04 12:54 sreehari Status closed => new
2024-06-04 12:54 sreehari Resolution fixed => open
2024-06-04 12:54 sreehari Status new => scheduled
2024-06-07 08:53 sreehari Status scheduled => resolved
2024-06-07 08:53 sreehari Resolution open => fixed
2024-06-07 08:53 sreehari Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker