Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055625Retail ModulesCopy Retail Storepublic2024-05-30 12:392024-06-07 08:53
Reportermartinsdan 
Assigned Tosreehari 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionUbuntu 18.04.1 LTS
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression levelPackaging and release
Regression date2024-03-20
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/049be8553b7975a7cf5486a4987feceaf914225f [^]
Triggers an Emergency PackNo
Summary0055625: Spread payment for all tills is not working
DescriptionSpread Payment Method does not work between Touchpoint Types when they are created at * Organization.
When creating a Touchpoint Type Payment Method cloning from one created with org*, it fails with a NPE.

[http-nio-127.0.0.1-8080-exec-6] ERROR org.openbravo.copyprocess.process.CopyEntityProcess - null
java.lang.NullPointerException: null
    at org.openbravo.retail.copystore.process.DefaultPropertiesHandler$TerminalPaymentTypeProperties$TerminalPaymentTypeCurrencyProperty.handleProperty(DefaultPropertiesHandler.java:1057) ~[classes/:?]
    at org.openbravo.copyprocess.process.CopyEntityProcess.processProperty(CopyEntityProcess.java:626) [classes/:?]
    at org.openbravo.copyprocess.process.CopyEntityProcess.cloneObject(CopyEntityProcess.java:220) [classes/:?]
    at org.openbravo.retail.copystore.process.CopyPaymentMethodProcess.createNewTerminalTypePaymentMethod(CopyPaymentMethodProcess.java:262) ~[classes/:?]
Steps To ReproduceEnsure you have a touchpoint associated with a touchpoint type created at * level.

- Create a new payment method in that touchpoint
- Click "Spread payment for selected tills"
- Select a different touchpoint type

It fails without an error message
Proposed SolutionWhen trying to copy the payment method to a new Touchpoint Type, a new Touchpoint Type Payment Method needs to be created. As the original one is created at * org, that org does not have a currency, and a currency validation fails.

The process needs to be updated, considering touchpoint types can be created at *.

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/blob/master/src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java?ref_type=heads#L1057 [^]
Additional Information
TagsNo tags attached.
Relationships
related to defect 0055627 closed sreehari Spread payment method for selected tills does not work for the same Touchpoint Type 
depends on backport 0055669RR24Q2 closed sreehari Spread payment for all tills is not working 
caused by defect 0054976 closed Retail Currency for Payment Method and - Cash Management events in Copy Retail Store 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-05-30 12:39martinsdanNew Issue
2024-05-30 12:39martinsdanAssigned To => Retail
2024-05-30 12:39martinsdanOBNetwork customer => OBPS
2024-05-30 12:39martinsdanTriggers an Emergency Pack => No
2024-05-30 12:39martinsdanIssue Monitored: azabaleta
2024-05-30 14:26rafarodaRelationship addedrelated to 0055627
2024-06-03 08:09guillermogilStatusnew => acknowledged
2024-06-03 08:18sreehariAssigned ToRetail => sreehari
2024-06-03 08:18sreehariStatusacknowledged => scheduled
2024-06-03 15:23hgbotMerge Request Status => open
2024-06-03 15:23hgbotNote Added: 0165480
2024-06-04 06:54hgbotMerge Request Statusopen => approved
2024-06-04 06:54hgbotResolutionopen => fixed
2024-06-04 06:54hgbotStatusscheduled => closed
2024-06-04 06:54hgbotNote Added: 0165495
2024-06-04 06:54hgbotNote Added: 0165496
2024-06-04 06:57guillermogilRegression level => Packaging and release
2024-06-04 06:57guillermogilRegression date => 2024-03-20
2024-06-04 06:57guillermogilRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/049be8553b7975a7cf5486a4987feceaf914225f [^]
2024-06-04 06:57guillermogilRelationship addedcaused by 0054976
2024-06-04 12:54sreehariStatusclosed => new
2024-06-04 12:54sreehariResolutionfixed => open
2024-06-04 12:54sreehariStatusnew => scheduled
2024-06-07 08:53sreehariStatusscheduled => resolved
2024-06-07 08:53sreehariResolutionopen => fixed
2024-06-07 08:53sreehariStatusresolved => closed

Notes
(0165480)
hgbot   
2024-06-03 15:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/72 [^]
(0165495)
hgbot   
2024-06-04 06:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore [^]
Changeset: 682589ddc349845685425210f579d269a8c6ab10
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 04-06-2024 04:50:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/682589ddc349845685425210f579d269a8c6ab10 [^]

Fixes ISSUE-55625: Added null validation, now payment currency is set
*when Organization has no currency, currency from the payment method is set

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0165496)
hgbot   
2024-06-04 06:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/72 [^]